sjs/Peekaboo
1
0
Fork 0
mirror of https://github.com/samsonjs/Peekaboo.git synced 2026-04-27 15:07:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix Swift CLI integration tests to match actual command structure

Browse source
This commit is contained in:
Peter Steinberger 2025-05-25 19:41:12 +02:00
parent 61d6ef0cee
commit 93a1baf596
1 changed files with 50 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

68
scripts/prepare-release.js
View file

@ -551,17 +551,40 @@ function checkSwiftCLIIntegration() {
return false; return false;
} }
// Test 2: Missing required arguments // Test 2: Missing required arguments for window mode
const missingArgs = exec('./peekaboo image --mode app --json-output 2>&1', { allowFailure: true }); const missingArgs = exec('./peekaboo image --mode window --json-output 2>&1', { allowFailure: true });
if (!missingArgs || (!missingArgs.includes('error') && !missingArgs.includes('Error'))) { if (!missingArgs) {
logError('Swift CLI should show error for missing --app with app mode'); logError('Swift CLI should produce output for missing --app with window mode');
return false; return false;
} }
// Test 3: Invalid window ID try {
const invalidWindowId = exec('./peekaboo image --mode window --window-id abc --json-output 2>&1', { allowFailure: true }); const errorData = JSON.parse(missingArgs);
if (!invalidWindowId || !invalidWindowId.includes('Error')) { if (!errorData.error || errorData.success !== false) {
logError('Swift CLI should show error for invalid window ID'); logError('Swift CLI should return error JSON for missing --app with window mode');
return false;
}
} catch (e) {
logError('Swift CLI should return valid JSON for missing --app error');
return false;
}
// Test 3: Invalid window index
let invalidWindowOutput;
try {
execSync('./peekaboo image --mode window --app Finder --window-index abc --json-output 2>&1', {
cwd: projectRoot,
encoding: 'utf8',
stdio: 'pipe'
});
logError('Swift CLI should fail for invalid window index');
return false;
} catch (error) {
invalidWindowOutput = error.stdout || error.stderr || error.toString();
}
if (!invalidWindowOutput.includes('invalid for') || !invalidWindowOutput.includes('window-index')) {
logError('Swift CLI should show error for invalid window index');
return false; return false;
} }
@ -577,8 +600,7 @@ function checkSwiftCLIIntegration() {
// Test 5: JSON output format validation // Test 5: JSON output format validation
const formats = [ const formats = [
{ cmd: './peekaboo list server_status --json-output', required: ['has_screen_recording_permission'] }, { cmd: './peekaboo list apps --json-output', required: ['success', 'data'] }
{ cmd: './peekaboo list running_applications --json-output', required: ['applications'] }
]; ];
for (const { cmd, required } of formats) { for (const { cmd, required } of formats) {
@ -589,27 +611,37 @@ function checkSwiftCLIIntegration() {
} }
try { try {
const data = JSON.parse(output); const response = JSON.parse(output);
for (const field of required) { for (const field of required) {
if (!(field in data)) { if (!(field in response)) {
logError(`Missing required field '${field}' in: ${cmd}`); logError(`Missing required field '${field}' in: ${cmd}`);
return false; return false;
} }
} }
// For list apps, also check data.applications exists
if (cmd.includes('list apps') && (!response.data || !response.data.applications)) {
logError(`Missing data.applications in: ${cmd}`);
return false;
}
} catch (e) { } catch (e) {
logError(`Invalid JSON from: ${cmd}`); logError(`Invalid JSON from: ${cmd}`);
return false; return false;
} }
} }
// Test 6: Permission handling // Test 6: Permission info in error messages
const permissionTest = exec('./peekaboo list server_status --json-output', { allowFailure: true }); // Try to capture without permissions (this is just a smoke test, actual permission errors depend on system state)
if (permissionTest) { const captureTest = exec('./peekaboo image --mode screen --json-output', { allowFailure: true });
if (captureTest) {
try { try {
const status = JSON.parse(permissionTest); const result = JSON.parse(captureTest);
log(`Permissions - Screen Recording: ${status.has_screen_recording_permission}, Accessibility: ${status.has_accessibility_permission}`, colors.cyan); if (result.success) {
log('Screen capture succeeded (permissions granted)', colors.cyan);
} else if (result.error && result.error.code === 'PERMISSION_DENIED_SCREEN_RECORDING') {
log('Screen recording permission correctly detected as missing', colors.cyan);
}
} catch (e) { } catch (e) {
// Ignore, already tested above // Not JSON, might be a different error
} }
} }