sjs/SJSAssetExportSession
1
0
Fork 0
mirror of https://github.com/samsonjs/SJSAssetExportSession.git synced 2026-04-27 14:57:46 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Finish writing comment and add FIXME for macOS runtime error

Browse source
This commit is contained in:
Sami Samhuri 2024-08-18 09:32:06 -07:00
parent 79370a0e54
commit 66700260fb
No known key found for this signature in database
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
SJSAssetExportSession/SampleWriter.swift
View file

@ -21,7 +21,8 @@ actor SampleWriter {
) )
// Execute this actor on the same queue we use to request media data so we can use // Execute this actor on the same queue we use to request media data so we can use
// `assumeIsolated` to ensure that we // `assumeIsolated` to ensure that we serialize access to our state without creating
// tasks and doing lots of needless context-switching.
public nonisolated var unownedExecutor: UnownedSerialExecutor { public nonisolated var unownedExecutor: UnownedSerialExecutor {
queue.asUnownedSerialExecutor() queue.asUnownedSerialExecutor()
} }
@ -228,6 +229,7 @@ actor SampleWriter {
return await withTaskCancellationHandler { return await withTaskCancellationHandler {
await withCheckedContinuation { continuation in await withCheckedContinuation { continuation in
self.videoInput!.requestMediaDataWhenReady(on: queue) { self.videoInput!.requestMediaDataWhenReady(on: queue) {
#warning("FIXME: why is this broken on macOS?!")
self.assumeIsolated { _self in self.assumeIsolated { _self in
guard !_self.isCancelled else { guard !_self.isCancelled else {
log.debug("Cancelled while encoding video") log.debug("Cancelled while encoding video")