From 814a659d93c34868d53217bd20746e441bca9fdc Mon Sep 17 00:00:00 2001 From: ryandailey100 Date: Thu, 25 May 2017 13:43:46 -0400 Subject: [PATCH] Fixed retain cycle bug with delegates - Added weak reference to delegates --- Source/SwiftyCamButton.swift | 4 ++-- Source/SwiftyCamViewController.swift | 2 +- Source/SwiftyCamViewControllerDelegate.swift | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Source/SwiftyCamButton.swift b/Source/SwiftyCamButton.swift index 0ac42bb..e36a676 100644 --- a/Source/SwiftyCamButton.swift +++ b/Source/SwiftyCamButton.swift @@ -20,7 +20,7 @@ import UIKit /// Delegate for SwiftyCamButton -public protocol SwiftyCamButtonDelegate { +public protocol SwiftyCamButtonDelegate: class { /// Called when UITapGestureRecognizer begins @@ -52,7 +52,7 @@ open class SwiftyCamButton: UIButton { /// Delegate variable - public var delegate: SwiftyCamButtonDelegate? + public weak var delegate: SwiftyCamButtonDelegate? /// Maximum duration variable diff --git a/Source/SwiftyCamViewController.swift b/Source/SwiftyCamViewController.swift index 5b5e032..dbe7dd6 100644 --- a/Source/SwiftyCamViewController.swift +++ b/Source/SwiftyCamViewController.swift @@ -91,7 +91,7 @@ open class SwiftyCamViewController: UIViewController { /// Public Camera Delegate for the Custom View Controller Subclass - public var cameraDelegate: SwiftyCamViewControllerDelegate? + public weak var cameraDelegate: SwiftyCamViewControllerDelegate? /// Maxiumum video duration if SwiftyCamButton is used diff --git a/Source/SwiftyCamViewControllerDelegate.swift b/Source/SwiftyCamViewControllerDelegate.swift index d058648..c98e364 100644 --- a/Source/SwiftyCamViewControllerDelegate.swift +++ b/Source/SwiftyCamViewControllerDelegate.swift @@ -20,7 +20,7 @@ import UIKit /// Delegate for SwiftyCamViewController -public protocol SwiftyCamViewControllerDelegate { +public protocol SwiftyCamViewControllerDelegate: class { /** SwiftyCamViewControllerDelegate function called when the takePhoto() function is called.