88 commits

Author	SHA1	Message	Date
Brandon Evans	b8bae4f32c	Don't consider versions without build identifiers for identical builds	2021-02-06 14:56:28 -07:00
Brandon Evans	760c9f300e	Handle duplicate 3.2.3 release builds ... :/	2021-02-04 21:25:01 -07:00
Brandon Evans	dcd4001548	Merge identical builds into the release version instead of filtering	2021-02-04 21:25:00 -07:00
Brandon Evans	bc45daeb74	Only adjust available versions for Apple data source	2021-02-04 21:25:00 -07:00
Brandon Evans	7ac4814420	Treat GM versions as release versions	2021-02-04 21:25:00 -07:00
Brandon Evans	57767f6920	Fix RC capitalization	2021-02-04 21:25:00 -07:00
Matt Kiazyk	75cbd9550b	Adjust ByteCountFormatter. PR Feedback	2021-02-03 21:55:47 -06:00
Matt Kiazyk	b53c480764	Adds a DownloadFileSize when using Apple Data Source	2021-02-01 21:18:49 -06:00
Brandon Evans	352816f64a	Merge pull request #87 from RobotsAndPencils/auth-pref-ui-change ... Show stored username in General preference pane even when we don't have a valid session	2021-01-26 08:50:18 -07:00
Brandon Evans	75457dd9eb	Show stored username in General preference pane ... This reverts the change from 90c067997b so that the username is shown in situations where we don't have a valid session but could almost certainly get one. Instead, to achieve what that commit was trying to do, we'll instead remove the username from UserDefaults if auth fails with an invalid username or password error. I think this will more closely match what users expect in this UI. I've added a comment in the UI explaining why it is the way it is. It might also be worth considering renaming AuthenticationState or its cases to better reflect that it's probably more about the (short-lived) session state than whether the user has signed in before and has stored their credentials.	2021-01-25 19:56:28 -07:00
Brandon Evans	58cddb88f6	Try to improve auth error messages	2021-01-25 19:36:49 -07:00
Brandon Evans	cb507c3d02	Prepare user for helper installation before post-install steps	2021-01-23 20:25:28 -07:00
Brandon Evans	044f066422	Extract HelperInstallState to new file	2021-01-23 19:38:11 -07:00
Brandon Evans	d84173e29c	Prepare user for helper installation ... Doesn't yet handle the post-install steps that need the helper.	2021-01-23 19:38:11 -07:00
Brandon Evans	408d05a4a7	Merge pull request #80 from RobotsAndPencils/handle-helper-install-errors ... Handle helper installation errors	2021-01-23 15:00:57 -07:00
Brandon Evans	91293557ec	Catch and reword xip "not enough free space" error	2021-01-23 13:28:43 -07:00
Brandon Evans	6b5c288a40	Unwrap auth error messages to avoid "Optional(...)"	2021-01-22 22:19:31 -07:00
Brandon Evans	e21e4d9cdf	Handle helper installation errors	2021-01-22 22:18:59 -07:00
Matt Kiazyk	aa49f36b03	don't show brackets when buildMetadataIdentifiers is empty	2021-01-20 21:13:53 -06:00
Brandon Evans	e467f26adc	Add more logging to HelperClient	2021-01-17 12:37:40 -07:00
Brandon Evans	3d5edb3968	Replace NSError() with specific error	2021-01-17 12:29:28 -07:00
Brandon Evans	55e0447e54	Invalidate XPC connection after installing	2021-01-17 11:57:45 -07:00
Brandon Evans	a504504825	Always show build identifiers in list and info pane	2021-01-16 13:30:52 -07:00
Brandon Evans	4301667000	Replace print/dump/NSLog with os.log Logger	2021-01-16 13:14:27 -07:00
Brandon Evans	cd2bde2272	Move Xcode path into XcodeInstallState.installed case	2021-01-16 13:09:48 -07:00
Brandon Evans	bc27f1785b	Filter out prerelease versions that have the same build identifier as a release build	2021-01-16 11:40:27 -07:00
Brandon Evans	62237bf4a8	Fix a bug when an installed version was appended ... We were appending a version without appending a corresponding AvailableXcode, and these two arrays were being zipped later so they wouldn't line up. This change simplifies this method a bit by working on only a single array, and then also moves that appending to the end after the array of Xcodes is created.	2021-01-16 11:40:04 -07:00
Brandon Evans	26da7969a1	Make sure install updates happen on main queue	2021-01-16 10:15:39 -07:00
Brandon Evans	ed023218b8	Simplify Version comparison	2021-01-16 10:15:39 -07:00
Brandon Evans	faad4c2ab7	Fix bug where adjusted versions weren't used to look up AvailableXcodes	2021-01-16 10:15:39 -07:00
Brandon Evans	baa8491786	If build metadata identifiers match, treat it as a match regardless of other version components	2021-01-16 10:15:39 -07:00
Brandon Evans	ad02e89449	Add failing test to cover removing an uninstalled version, fix it ... https://github.com/RobotsAndPencils/XcodesApp/pull/44#issuecomment-756783640	2021-01-16 10:15:32 -07:00
Brandon Evans	0295bc8b1b	Stop aria2c if Xcodes stops ... I removed this because I thought it wasn't necessary for some reason. We do send a SIGTERM if the user cancels the installation (via subscription cancellation), but if the whole app quits aria2c would keep running in the background.	2021-01-12 20:51:22 -07:00
Brandon Evans	93f819f2f3	Add downloaders to SettingsView	2021-01-08 17:22:38 -07:00
Brandon Evans	23cd43011b	Bundle aria2c 1.35.0 executable and source	2021-01-08 17:22:38 -07:00
Brandon Evans	fecb40893f	Don't replace existing install state when updating	2021-01-07 21:25:08 -07:00
Brandon Evans	4a33d010a8	Confirm before cancelling installation	2021-01-07 21:25:08 -07:00
Brandon Evans	1a830dc9dc	Add cancel install button to context menu and info pane	2021-01-07 21:25:08 -07:00
Brandon Evans	482b32e4e0	Add isTesting to make NSTestCase check more clear	2021-01-07 21:25:07 -07:00
Brandon Evans	89143b8751	Dispatch Process.run work manually instead of using subscribe(on:) and receive(on:) ... The previous implementation was doing something weird when it was used during installation in: verifySecurityAssessment(of: installedXcode) .combineLatest(self.verifySigningCertificate(of: installedXcode.path.url)) It looks like it would subscribe after the Process.run future had already sent a value, and so it would never finish. This seems weird, and I'm assuming that I'm misunderstanding something about this behaviour, but dispatching manually seems reasonable and works.	2021-01-07 21:25:07 -07:00
Brandon Evans	bfb3fd9ea5	Add install functionality ... I'm omitting aria2 support for now.	2021-01-07 21:25:07 -07:00
Brandon Evans	a3e9101397	Replace .alert with .emittingError	2021-01-04 16:23:35 -07:00
Brandon Evans	813489b5fa	Add Environment+Mock	2021-01-03 10:18:48 -07:00
Brandon Evans	b1e6cffd09	Use helper from Current	2021-01-03 10:18:08 -07:00
Brandon Evans	f3680da2ae	Add InstallationStepView	2021-01-01 15:36:20 -07:00
Brandon Evans	ba1c4fec0f	Merge pull request #38 from RobotsAndPencils/remove-promisekit ... Remove PromiseKit	2021-01-01 15:03:34 -07:00
Brandon Evans	245780023b	Convert Current.shell to Combine	2021-01-01 15:02:21 -07:00
Brandon Evans	f00ae396a6	Remove Current.shell sudo functionality ... This'll be done in the helper	2021-01-01 15:02:20 -07:00
Brandon Evans	9971e0b45d	Remove Promise retry functions ... We'll need to reimplement these later when implementing installation	2021-01-01 15:02:20 -07:00
Brandon Evans	fa277ccaae	Convert URLSession.downloadTask to Combine	2021-01-01 15:02:20 -07:00