mirror of
https://github.com/ypresto/SwiftLintXcode.git
synced 2026-03-25 08:55:51 +00:00
Compare commits
16 commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
3d7ada8364 | ||
|
|
7fbccc4058 | ||
|
|
517d754a28 | ||
|
|
6c7cb2bb6c | ||
|
|
642cb0c26d | ||
|
|
06a8dfa701 | ||
|
|
adbc152040 | ||
|
|
c6421c4132 | ||
|
|
7bccda5767 | ||
|
|
ef0d9f356f | ||
|
|
e4504a599b | ||
|
|
bc71bf7ea0 | ||
|
|
98c95a2143 | ||
|
|
4246f4cc72 | ||
|
|
62d37329cc | ||
|
|
58d40869da |
14 changed files with 193 additions and 84 deletions
4
.swiftlint.yml
Normal file
4
.swiftlint.yml
Normal file
|
|
@ -0,0 +1,4 @@
|
|||
disabled_rules:
|
||||
- line_length
|
||||
- force_cast
|
||||
- todo
|
||||
25
CHANGELOG.md
25
CHANGELOG.md
|
|
@ -1,6 +1,31 @@
|
|||
Change Log
|
||||
==========
|
||||
|
||||
Version 0.2.1
|
||||
----------------------------
|
||||
|
||||
- Added UUIDs for Xcode <=8.3.
|
||||
|
||||
|
||||
Version 0.2.0
|
||||
----------------------------
|
||||
|
||||
- Xcode 8 Support.
|
||||
|
||||
|
||||
Version 0.1.2
|
||||
----------------------------
|
||||
|
||||
- Fixed bug that saving non-swift file runs autocorrect.
|
||||
- Set working directory to where workspace (or project) file is placed.
|
||||
|
||||
|
||||
Version 0.1.1
|
||||
----------------------------
|
||||
|
||||
- Rename plug-in name: SwiftLintAutoCorrect -> SwiftLintXcode.
|
||||
|
||||
|
||||
Version 0.1.0
|
||||
----------------------------
|
||||
|
||||
|
|
|
|||
24
README.md
24
README.md
|
|
@ -8,14 +8,30 @@ Runs `swiftlint autocorrect --path CURRENT_FILE` before \*.swift file is saved.
|
|||

|
||||
|
||||
|
||||
IMPORTANT: Xcode 8 Installation
|
||||
-------------------------------
|
||||
|
||||
Xcode 8 won't load any unsigned plugins without resigning Xcode itself.
|
||||
https://github.com/alcatraz/Alcatraz/issues/475
|
||||
|
||||
See XVim's nice and simple installation doc to resign it..! (NOTE: AT YOUR OWN SECURITY RISK)
|
||||
https://github.com/XVimProject/XVim/blob/3167408ade82cfef87acc704822da61af69688f8/INSTALL_Xcode8.md
|
||||
|
||||
|
||||
INSTALLATION
|
||||
------------
|
||||
|
||||
```bash
|
||||
# This plugin does not bundle swiftlint binary.
|
||||
# Please ensure swiftlint is on PATH.
|
||||
brew update && brew install swiftlint
|
||||
Install via [Alcatraz](https://github.com/alcatraz/Alcatraz), a package manager for Xcode.
|
||||
|
||||
This plugin does not bundle swiftlint binary. Please ensure swiftlint is on PATH.
|
||||
|
||||
```bash
|
||||
brew update && brew install swiftlint
|
||||
```
|
||||
|
||||
### Manual installation
|
||||
|
||||
```bash
|
||||
git clone https://github.com/ypresto/SwiftLintXcode
|
||||
cd SwiftLintXcode
|
||||
# Build and install.
|
||||
|
|
|
|||
|
|
@ -9,6 +9,8 @@
|
|||
/* Begin PBXBuildFile section */
|
||||
0498717F1CB27F8900C5F7B5 /* SwiftLintXcodeTRVSXcode.m in Sources */ = {isa = PBXBuildFile; fileRef = 0498717E1CB27F8900C5F7B5 /* SwiftLintXcodeTRVSXcode.m */; };
|
||||
049871811CB28EBF00C5F7B5 /* Formatter.swift in Sources */ = {isa = PBXBuildFile; fileRef = 049871801CB28EBF00C5F7B5 /* Formatter.swift */; };
|
||||
04DFAD471CB508D1007998DF /* SwiftLintXcodeIDEHelper.m in Sources */ = {isa = PBXBuildFile; fileRef = 04DFAD461CB508D1007998DF /* SwiftLintXcodeIDEHelper.m */; };
|
||||
04DFAD491CB50BC8007998DF /* errorHelper.swift in Sources */ = {isa = PBXBuildFile; fileRef = 04DFAD481CB50BC8007998DF /* errorHelper.swift */; };
|
||||
04E4BF341CB25D3200BC7305 /* SwiftLintXcode.xcscheme in Resources */ = {isa = PBXBuildFile; fileRef = 04E4BF331CB25D3200BC7305 /* SwiftLintXcode.xcscheme */; };
|
||||
04E4BF361CB25D3200BC7305 /* SwiftLintXcode.swift in Sources */ = {isa = PBXBuildFile; fileRef = 04E4BF351CB25D3200BC7305 /* SwiftLintXcode.swift */; };
|
||||
04E4BF381CB25D3200BC7305 /* NSObject_Extension.swift in Sources */ = {isa = PBXBuildFile; fileRef = 04E4BF371CB25D3200BC7305 /* NSObject_Extension.swift */; };
|
||||
|
|
@ -20,6 +22,9 @@
|
|||
0498717D1CB27F8900C5F7B5 /* SwiftLintXcodeTRVSXcode.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SwiftLintXcodeTRVSXcode.h; sourceTree = "<group>"; };
|
||||
0498717E1CB27F8900C5F7B5 /* SwiftLintXcodeTRVSXcode.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = SwiftLintXcodeTRVSXcode.m; sourceTree = "<group>"; };
|
||||
049871801CB28EBF00C5F7B5 /* Formatter.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = Formatter.swift; sourceTree = "<group>"; };
|
||||
04DFAD451CB508D1007998DF /* SwiftLintXcodeIDEHelper.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SwiftLintXcodeIDEHelper.h; sourceTree = "<group>"; };
|
||||
04DFAD461CB508D1007998DF /* SwiftLintXcodeIDEHelper.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = SwiftLintXcodeIDEHelper.m; sourceTree = "<group>"; };
|
||||
04DFAD481CB50BC8007998DF /* errorHelper.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = errorHelper.swift; sourceTree = "<group>"; };
|
||||
04E4BF2F1CB25D3100BC7305 /* SwiftLintXcode.xcplugin */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = SwiftLintXcode.xcplugin; sourceTree = BUILT_PRODUCTS_DIR; };
|
||||
04E4BF331CB25D3200BC7305 /* SwiftLintXcode.xcscheme */ = {isa = PBXFileReference; lastKnownFileType = text.xml; name = SwiftLintXcode.xcscheme; path = SwiftLintXcode.xcodeproj/xcshareddata/xcschemes/SwiftLintXcode.xcscheme; sourceTree = SOURCE_ROOT; };
|
||||
04E4BF351CB25D3200BC7305 /* SwiftLintXcode.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SwiftLintXcode.swift; sourceTree = "<group>"; };
|
||||
|
|
@ -50,10 +55,13 @@
|
|||
children = (
|
||||
0498717D1CB27F8900C5F7B5 /* SwiftLintXcodeTRVSXcode.h */,
|
||||
0498717E1CB27F8900C5F7B5 /* SwiftLintXcodeTRVSXcode.m */,
|
||||
04DFAD451CB508D1007998DF /* SwiftLintXcodeIDEHelper.h */,
|
||||
04DFAD461CB508D1007998DF /* SwiftLintXcodeIDEHelper.m */,
|
||||
04E4BF351CB25D3200BC7305 /* SwiftLintXcode.swift */,
|
||||
04E4BF371CB25D3200BC7305 /* NSObject_Extension.swift */,
|
||||
04E4BF401CB273A700BC7305 /* SaveHook.swift */,
|
||||
049871801CB28EBF00C5F7B5 /* Formatter.swift */,
|
||||
04DFAD481CB50BC8007998DF /* errorHelper.swift */,
|
||||
04E4BF391CB25D3200BC7305 /* Info.plist */,
|
||||
04E4BF321CB25D3200BC7305 /* Supporting Files */,
|
||||
0498717C1CB27F8800C5F7B5 /* SwiftLintXcode-Bridging-Header.h */,
|
||||
|
|
@ -95,11 +103,12 @@
|
|||
isa = PBXProject;
|
||||
attributes = {
|
||||
LastSwiftUpdateCheck = 0730;
|
||||
LastUpgradeCheck = 0730;
|
||||
LastUpgradeCheck = 0800;
|
||||
ORGANIZATIONNAME = "Yuya Tanaka";
|
||||
TargetAttributes = {
|
||||
04E4BF2E1CB25D3100BC7305 = {
|
||||
CreatedOnToolsVersion = 7.3;
|
||||
LastSwiftMigration = 0800;
|
||||
};
|
||||
};
|
||||
};
|
||||
|
|
@ -139,6 +148,8 @@
|
|||
0498717F1CB27F8900C5F7B5 /* SwiftLintXcodeTRVSXcode.m in Sources */,
|
||||
04E4BF361CB25D3200BC7305 /* SwiftLintXcode.swift in Sources */,
|
||||
049871811CB28EBF00C5F7B5 /* Formatter.swift in Sources */,
|
||||
04DFAD471CB508D1007998DF /* SwiftLintXcodeIDEHelper.m in Sources */,
|
||||
04DFAD491CB50BC8007998DF /* errorHelper.swift in Sources */,
|
||||
04E4BF411CB273A700BC7305 /* SaveHook.swift in Sources */,
|
||||
04E4BF381CB25D3200BC7305 /* NSObject_Extension.swift in Sources */,
|
||||
);
|
||||
|
|
@ -161,8 +172,10 @@
|
|||
CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
|
||||
CLANG_WARN_EMPTY_BODY = YES;
|
||||
CLANG_WARN_ENUM_CONVERSION = YES;
|
||||
CLANG_WARN_INFINITE_RECURSION = YES;
|
||||
CLANG_WARN_INT_CONVERSION = YES;
|
||||
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
|
||||
CLANG_WARN_SUSPICIOUS_MOVE = YES;
|
||||
CLANG_WARN_UNREACHABLE_CODE = YES;
|
||||
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
|
||||
COPY_PHASE_STRIP = NO;
|
||||
|
|
@ -202,8 +215,10 @@
|
|||
CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
|
||||
CLANG_WARN_EMPTY_BODY = YES;
|
||||
CLANG_WARN_ENUM_CONVERSION = YES;
|
||||
CLANG_WARN_INFINITE_RECURSION = YES;
|
||||
CLANG_WARN_INT_CONVERSION = YES;
|
||||
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
|
||||
CLANG_WARN_SUSPICIOUS_MOVE = YES;
|
||||
CLANG_WARN_UNREACHABLE_CODE = YES;
|
||||
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
|
||||
COPY_PHASE_STRIP = NO;
|
||||
|
|
@ -219,17 +234,18 @@
|
|||
GCC_WARN_UNUSED_FUNCTION = YES;
|
||||
GCC_WARN_UNUSED_VARIABLE = YES;
|
||||
MTL_ENABLE_DEBUG_INFO = NO;
|
||||
SWIFT_OPTIMIZATION_LEVEL = "-Owholemodule";
|
||||
};
|
||||
name = Release;
|
||||
};
|
||||
04E4BF3D1CB25D3200BC7305 /* Debug */ = {
|
||||
isa = XCBuildConfiguration;
|
||||
buildSettings = {
|
||||
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES;
|
||||
CLANG_ENABLE_MODULES = YES;
|
||||
COMBINE_HIDPI_IMAGES = YES;
|
||||
DEPLOYMENT_LOCATION = YES;
|
||||
DSTROOT = "$(HOME)";
|
||||
EMBEDDED_CONTENT_CONTAINS_SWIFT = YES;
|
||||
INFOPLIST_FILE = SwiftLintXcode/Info.plist;
|
||||
INSTALL_PATH = "/Library/Application Support/Developer/Shared/Xcode/Plug-ins";
|
||||
LD_RUNPATH_SEARCH_PATHS = "$(DT_TOOLCHAIN_DIR)/usr/lib/swift/macosx";
|
||||
|
|
@ -238,6 +254,7 @@
|
|||
PRODUCT_NAME = SwiftLintXcode;
|
||||
SWIFT_OBJC_BRIDGING_HEADER = "SwiftLintXcode/SwiftLintXcode-Bridging-Header.h";
|
||||
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
|
||||
SWIFT_VERSION = 3.0;
|
||||
WRAPPER_EXTENSION = xcplugin;
|
||||
};
|
||||
name = Debug;
|
||||
|
|
@ -245,11 +262,11 @@
|
|||
04E4BF3E1CB25D3200BC7305 /* Release */ = {
|
||||
isa = XCBuildConfiguration;
|
||||
buildSettings = {
|
||||
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES;
|
||||
CLANG_ENABLE_MODULES = YES;
|
||||
COMBINE_HIDPI_IMAGES = YES;
|
||||
DEPLOYMENT_LOCATION = YES;
|
||||
DSTROOT = "$(HOME)";
|
||||
EMBEDDED_CONTENT_CONTAINS_SWIFT = YES;
|
||||
INFOPLIST_FILE = SwiftLintXcode/Info.plist;
|
||||
INSTALL_PATH = "/Library/Application Support/Developer/Shared/Xcode/Plug-ins";
|
||||
LD_RUNPATH_SEARCH_PATHS = "$(DT_TOOLCHAIN_DIR)/usr/lib/swift/macosx";
|
||||
|
|
@ -257,6 +274,7 @@
|
|||
PRODUCT_BUNDLE_IDENTIFIER = net.ypresto.SwiftLintXcode;
|
||||
PRODUCT_NAME = SwiftLintXcode;
|
||||
SWIFT_OBJC_BRIDGING_HEADER = "SwiftLintXcode/SwiftLintXcode-Bridging-Header.h";
|
||||
SWIFT_VERSION = 3.0;
|
||||
WRAPPER_EXTENSION = xcplugin;
|
||||
};
|
||||
name = Release;
|
||||
|
|
|
|||
|
|
@ -1,6 +1,6 @@
|
|||
<?xml version="1.0" encoding="UTF-8"?>
|
||||
<Scheme
|
||||
LastUpgradeVersion = "0500"
|
||||
LastUpgradeVersion = "0800"
|
||||
version = "2.0">
|
||||
<BuildAction
|
||||
parallelizeBuildables = "NO"
|
||||
|
|
|
|||
|
|
@ -11,36 +11,32 @@ import Cocoa
|
|||
|
||||
final class Formatter {
|
||||
static var sharedInstance = Formatter()
|
||||
|
||||
private static let pathExtension = "SwiftLintXcode"
|
||||
private let fileManager = FileManager.default
|
||||
|
||||
let fileManager = NSFileManager.defaultManager()
|
||||
let tempDirURL: NSURL = NSURL(fileURLWithPath: NSTemporaryDirectory()).URLByAppendingPathComponent("SwiftLintXcode-\(NSUUID().UUIDString)")
|
||||
|
||||
struct CursorPosition {
|
||||
private struct CursorPosition {
|
||||
let line: Int
|
||||
let column: Int
|
||||
}
|
||||
|
||||
|
||||
class func isFormattableDocument(document: NSDocument) -> Bool {
|
||||
return (document.fileURL?.pathExtension?.lowercaseString == "swift") ?? false
|
||||
class func isFormattableDocument(_ document: NSDocument) -> Bool {
|
||||
return document.fileURL?.pathExtension.lowercased() == "swift"
|
||||
}
|
||||
|
||||
func tryFormatDocument(document: IDESourceCodeDocument) -> Bool {
|
||||
func tryFormatDocument(_ document: IDESourceCodeDocument) -> Bool {
|
||||
do {
|
||||
try formatDocument(document)
|
||||
return true
|
||||
} catch let error as NSError {
|
||||
NSAlert(error: error).runModal()
|
||||
} catch {
|
||||
NSAlert(error: NSError(domain: "net.ypresto.SwiftLintXcode", code: 0, userInfo: [
|
||||
NSLocalizedDescriptionKey: "Unknown error occured: \(error)"
|
||||
])).runModal()
|
||||
NSAlert(error: errorWithMessage("Unknown error occured: \(error)")).runModal()
|
||||
}
|
||||
return false
|
||||
}
|
||||
|
||||
func formatDocument(document: IDESourceCodeDocument) throws {
|
||||
func formatDocument(_ document: IDESourceCodeDocument) throws {
|
||||
let textStorage: DVTSourceTextStorage = document.textStorage()
|
||||
let originalString = textStorage.string
|
||||
let formattedString = try formatString(originalString)
|
||||
|
|
@ -50,96 +46,88 @@ final class Formatter {
|
|||
let cursorPosition = cursorPositionForSelectedRange(selectedRange, textStorage: textStorage)
|
||||
|
||||
textStorage.beginEditing()
|
||||
textStorage.replaceCharactersInRange(NSRange(location: 0, length: textStorage.length), withString: formattedString, withUndoManager: document.undoManager())
|
||||
textStorage.replaceCharacters(in: NSRange(location: 0, length: textStorage.length), with: formattedString, withUndoManager: document.undoManager())
|
||||
textStorage.endEditing()
|
||||
|
||||
let newLocation = locationForCursorPosition(cursorPosition, textStorage: textStorage)
|
||||
SwiftLintXcodeTRVSXcode.textView().setSelectedRange(NSRange(location: newLocation, length: 0))
|
||||
}
|
||||
|
||||
private func cursorPositionForSelectedRange(selectedRange: NSRange, textStorage: DVTSourceTextStorage) -> CursorPosition {
|
||||
let line = textStorage.lineRangeForCharacterRange(selectedRange).location
|
||||
private func cursorPositionForSelectedRange(_ selectedRange: NSRange, textStorage: DVTSourceTextStorage) -> CursorPosition {
|
||||
let line = textStorage.lineRange(forCharacterRange: selectedRange).location
|
||||
let column = selectedRange.location - startLocationOfLine(line, textStorage: textStorage)
|
||||
return CursorPosition(line: line, column: column)
|
||||
}
|
||||
|
||||
private func locationForCursorPosition(cursorPosition: CursorPosition, textStorage: DVTSourceTextStorage) -> Int {
|
||||
private func locationForCursorPosition(_ cursorPosition: CursorPosition, textStorage: DVTSourceTextStorage) -> Int {
|
||||
let startOfLine = startLocationOfLine(cursorPosition.line, textStorage: textStorage)
|
||||
let locationOfNextLine = textStorage.characterRangeForLineRange(NSRange(location: cursorPosition.line + 1, length: 0)).location
|
||||
let locationOfNextLine = textStorage.characterRange(forLineRange: NSRange(location: cursorPosition.line + 1, length: 0)).location
|
||||
// XXX: Can reach EOF..? Cursor position may be trimmed one charactor when cursor is on EOF.
|
||||
return min(startOfLine + cursorPosition.column, locationOfNextLine - 1)
|
||||
}
|
||||
|
||||
private func startLocationOfLine(line: Int, textStorage: DVTSourceTextStorage) -> Int {
|
||||
return textStorage.characterRangeForLineRange(NSRange(location: line, length: 0)).location
|
||||
private func startLocationOfLine(_ line: Int, textStorage: DVTSourceTextStorage) -> Int {
|
||||
return textStorage.characterRange(forLineRange: NSRange(location: line, length: 0)).location
|
||||
}
|
||||
|
||||
private func formatString(string: String) throws -> String {
|
||||
private func formatString(_ string: String) throws -> String {
|
||||
guard let workspaceRootDirectory = SwiftLintXcodeIDEHelper.currentWorkspaceURL()?.deletingLastPathComponent().path else {
|
||||
throw errorWithMessage("Cannot determine project directory.")
|
||||
}
|
||||
|
||||
return try withTempporaryFile { (filePath) in
|
||||
try string.writeToFile(filePath, atomically: false, encoding: NSUTF8StringEncoding)
|
||||
let swiftlintPath = try self.getExecutableOnPath("swiftlint")
|
||||
let task = NSTask.launchedTaskWithLaunchPath(swiftlintPath, arguments: [
|
||||
"autocorrect", "--path", filePath
|
||||
])
|
||||
try string.write(toFile: filePath, atomically: false, encoding: String.Encoding.utf8)
|
||||
let swiftlintPath = try self.getExecutableOnPath(name: "swiftlint", workingDirectory: workspaceRootDirectory)
|
||||
let task = Process()
|
||||
task.launchPath = swiftlintPath
|
||||
task.arguments = ["autocorrect", "--path", filePath]
|
||||
task.currentDirectoryPath = workspaceRootDirectory
|
||||
task.launch()
|
||||
task.waitUntilExit()
|
||||
if task.terminationStatus != 0 {
|
||||
throw NSError(domain: "net.ypresto.SwiftLintXcode", code: 0, userInfo: [
|
||||
NSLocalizedDescriptionKey: "Executing swiftlint exited with non-zero status."
|
||||
])
|
||||
throw errorWithMessage("Executing swiftlint exited with non-zero status.")
|
||||
}
|
||||
return try String(contentsOfFile: filePath, encoding: NSUTF8StringEncoding)
|
||||
return try String(contentsOfFile: filePath, encoding: String.Encoding.utf8)
|
||||
}
|
||||
}
|
||||
|
||||
private func getExecutableOnPath(name: String) throws -> String {
|
||||
let pipe = NSPipe()
|
||||
let task = NSTask()
|
||||
private func getExecutableOnPath(name: String, workingDirectory: String) throws -> String {
|
||||
let pipe = Pipe()
|
||||
let task = Process()
|
||||
task.launchPath = "/bin/bash"
|
||||
task.arguments = [
|
||||
"-l", "-c", "which \(name)"
|
||||
]
|
||||
task.currentDirectoryPath = workingDirectory
|
||||
task.standardOutput = pipe
|
||||
task.launch()
|
||||
task.waitUntilExit()
|
||||
if task.terminationStatus != 0 {
|
||||
throw NSError(domain: "net.ypresto.SwiftLintXcode", code: 0, userInfo: [
|
||||
NSLocalizedDescriptionKey: "Executing `which swiftlint` exited with non-zero status."
|
||||
])
|
||||
throw errorWithMessage("Executing `which swiftlint` exited with non-zero status.")
|
||||
}
|
||||
|
||||
let data = pipe.fileHandleForReading.readDataToEndOfFile()
|
||||
guard let pathString = String(data: data, encoding: NSUTF8StringEncoding) else {
|
||||
throw NSError(domain: "net.ypresto.SwiftLintXcode", code: 0, userInfo: [
|
||||
NSLocalizedDescriptionKey: "Cannot read result of `which swiftlint`."
|
||||
])
|
||||
guard let pathString = String(data: data, encoding: String.Encoding.utf8) else {
|
||||
throw errorWithMessage("Cannot read result of `which swiftlint`.")
|
||||
}
|
||||
let path = pathString.stringByTrimmingCharactersInSet(NSCharacterSet.newlineCharacterSet())
|
||||
if !fileManager.isExecutableFileAtPath(path) {
|
||||
throw NSError(domain: "net.ypresto.SwiftLintXcode", code: 0, userInfo: [
|
||||
NSLocalizedDescriptionKey: "swiftlint at \(path) is not executable."
|
||||
])
|
||||
let path = pathString.trimmingCharacters(in: CharacterSet.newlines)
|
||||
if !fileManager.isExecutableFile(atPath: path) {
|
||||
throw errorWithMessage("swiftlint at \(path) is not executable.")
|
||||
}
|
||||
return path
|
||||
}
|
||||
|
||||
private func withTempporaryFile<T>(@noescape callback: (filePath: String) throws -> T) throws -> T {
|
||||
try ensureTemporaryDirectory()
|
||||
private func withTempporaryFile<T>(_ callback: (_ filePath: String) throws -> T) throws -> T {
|
||||
let filePath = createTemporaryPath()
|
||||
if fileManager.fileExistsAtPath(filePath) {
|
||||
throw NSError(domain: "net.ypresto.SwiftLintXcode", code: 0, userInfo: [
|
||||
NSLocalizedDescriptionKey: "Cannot write to \(filePath), file already exists."
|
||||
])
|
||||
if fileManager.fileExists(atPath: filePath) {
|
||||
throw errorWithMessage("Cannot write to \(filePath), file already exists.")
|
||||
}
|
||||
defer { _ = try? fileManager.removeItemAtPath(filePath) }
|
||||
return try callback(filePath: filePath)
|
||||
defer { _ = try? fileManager.removeItem(atPath: filePath) }
|
||||
return try callback(filePath)
|
||||
}
|
||||
|
||||
private func createTemporaryPath() -> String {
|
||||
return tempDirURL.URLByAppendingPathComponent(NSUUID().UUIDString).path! + ".swift"
|
||||
}
|
||||
|
||||
private func ensureTemporaryDirectory() throws {
|
||||
if fileManager.fileExistsAtPath(tempDirURL.path!) { return }
|
||||
try fileManager.createDirectoryAtURL(tempDirURL, withIntermediateDirectories: true, attributes: nil)
|
||||
return URL(fileURLWithPath: NSTemporaryDirectory(), isDirectory: true)
|
||||
.appendingPathComponent("SwiftLintXcode_\(UUID().uuidString).swift").path
|
||||
}
|
||||
}
|
||||
|
|
|
|||
|
|
@ -38,6 +38,11 @@
|
|||
<string>0420B86A-AA43-4792-9ED0-6FE0F2B16A13</string>
|
||||
<string>7265231C-39B4-402C-89E1-16167C4CC990</string>
|
||||
<string>ACA8656B-FEA8-4B6D-8E4A-93F4C95C362C</string>
|
||||
<string>8A66E736-A720-4B3C-92F1-33D9962C69DF</string>
|
||||
<string>65C57D32-1E9B-44B8-8C04-A27BA7AAE2C4</string>
|
||||
<string>DA4FDFD8-C509-4D8B-8B55-84A7B66AE701</string>
|
||||
<string>E0A62D1F-3C18-4D74-BFE5-A4167D643966</string>
|
||||
<string>DFFB3951-EB0A-4C09-9DAC-5F2D28CC839C</string>
|
||||
</array>
|
||||
<key>LSMinimumSystemVersion</key>
|
||||
<string>$(MACOSX_DEPLOYMENT_TARGET)</string>
|
||||
|
|
|
|||
|
|
@ -8,8 +8,8 @@
|
|||
import Foundation
|
||||
|
||||
extension NSObject {
|
||||
class func pluginDidLoad(bundle: NSBundle) {
|
||||
let appName = NSBundle.mainBundle().infoDictionary?["CFBundleName"] as? NSString
|
||||
class func pluginDidLoad(_ bundle: Bundle) {
|
||||
let appName = Bundle.main.infoDictionary?["CFBundleName"] as? NSString
|
||||
if appName == "Xcode" {
|
||||
if sharedPlugin == nil {
|
||||
sharedPlugin = SwiftLintXcode(bundle: bundle)
|
||||
|
|
|
|||
|
|
@ -24,14 +24,14 @@ final class SaveHook {
|
|||
if swizzled { return }
|
||||
swizzled = true
|
||||
|
||||
let fromMethod = class_getInstanceMethod(NSDocument.self, #selector(NSDocument.saveDocumentWithDelegate(_:didSaveSelector:contextInfo:)))
|
||||
let toMethod = class_getInstanceMethod(NSDocument.self, #selector(NSDocument.SwiftLintXcodeSaveDocumentWithDelegate(_:didSaveSelector:contextInfo:)))
|
||||
let fromMethod = class_getInstanceMethod(NSDocument.self, #selector(NSDocument.save(withDelegate:didSave:contextInfo:)))
|
||||
let toMethod = class_getInstanceMethod(NSDocument.self, #selector(NSDocument.swiftLintXcodeSaveDocument(delegate:didSaveSelector:contextInfo:)))
|
||||
method_exchangeImplementations(fromMethod, toMethod)
|
||||
}
|
||||
|
||||
class func tryOnSaveDocument(document: NSDocument) -> Bool {
|
||||
class func tryOnSaveDocument(_ document: NSDocument) -> Bool {
|
||||
if !enabled { return true }
|
||||
Formatter.isFormattableDocument(document)
|
||||
if !Formatter.isFormattableDocument(document) { return true }
|
||||
let sourceCodeDocument: IDESourceCodeDocument = SwiftLintXcodeTRVSXcode.sourceCodeDocument()
|
||||
guard sourceCodeDocument == document else { return true }
|
||||
return Formatter.sharedInstance.tryFormatDocument(sourceCodeDocument)
|
||||
|
|
@ -41,10 +41,10 @@ final class SaveHook {
|
|||
// https://github.com/travisjeffery/ClangFormat-Xcode/blob/a22114907592fb5d5b1043a4919d7be3e1496741/ClangFormat/NSDocument+TRVSClangFormat.m
|
||||
extension NSDocument {
|
||||
|
||||
dynamic func SwiftLintXcodeSaveDocumentWithDelegate(delegate: AnyObject?, didSaveSelector: Selector, contextInfo: UnsafeMutablePointer<Void>) -> Void {
|
||||
dynamic func swiftLintXcodeSaveDocument(delegate: AnyObject?, didSaveSelector: Selector, contextInfo: UnsafeMutableRawPointer) -> Void {
|
||||
if SaveHook.tryOnSaveDocument(self) {
|
||||
// NOTE: Call original method
|
||||
SwiftLintXcodeSaveDocumentWithDelegate(delegate, didSaveSelector: didSaveSelector, contextInfo: contextInfo);
|
||||
swiftLintXcodeSaveDocument(delegate: delegate, didSaveSelector: didSaveSelector, contextInfo: contextInfo)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
|
@ -3,3 +3,4 @@
|
|||
//
|
||||
|
||||
#import "SwiftLintXcodeTRVSXcode.h"
|
||||
#import "SwiftLintXcodeIDEHelper.h"
|
||||
|
|
|
|||
|
|
@ -11,17 +11,17 @@ var sharedPlugin: SwiftLintXcode?
|
|||
|
||||
class SwiftLintXcode: NSObject {
|
||||
|
||||
var bundle: NSBundle
|
||||
lazy var center = NSNotificationCenter.defaultCenter()
|
||||
var bundle: Bundle
|
||||
lazy var center = NotificationCenter.default
|
||||
|
||||
var enableMenuItem: NSMenuItem!
|
||||
var disableMenuItem: NSMenuItem!
|
||||
|
||||
init(bundle: NSBundle) {
|
||||
init(bundle: Bundle) {
|
||||
self.bundle = bundle
|
||||
|
||||
super.init()
|
||||
center.addObserver(self, selector: #selector(SwiftLintXcode.onApplicationDidFinishLaunching), name: NSApplicationDidFinishLaunchingNotification, object: nil)
|
||||
center.addObserver(self, selector: #selector(SwiftLintXcode.onApplicationDidFinishLaunching), name: NSNotification.Name.NSApplicationDidFinishLaunching, object: nil)
|
||||
}
|
||||
|
||||
deinit {
|
||||
|
|
@ -40,7 +40,7 @@ class SwiftLintXcode: NSObject {
|
|||
private func createMenuItems() {
|
||||
removeObserver()
|
||||
|
||||
guard let item = NSApp.mainMenu!.itemWithTitle("Edit") else { return }
|
||||
guard let item = NSApp.mainMenu!.item(withTitle: "Edit") else { return }
|
||||
|
||||
let pluginMenu = NSMenu(title:"SwiftLintXcode")
|
||||
let pluginMenuItem = NSMenuItem(title:"SwiftLintXcode", action: nil, keyEquivalent: "")
|
||||
|
|
@ -60,7 +60,7 @@ class SwiftLintXcode: NSObject {
|
|||
pluginMenu.addItem(disableMenuItem)
|
||||
self.disableMenuItem = disableMenuItem
|
||||
|
||||
item.submenu!.addItem(NSMenuItem.separatorItem())
|
||||
item.submenu!.addItem(NSMenuItem.separator())
|
||||
item.submenu!.addItem(pluginMenuItem)
|
||||
|
||||
updateMenuVisibility()
|
||||
|
|
@ -83,7 +83,7 @@ class SwiftLintXcode: NSObject {
|
|||
}
|
||||
|
||||
func updateMenuVisibility() {
|
||||
self.enableMenuItem.hidden = SaveHook.enabled
|
||||
self.disableMenuItem.hidden = !SaveHook.enabled
|
||||
self.enableMenuItem.isHidden = SaveHook.enabled
|
||||
self.disableMenuItem.isHidden = !SaveHook.enabled
|
||||
}
|
||||
}
|
||||
|
|
|
|||
15
SwiftLintXcode/SwiftLintXcodeIDEHelper.h
Normal file
15
SwiftLintXcode/SwiftLintXcodeIDEHelper.h
Normal file
|
|
@ -0,0 +1,15 @@
|
|||
//
|
||||
// SwiftLintXcodeIDEHelper.h
|
||||
// SwiftLintXcode
|
||||
//
|
||||
// Created by yuya.tanaka on 2016/04/06.
|
||||
// Copyright © 2016年 Yuya Tanaka. All rights reserved.
|
||||
//
|
||||
|
||||
#import <Foundation/Foundation.h>
|
||||
|
||||
@interface SwiftLintXcodeIDEHelper : NSObject
|
||||
|
||||
+ (nullable NSURL *)currentWorkspaceURL;
|
||||
|
||||
@end
|
||||
22
SwiftLintXcode/SwiftLintXcodeIDEHelper.m
Normal file
22
SwiftLintXcode/SwiftLintXcodeIDEHelper.m
Normal file
|
|
@ -0,0 +1,22 @@
|
|||
//
|
||||
// SwiftLintXcodeIDEHelper.m
|
||||
// SwiftLintXcode
|
||||
//
|
||||
// Created by yuya.tanaka on 2016/04/06.
|
||||
// Copyright © 2016年 Yuya Tanaka. All rights reserved.
|
||||
//
|
||||
|
||||
#import "SwiftLintXcodeIDEHelper.h"
|
||||
#import "SwiftLintXcodeTRVSXcode.h"
|
||||
@import Cocoa;
|
||||
|
||||
@implementation SwiftLintXcodeIDEHelper
|
||||
|
||||
+ (nullable NSURL *)currentWorkspaceURL
|
||||
{
|
||||
IDEWorkspaceWindowController *workspaceWindowController = (IDEWorkspaceWindowController *)[[NSApp keyWindow] windowController];
|
||||
IDEWorkspace *workspace = [workspaceWindowController valueForKey:@"_workspace"];
|
||||
return workspace.representingFilePath.fileURL;
|
||||
}
|
||||
|
||||
@end
|
||||
15
SwiftLintXcode/errorHelper.swift
Normal file
15
SwiftLintXcode/errorHelper.swift
Normal file
|
|
@ -0,0 +1,15 @@
|
|||
//
|
||||
// errorHelper.swift
|
||||
// SwiftLintXcode
|
||||
//
|
||||
// Created by yuya.tanaka on 2016/04/06.
|
||||
// Copyright © 2016年 Yuya Tanaka. All rights reserved.
|
||||
//
|
||||
|
||||
import Foundation
|
||||
|
||||
func errorWithMessage(_ message: String) -> NSError {
|
||||
return NSError(domain: "net.ypresto.SwiftLintXcode", code: 0, userInfo: [
|
||||
NSLocalizedDescriptionKey: message
|
||||
])
|
||||
}
|
||||
Loading…
Reference in a new issue