diff --git a/lib/grape_logging/loggers/filter_parameters.rb b/lib/grape_logging/loggers/filter_parameters.rb index c7942e1..83d612d 100644 --- a/lib/grape_logging/loggers/filter_parameters.rb +++ b/lib/grape_logging/loggers/filter_parameters.rb @@ -12,13 +12,12 @@ module GrapeLogging private def replace_parameters(parameters) - parameters.tap do |parameters| - @filter_parameters.each do |parameter_name| - if parameters.key?(parameter_name.to_s) - parameters[parameter_name.to_s] = @replacement - end + @filter_parameters.each do |parameter_name| + if parameters.key?(parameter_name.to_s) + parameters[parameter_name.to_s] = @replacement end end + parameters end end end diff --git a/lib/grape_logging/middleware/request_logger.rb b/lib/grape_logging/middleware/request_logger.rb index 41cecc9..f6cd65a 100644 --- a/lib/grape_logging/middleware/request_logger.rb +++ b/lib/grape_logging/middleware/request_logger.rb @@ -29,12 +29,8 @@ module GrapeLogging def after stop_time - - params = collect_parameters - @reporter.perform(params) - + @reporter.perform(collect_parameters) invoke_included_loggers(:after) - nil end diff --git a/lib/grape_logging/reporters/logger_reporter.rb b/lib/grape_logging/reporters/logger_reporter.rb index b0631a6..c5620d4 100644 --- a/lib/grape_logging/reporters/logger_reporter.rb +++ b/lib/grape_logging/reporters/logger_reporter.rb @@ -2,7 +2,7 @@ module Reporters class LoggerReporter def initialize(logger, formatter) @logger = logger || Logger.new(STDOUT) - @logger.formatter = formatter || GrapeLogging::Formatters::Default.new + @logger.formatter = formatter || GrapeLogging::Formatters::Default.new if @logger.respond_to?(:formatter=) end def perform(params)