From fe2d196494a261cfaa55259ea9be6d3611b0421e Mon Sep 17 00:00:00 2001 From: Pieter Oliver Date: Thu, 26 Jun 2025 14:20:13 +0100 Subject: [PATCH] Fix some small, non breaking changes typoes --- lib/grape_logging/loggers/response.rb | 2 +- lib/grape_logging/middleware/request_logger.rb | 4 ++-- spec/lib/grape_logging/loggers/request_headers_spec.rb | 4 ++-- spec/lib/grape_logging/middleware/request_logger_spec.rb | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/grape_logging/loggers/response.rb b/lib/grape_logging/loggers/response.rb index d464b8d..8b76d12 100644 --- a/lib/grape_logging/loggers/response.rb +++ b/lib/grape_logging/loggers/response.rb @@ -9,7 +9,7 @@ module GrapeLogging # In some cases, response.body is not parseable by JSON. # For example, if you POST on a PUT endpoint, response.body is egal to """". - # It's strange but it's the Grape behavior... + # It's strange, but it's the Grape behavior... def serialized_response_body(response) if response.respond_to?(:body) diff --git a/lib/grape_logging/middleware/request_logger.rb b/lib/grape_logging/middleware/request_logger.rb index 50116a7..5992719 100644 --- a/lib/grape_logging/middleware/request_logger.rb +++ b/lib/grape_logging/middleware/request_logger.rb @@ -37,7 +37,7 @@ module GrapeLogging @response_status = status @response_body = response - # Perform repotters + # Perform reporters @reporter.perform(collect_parameters) # Invoke loggers @@ -69,7 +69,7 @@ module GrapeLogging end # Get status & response from app_response - # when no error occures. + # when no error occurs. if error # Call with error & response after(error[:status], error[:message]) diff --git a/spec/lib/grape_logging/loggers/request_headers_spec.rb b/spec/lib/grape_logging/loggers/request_headers_spec.rb index 9c4dd26..03dd5ca 100644 --- a/spec/lib/grape_logging/loggers/request_headers_spec.rb +++ b/spec/lib/grape_logging/loggers/request_headers_spec.rb @@ -6,7 +6,7 @@ describe GrapeLogging::Loggers::RequestHeaders do OpenStruct.new(env: {HTTP_REFERER: 'http://example.com', HTTP_ACCEPT: 'text/plain'}) end - let(:mock_request_with_unhandle_headers) do + let(:mock_request_with_unhandled_headers) do OpenStruct.new(env: { HTTP_REFERER: 'http://example.com', "PATH_INFO"=>"/api/v1/users" @@ -27,7 +27,7 @@ describe GrapeLogging::Loggers::RequestHeaders do end it 'only handle things which start with HTTP_' do - expect(subject.parameters(mock_request_with_unhandle_headers, nil)).to eq({ + expect(subject.parameters(mock_request_with_unhandled_headers, nil)).to eq({ headers: {'Referer' => 'http://example.com' } }) end diff --git a/spec/lib/grape_logging/middleware/request_logger_spec.rb b/spec/lib/grape_logging/middleware/request_logger_spec.rb index fc38107..d2b78b6 100644 --- a/spec/lib/grape_logging/middleware/request_logger_spec.rb +++ b/spec/lib/grape_logging/middleware/request_logger_spec.rb @@ -27,7 +27,7 @@ describe GrapeLogging::Middleware::RequestLogger do end [301, 404, 500].each do |the_status| - context "when the respnse status is #{the_status}" do + context "when the response status is #{the_status}" do let(:status) { the_status } it 'should log the correct status code' do expect(logger).to receive('info') do |arguments|