From ef946bf7fefb976a056181679b30c4b3d89f33df Mon Sep 17 00:00:00 2001 From: jules Date: Mon, 29 Feb 2016 16:20:40 +0100 Subject: [PATCH] Since the Grape v0.14.1, the after callback is always called, so response could be nil if the called fail with an exception --- lib/grape_logging/loggers/response.rb | 10 +++++++--- lib/grape_logging/middleware/request_logger.rb | 2 +- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/lib/grape_logging/loggers/response.rb b/lib/grape_logging/loggers/response.rb index 650d98c..bc671c3 100644 --- a/lib/grape_logging/loggers/response.rb +++ b/lib/grape_logging/loggers/response.rb @@ -2,9 +2,13 @@ module GrapeLogging module Loggers class Response < GrapeLogging::Loggers::Base def parameters(request, response) - { - response: serialized_response_body(response) - } + if response + { + response: serialized_response_body(response) + } + else + {} + end end private diff --git a/lib/grape_logging/middleware/request_logger.rb b/lib/grape_logging/middleware/request_logger.rb index d737731..cf89c48 100644 --- a/lib/grape_logging/middleware/request_logger.rb +++ b/lib/grape_logging/middleware/request_logger.rb @@ -51,7 +51,7 @@ module GrapeLogging protected def parameters { - status: response.status, + status: response.try(:status), time: { total: total_runtime, db: db_runtime,