From f8e0658a4d3a593d4d9d40d6eb156f97cb13cbbe Mon Sep 17 00:00:00 2001 From: jules Date: Tue, 8 Mar 2016 12:11:15 +0100 Subject: [PATCH] Small code lisibility simplifications --- lib/grape_logging/loggers/filter_parameters.rb | 9 ++++----- lib/grape_logging/middleware/request_logger.rb | 6 +----- 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/lib/grape_logging/loggers/filter_parameters.rb b/lib/grape_logging/loggers/filter_parameters.rb index c7942e1..83d612d 100644 --- a/lib/grape_logging/loggers/filter_parameters.rb +++ b/lib/grape_logging/loggers/filter_parameters.rb @@ -12,13 +12,12 @@ module GrapeLogging private def replace_parameters(parameters) - parameters.tap do |parameters| - @filter_parameters.each do |parameter_name| - if parameters.key?(parameter_name.to_s) - parameters[parameter_name.to_s] = @replacement - end + @filter_parameters.each do |parameter_name| + if parameters.key?(parameter_name.to_s) + parameters[parameter_name.to_s] = @replacement end end + parameters end end end diff --git a/lib/grape_logging/middleware/request_logger.rb b/lib/grape_logging/middleware/request_logger.rb index 41cecc9..f6cd65a 100644 --- a/lib/grape_logging/middleware/request_logger.rb +++ b/lib/grape_logging/middleware/request_logger.rb @@ -29,12 +29,8 @@ module GrapeLogging def after stop_time - - params = collect_parameters - @reporter.perform(params) - + @reporter.perform(collect_parameters) invoke_included_loggers(:after) - nil end