sjs/http-cookie
1
0
Fork 0
mirror of https://github.com/samsonjs/http-cookie.git synced 2026-04-27 14:57:46 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

HTTP::CookieJar#add: Check if both the domain and path of the cookie are set.

Browse source
This commit is contained in:
Akinori MUSHA 2012-10-22 14:50:49 +09:00
parent 82deac2f19
commit 1731b155e6
2 changed files with 15 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
lib/http/cookie_jar.rb
View file

@ -9,8 +9,6 @@ end
class HTTP::CookieJar class HTTP::CookieJar
include Enumerable include Enumerable
# add_cookie wants something resembling a URI.
attr_reader :jar attr_reader :jar
def initialize def initialize
@ -23,6 +21,9 @@ class HTTP::CookieJar
# Add a +cookie+ to the jar and return self. # Add a +cookie+ to the jar and return self.
def add(cookie) def add(cookie)
if cookie.domain.nil? || cookie.path.nil?
raise ArgumentError, "a cookie with unknown domain or path cannot be added"
end
normal_domain = cookie.domain_name.hostname normal_domain = cookie.domain_name.hostname
((@jar[normal_domain] ||= {})[cookie.path] ||= {})[cookie.name] = cookie ((@jar[normal_domain] ||= {})[cookie.path] ||= {})[cookie.name] = cookie

12
test/test_http_cookie_jar.rb
View file

@ -171,6 +171,18 @@ class TestHTTPCookieJar < Test::Unit::TestCase
assert_equal(1, @jar.cookies(url).length) assert_equal(1, @jar.cookies(url).length)
end end
def test_add_rejects_cookies_with_unknown_domain_or_path
cookie = HTTP::Cookie.new(cookie_values.reject { |k,v| [:origin, :domain].include?(k) })
assert_raises(ArgumentError) {
@jar.add(cookie)
}
cookie = HTTP::Cookie.new(cookie_values.reject { |k,v| [:origin, :path].include?(k) })
assert_raises(ArgumentError) {
@jar.add(cookie)
}
end
def test_add_does_not_reject_cookies_from_a_nested_subdomain def test_add_does_not_reject_cookies_from_a_nested_subdomain
url = URI 'http://y.x.foo.com' url = URI 'http://y.x.foo.com'