sjs/http-cookie
1
0
Fork 0
mirror of https://github.com/samsonjs/http-cookie.git synced 2026-04-27 14:57:46 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #10 from marxarelli/fix/host-only-cookie-domain-comparison

Browse source 
Fix host-only cookies for unqualified hostnames
This commit is contained in:
Akinori MUSHA 2016-12-09 21:48:59 +09:00 committed by GitHub
commit 24b5d407d9
2 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/http/cookie_jar/hash_store.rb
View file

@ -67,10 +67,8 @@ class HTTP::CookieJar
def each(uri = nil) # :yield: cookie def each(uri = nil) # :yield: cookie
now = Time.now now = Time.now
if uri if uri
thost = DomainName.new(uri.host)
tpath = uri.path tpath = uri.path
@jar.each { |domain, paths| @jar.each { |domain, paths|
next unless thost.cookie_domain?(domain)
paths.each { |path, hash| paths.each { |path, hash|
next unless HTTP::Cookie.path_match?(path, tpath) next unless HTTP::Cookie.path_match?(path, tpath)
hash.delete_if { |name, cookie| hash.delete_if { |name, cookie|

11
test/test_http_cookie_jar.rb
View file

@ -139,6 +139,17 @@ module TestHTTPCookieJar
assert_equal(0, @jar.cookies(URI('http://www.rubyforge.org/')).length) assert_equal(0, @jar.cookies(URI('http://www.rubyforge.org/')).length)
end end
def test_host_only_with_unqualified_hostname
@jar.add(HTTP::Cookie.new(cookie_values(
:origin => 'http://localhost/', :domain => 'localhost', :for_domain => false)))
assert_equal(1, @jar.cookies(URI('http://localhost/')).length)
assert_equal(1, @jar.cookies(URI('http://Localhost/')).length)
assert_equal(1, @jar.cookies(URI('https://Localhost/')).length)
end
def test_empty_value def test_empty_value
url = URI 'http://rubyforge.org/' url = URI 'http://rubyforge.org/'
values = cookie_values(:value => "") values = cookie_values(:value => "")