sjs/http-cookie
1
0
Fork 0
mirror of https://github.com/samsonjs/http-cookie.git synced 2026-03-25 08:55:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Update cookie.rb to handle situations when expires is a DateTime object (#52)

Browse source
This commit is contained in:
Mike Dalessio 2024-12-05 17:27:11 -05:00 committed by GitHub
commit e4e66bdf0a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 18 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/http/cookie.rb
View file

@ -89,7 +89,7 @@ class HTTP::Cookie
# The Expires attribute value as a Time object.
#
# The setter method accepts a Time object, a string representation
# The setter method accepts a Time / DateTime object, a string representation
# of date/time that Time.parse can understand, or `nil`.
#
# Setting this value resets #max_age to nil. When #max_age is
@ -493,6 +493,8 @@ class HTTP::Cookie
def expires= t
case t
when nil, Time
when DateTime
t = t.to_time
else
t = Time.parse(t)
end

16
test/test_http_cookie.rb
View file

@ -717,8 +717,22 @@ class TestHTTPCookie < Test::Unit::TestCase
end
def test_expiration
cookie = HTTP::Cookie.new(cookie_values)
expires = Time.now + 86400
cookie = HTTP::Cookie.new(cookie_values(expires: expires))
assert_equal(expires, cookie.expires)
assert_equal false, cookie.expired?
assert_equal true, cookie.expired?(cookie.expires + 1)
assert_equal false, cookie.expired?(cookie.expires - 1)
cookie.expire!
assert_equal true, cookie.expired?
end
def test_expiration_using_datetime
expires = DateTime.now + 1
cookie = HTTP::Cookie.new(cookie_values(expires: expires))
assert_equal(expires.to_time, cookie.expires)
assert_equal false, cookie.expired?
assert_equal true, cookie.expired?(cookie.expires + 1)
assert_equal false, cookie.expired?(cookie.expires - 1)