sjs/http-cookie
1
0
Fork 0
mirror of https://github.com/samsonjs/http-cookie.git synced 2026-03-25 08:55:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
304 commits 1 branch 0 tags 450 KiB
Commit graph

210 commits

Author SHA1 Message Date
Akinori MUSHA
060eb44497 Avoid use of numeric indexing on SQLite3::ResultSet::HashWithTypesAndFields 2022-05-25 15:37:48 +09:00
Akinori MUSHA
2c220f44dd Allow aliases because YAML.dump generates aliases when it sees multiple occurrences of an object 2021-06-07 14:45:58 +09:00
Akinori MUSHA
7a1bf4fbb3 Use safe_load when using Psych >=3.1 2021-06-07 13:41:45 +09:00
Akinori MUSHA
9eb68dcce5 Merge pull request #14 from wrzasa/master 
More informative error message when cannot load a store (rebased on current master)
 2016-12-09 21:52:51 +09:00
Akinori MUSHA
24b5d407d9 Merge pull request #10 from marxarelli/fix/host-only-cookie-domain-comparison 
Fix host-only cookies for unqualified hostnames
 2016-12-09 21:48:59 +09:00
Akinori MUSHA
80e855fdf2 Merge branch 'fix_time_representation' 2016-12-09 21:43:47 +09:00
Akinori MUSHA
56e0fd5175 Add 1.8 compatibility 2016-12-09 21:38:35 +09:00
Akinori MUSHA
9f5a0d65da MozillaStore: creationTime and lastAccessed are in usec, not seconds 
This was pointed out by #8.  I decided not to add extra code for
backwards compatibility of their values.
 2016-12-09 21:12:32 +09:00
Akinori MUSHA
5d7fbde318 Avoid warnings 2016-12-08 23:49:44 +09:00
Akinori MUSHA
40d988ab92 Set the originAttributes column when inserting a record 2016-12-08 23:42:40 +09:00
Akinori MUSHA
930d8242cf Bump VERSION to 1.0.4 2016-11-25 01:54:53 +09:00
Akinori MUSHA
67630ac6be Support Mozilla's cookie storage format up to version 7 2016-11-25 01:52:52 +09:00
Akinori MUSHA
f4a18a76ca Bump VERSION to 1.0.3 2016-09-30 20:01:40 +09:00
Akinori MUSHA
7f94a9e5d9 Treat comma as normal character in HTTP::Cookie.cookie_value_to_hash 
As pointed out in CVE-2016-7401, treating comma in a Cookie header value
as separator may cause security problems.
 2016-09-30 19:20:39 +09:00
wrzasa
f828cf0319 More informative error message when cannot load a store 
I tried to use `mozilla` store, but got the following message, that gave me no clue what's wrong:

          ArgumentError: cookie store unavailable: :mozilla

After some debugging I found that I have no `sqlite3` gem installed. But the error message should tell mi that. 

This change should help.
 2016-03-18 17:24:56 +01:00
Dan Duvall
69154b11dd Fix host-only cookies for unqualified hostnames 
Removed comparison against `DomainName#cookie_domain?` during filtering
of jar cookies. It was redundant considering the later call to
`HTTP::Cookie#valid_for_url?` and prevented valid host-only cookies from
being considered for unqualified hostnames (e.g. "localhost").

RFC 6265 (5.4) does not restrict host-only cookies from being used with
such unqualified names as it does for cookies with the domain attribute
set.
 2015-09-02 12:57:11 -07:00
Akinori MUSHA
d3d4f0dafe Bump VERSION 1.0.2. 2013-09-10 14:52:55 +09:00
Akinori MUSHA
391ada20d0 HTTP::Cookie.parse() should not raise an exception if it finds a bad name or value. 2013-09-10 14:48:29 +09:00
Lee Jarvis
5319f88dc2 fix unused variable warning in LoadError rescue 2013-05-25 10:17:13 +01:00
Akinori MUSHA
b934db8e77 Bump VERSION to 1.0.1 and add CHANGELOG.md. 2013-04-21 21:46:31 +09:00
Akinori MUSHA
40aba54618 Accept a class object where a symbol addressing a class is accepted. 
Convert IndexError to ArgumentError, and ArgumentError to TypeError as
appropriate.
 2013-04-21 20:35:17 +09:00
Akinori MUSHA
17d5a128d7 Fix error messages. 2013-04-21 19:32:57 +09:00
Akinori MUSHA
1dd16745e3 Update a comment. 2013-04-21 19:28:12 +09:00
Akinori MUSHA
3d4f0a65ff Cookie#origin=: Add a comment to explain why @origin is set the last. 2013-04-18 22:23:30 +09:00
Akinori MUSHA
a0202e2192 Cookie#max_age= should not reset #expires when it fails. 2013-04-18 22:22:11 +09:00
Akinori MUSHA
640ea1b297 Omit calling #expires= when #max_age= is going to be called. 2013-04-18 21:42:22 +09:00
Akinori MUSHA
d2eb1289f5 Bump VERSION to 1.0.0. 2013-04-17 10:28:17 +09:00
Akinori MUSHA
892c07024d Add rdoc markups. 2013-04-17 01:14:45 +09:00
Akinori MUSHA
a1cfe6bb70 Remove unused code. 2013-04-17 01:14:22 +09:00
Akinori MUSHA
0d5e666642 Improve rdoc. 2013-04-16 22:37:19 +09:00
Akinori MUSHA
bf9bbe3da8 Move Array#sort_by! to http/cookie/ruby_compat. 2013-04-16 22:15:29 +09:00
Akinori MUSHA
bafb83fc06 Let AbstractStore & AbstractSaver autoloaded and add tests for autoloading. 2013-04-16 16:49:27 +09:00
Akinori MUSHA
04950f6796 Cookie#new: Reject a mixed case symbol as keyword for simplicity. 
This fixes error with Ruby 1.8.
 2013-04-16 16:39:55 +09:00
Akinori MUSHA
a3ab578671 Fix *Store#empty?. 2013-04-16 15:05:00 +09:00
Akinori MUSHA
2bb7485460 Add tests for CookieJar#clone, #cleanup, expiration by #each and #empty?. 2013-04-16 15:05:00 +09:00
Akinori MUSHA
5bdb8f41ae Cookie#new prefers downcased symbols for keywords. 
Test warnings.
 2013-04-16 08:44:48 +09:00
Akinori MUSHA
c293005676 Bump VERSION to 1.0.0.pre12. 2013-04-16 02:44:26 +09:00
Akinori MUSHA
8ae076d9ea Fix the compatibility code to support Syck. 2013-04-16 01:39:09 +09:00
Akinori MUSHA
fcdaddcbe6 Emit a proper message when try_convert() fails. 2013-04-16 01:38:05 +09:00
Akinori MUSHA
b02e800dfa Comment out unused/advisory bits to gain coverage. 2013-04-16 00:54:56 +09:00
Akinori MUSHA
10ddb688df Inhibit cloning MozillaStore. 2013-04-16 00:38:47 +09:00
Akinori MUSHA
d806955f57 Fix hand-made autoloading to allow directly referencing MozillaStore. 2013-04-16 00:37:10 +09:00
Akinori MUSHA
ded02f8327 Make MozillaStore#close actually "work" by closing open statements. 
Add a finalizer to MozillaStore also, which automatically closes the
SQLite3 database.
 2013-04-16 00:04:54 +09:00
Akinori MUSHA
e9230a00c1 Add tests for MozillaStore#upgrade_database and fix its bugs. 2013-04-16 00:03:03 +09:00
Akinori MUSHA
25dd32219f MozillaStore#close: Do not call SQLite3::Database#close if already closed. 2013-04-15 23:57:35 +09:00
Akinori MUSHA
d44218c2e2 Cookie#acceptable? should not raise ArgumentError when it takes no argument. 
Let CookieJar#add convert RuntimeError raised by acceptable? to
ArgumentError.
 2013-04-15 10:29:07 +09:00
Akinori MUSHA
ea45ee3b38 Bump the version to 1.0.0.pre11. 2013-04-15 10:16:28 +09:00
Akinori MUSHA
03627aa42a Fix Hash.try_convert. 2013-04-15 09:33:47 +09:00
Akinori MUSHA
28458101b6 HTTP::Cookie.set_cookie_value: Don't take an origin argument. 2013-04-15 08:54:09 +09:00
Akinori MUSHA
88e3f28591 Directly define String#try_convert and Hash#try_convert in ruby 1.8. 2013-04-14 18:22:30 +09:00