From 15a4a4aaaa2a2a5a89f68848622df7d630286ad8 Mon Sep 17 00:00:00 2001
From: Jason Rasmussen <jrasm91@gmail.com>
Date: Thu, 29 Feb 2024 16:02:08 -0500
Subject: [PATCH] chore: remove unused upload property (#7535)

* chore: remove isExternal

* chore: open-api
---
 mobile/openapi/doc/AssetApi.md                | Bin 57901 -> 57798 bytes
 mobile/openapi/lib/api/asset_api.dart         | Bin 59931 -> 59681 bytes
 mobile/openapi/test/asset_api_test.dart       | Bin 5772 -> 5755 bytes
 open-api/immich-openapi-specs.json            |   3 ---
 open-api/typescript-sdk/src/fetch-client.ts   |   1 -
 .../src/immich/api-v1/asset/asset.service.ts  |   9 -------
 .../api-v1/asset/dto/create-asset.dto.ts      |  23 +++++++-----------
 7 files changed, 9 insertions(+), 27 deletions(-)

diff --git a/mobile/openapi/doc/AssetApi.md b/mobile/openapi/doc/AssetApi.md
index 93b758a5959f2fff4014e76f2091ec58b91ad5e9..c65e6a605f7bd3ce2e2c71a41e6dafc6ed48967e 100644
GIT binary patch
delta 49
zcmZ2`g!$NE<_%F-Ca-VgncQ*5ZS#&R2U#coOH<ms|JFuEkm%-)J8?{t&wFTZwz>b2
F2>_RG8RGx|

delta 61
zcmV-D0K)&q!vn3v1F%}ulMSdClT6%3v#iv?1(U>~NRw2eX|wv;Mgfxzs2H<M++G5c
TI;>Wc=B$2`kgY4Te&0v}!{Z*C

diff --git a/mobile/openapi/lib/api/asset_api.dart b/mobile/openapi/lib/api/asset_api.dart
index bdcb874092378527d0ccb73ea9673e4c99e60141..786129b457ba1aa0e37d5f8db362f0b71ba1d961 100644
GIT binary patch
delta 77
zcmbPzg?Zs6<_&UJCp(lXZcey5i*fRVGNH|K*O}NR`xi(}o_}9u^R2rFSV7X06Rw_}
gyz<Evkc!E2*E=Q)l#5Sxcs6-*L%GCe=I0X30Fgr^CjbBd

delta 116
zcmZ2@iFx)F<_&UJCtv7y+H8My7UN{jsVbBAKk1lkV`#s5({*ds$zSG3O%}MN!j)O<
zT2Yc(l$V$@+3}V*GWX#e;mQ65U{#y7?;c<U88+Ge>e<ORA725Pw|V~)BgV-dTMagI
IK9gVu09oZVy8r+H

diff --git a/mobile/openapi/test/asset_api_test.dart b/mobile/openapi/test/asset_api_test.dart
index 06375c6b49e58e70a7c41f50f7db5fd2eb50b199..846a5998cc88e229dee793d3bc8f4df4ee2622bd 100644
GIT binary patch
delta 19
bcmeCt{jIZMh3MoDEL@Wxu(MA-C3*+|SMCUu

delta 15
XcmeyZ)1$j#h3Mpu{7RE|iXH+0I@bp#

diff --git a/open-api/immich-openapi-specs.json b/open-api/immich-openapi-specs.json
index f38780f29..c0e868985 100644
--- a/open-api/immich-openapi-specs.json
+++ b/open-api/immich-openapi-specs.json
@@ -7541,9 +7541,6 @@
           "isArchived": {
             "type": "boolean"
           },
-          "isExternal": {
-            "type": "boolean"
-          },
           "isFavorite": {
             "type": "boolean"
           },
diff --git a/open-api/typescript-sdk/src/fetch-client.ts b/open-api/typescript-sdk/src/fetch-client.ts
index ce768d518..b512bce29 100644
--- a/open-api/typescript-sdk/src/fetch-client.ts
+++ b/open-api/typescript-sdk/src/fetch-client.ts
@@ -289,7 +289,6 @@ export type CreateAssetDto = {
     fileCreatedAt: string;
     fileModifiedAt: string;
     isArchived?: boolean;
-    isExternal?: boolean;
     isFavorite?: boolean;
     isOffline?: boolean;
     isReadOnly?: boolean;
diff --git a/server/src/immich/api-v1/asset/asset.service.ts b/server/src/immich/api-v1/asset/asset.service.ts
index 17488016c..5dcc487be 100644
--- a/server/src/immich/api-v1/asset/asset.service.ts
+++ b/server/src/immich/api-v1/asset/asset.service.ts
@@ -341,7 +341,6 @@ export class AssetService {
       fileCreatedAt: dto.fileCreatedAt,
       fileModifiedAt: dto.fileModifiedAt,
       localDateTime: dto.fileCreatedAt,
-      deletedAt: null,
 
       type: mimeTypes.assetType(file.originalPath),
       isFavorite: dto.isFavorite,
@@ -349,17 +348,9 @@ export class AssetService {
       duration: dto.duration || null,
       isVisible: dto.isVisible ?? true,
       livePhotoVideo: livePhotoAssetId === null ? null : ({ id: livePhotoAssetId } as AssetEntity),
-      resizePath: null,
-      webpPath: null,
-      thumbhash: null,
-      encodedVideoPath: null,
-      tags: [],
-      sharedLinks: [],
       originalFileName: parse(file.originalName).name,
-      faces: [],
       sidecarPath: sidecarPath || null,
       isReadOnly: dto.isReadOnly ?? false,
-      isExternal: dto.isExternal ?? false,
       isOffline: dto.isOffline ?? false,
     });
 
diff --git a/server/src/immich/api-v1/asset/dto/create-asset.dto.ts b/server/src/immich/api-v1/asset/dto/create-asset.dto.ts
index ae347e61b..9850384d9 100644
--- a/server/src/immich/api-v1/asset/dto/create-asset.dto.ts
+++ b/server/src/immich/api-v1/asset/dto/create-asset.dto.ts
@@ -3,7 +3,10 @@ import { ApiProperty } from '@nestjs/swagger';
 import { Transform, Type } from 'class-transformer';
 import { IsBoolean, IsDate, IsNotEmpty, IsString } from 'class-validator';
 
-export class CreateAssetBase {
+export class CreateAssetDto {
+  @ValidateUUID({ optional: true })
+  libraryId?: string;
+
   @IsNotEmpty()
   @IsString()
   deviceAssetId!: string;
@@ -22,6 +25,10 @@ export class CreateAssetBase {
   @Type(() => Date)
   fileModifiedAt!: Date;
 
+  @Optional()
+  @IsString()
+  duration?: string;
+
   @Optional()
   @IsBoolean()
   @Transform(toBoolean)
@@ -37,28 +44,16 @@ export class CreateAssetBase {
   @Transform(toBoolean)
   isVisible?: boolean;
 
-  @Optional()
-  @IsString()
-  duration?: string;
-
-  @Optional()
-  @IsBoolean()
-  isExternal?: boolean;
-
   @Optional()
   @IsBoolean()
+  @Transform(toBoolean)
   isOffline?: boolean;
-}
 
-export class CreateAssetDto extends CreateAssetBase {
   @Optional()
   @IsBoolean()
   @Transform(toBoolean)
   isReadOnly?: boolean;
 
-  @ValidateUUID({ optional: true })
-  libraryId?: string;
-
   // The properties below are added to correctly generate the API docs
   // and client SDKs. Validation should be handled in the controller.
   @ApiProperty({ type: 'string', format: 'binary' })