From 70b9a4c8f1b6dd1be62c1c14dcd73ede9f8f614d Mon Sep 17 00:00:00 2001
From: shenlong <139912620+shenlong-tanwen@users.noreply.github.com>
Date: Wed, 4 Jun 2025 18:51:34 +0530
Subject: [PATCH] chore: add missing api properties on sync enums (#18916)

Co-authored-by: shenlong-tanwen <139912620+shalong-tanwen@users.noreply.github.com>
---
 .../repositories/sync_stream.repository.dart  |  25 ++++++-------
 .../openapi/lib/model/sync_album_user_v1.dart | Bin 5851 -> 3254 bytes
 mobile/openapi/lib/model/sync_asset_v1.dart   | Bin 12089 -> 6416 bytes
 open-api/immich-openapi-specs.json            |  34 ++++++++----------
 server/src/dtos/sync.dto.ts                   |   3 ++
 5 files changed, 31 insertions(+), 31 deletions(-)

diff --git a/mobile/lib/infrastructure/repositories/sync_stream.repository.dart b/mobile/lib/infrastructure/repositories/sync_stream.repository.dart
index 804f66c5b..7aa8fc6ef 100644
--- a/mobile/lib/infrastructure/repositories/sync_stream.repository.dart
+++ b/mobile/lib/infrastructure/repositories/sync_stream.repository.dart
@@ -7,6 +7,7 @@ import 'package:immich_mobile/infrastructure/entities/remote_asset.entity.drift.
 import 'package:immich_mobile/infrastructure/entities/user.entity.drift.dart';
 import 'package:immich_mobile/infrastructure/repositories/db.repository.dart';
 import 'package:logging/logging.dart';
+import 'package:openapi/api.dart' as api show AssetVisibility;
 import 'package:openapi/api.dart' hide AssetVisibility;
 
 class DriftSyncStreamRepository extends DriftDatabaseRepository
@@ -231,22 +232,22 @@ class DriftSyncStreamRepository extends DriftDatabaseRepository
       });
 }
 
-extension on SyncAssetV1TypeEnum {
+extension on AssetTypeEnum {
   AssetType toAssetType() => switch (this) {
-        SyncAssetV1TypeEnum.IMAGE => AssetType.image,
-        SyncAssetV1TypeEnum.VIDEO => AssetType.video,
-        SyncAssetV1TypeEnum.AUDIO => AssetType.audio,
-        SyncAssetV1TypeEnum.OTHER => AssetType.other,
-        _ => throw Exception('Unknown SyncAssetV1TypeEnum value: $this'),
+        AssetTypeEnum.IMAGE => AssetType.image,
+        AssetTypeEnum.VIDEO => AssetType.video,
+        AssetTypeEnum.AUDIO => AssetType.audio,
+        AssetTypeEnum.OTHER => AssetType.other,
+        _ => throw Exception('Unknown AssetType value: $this'),
       };
 }
 
-extension on SyncAssetV1VisibilityEnum {
+extension on api.AssetVisibility {
   AssetVisibility toAssetVisibility() => switch (this) {
-        SyncAssetV1VisibilityEnum.timeline => AssetVisibility.timeline,
-        SyncAssetV1VisibilityEnum.hidden => AssetVisibility.hidden,
-        SyncAssetV1VisibilityEnum.archive => AssetVisibility.archive,
-        SyncAssetV1VisibilityEnum.locked => AssetVisibility.locked,
-        _ => throw Exception('Unknown SyncAssetV1VisibilityEnum value: $this'),
+        api.AssetVisibility.timeline => AssetVisibility.timeline,
+        api.AssetVisibility.hidden => AssetVisibility.hidden,
+        api.AssetVisibility.archive => AssetVisibility.archive,
+        api.AssetVisibility.locked => AssetVisibility.locked,
+        _ => throw Exception('Unknown AssetVisibility value: $this'),
       };
 }
diff --git a/mobile/openapi/lib/model/sync_album_user_v1.dart b/mobile/openapi/lib/model/sync_album_user_v1.dart
index c2b8ed7f48d3c75bb8655ef885ede61f34bef2e3..0b4968b34dd6d08838e934cab68e6875fb76ef39 100644
GIT binary patch
delta 45
ncmcbuyG?S#Ge%y=oTSp+(Bjmhp!}TF&3_rgS<r;C+2Yv%q?i$6

literal 5851
zcmd5=ZExeo5&rI9F&7+S8CB?}p8_Y6W7NLJ*TfF)d;tnU5Z2_%Vvbs>yW|PN#s9s}
z%q%I2mh5YRqCMa&X*q8@^UNDhPmfMd>EgrP?KgkBy19CHad&k|Z?1p78q(!0-Q3>M
zFSnQ1Z~pNLWK8*EW_&gJOY-e^NBlE?aHY4idFf~Kys&3fyE@oxW(&Ktt{OJK^X01a
z)m{!$tj#9OR&_P=_Mdg`!S2iwe^<uiv$8%wxDWf;)6#{?xN4SXP?*ni>xDh+RaWHA
zhFMX%2ar_@<7VIed6q7W4@XB(S5Y~qa%G)a<q7_Oe{_@<CIouFap^^IUoSrd>wo)}
zJ|7XC;{NY!ReKl6kh5!=^vI@^i*cz<K;L^fU>QWsovB*nAu+7uIvehJ<jcbDJBPo$
zay*{EUg)WO?j9(L(xYAT-$B%stCz$wyF4mOPJS#uS?}RgNW3r0g5BaxReBnY2DkUW
z+Z4{K7S^B8XiVz-)D#20#;|$v#~=EQ@~1BR`fItQ$Y|~j*^S+_^PCOkhw{1eL`~*r
z2aL~MMGv;3g$awlmKns1MRAK>2CcKH4Z-*ggAO=a*pLSy8$>@Q4gU%KNguE+Pfyi~
z?fDaD#_&|7ei?}Wj(gykM6ILO4I<>~qt~nyStT(az1Gj^u_*b)tbS0LL&`Qtp*$T^
zRlW_SgAzsCJa?v`-*H4EdP4pA@q4)%3B|-8N9D&;P<Qd!BV(hsH2kYapmuIa^tTdu
zNg>h52agQle<!ubxQw*E1j?&GpG;BPKyzO%qo|1-Asgo)IOc4fz**BFxw-(b8O7^7
zNRoC?vGR6~Dj@~N*D0VMW}Fl=)SD_#XDCgJGGmnJK|jII#RPGG42PQ5#G+n3c$3-7
zsvL-YL;9+Rg0GO!Tq9t&l5ifu@<syDPCP|QlA2IGiR?g2gBBbvS$$&%qKKczn4i(o
ztbSux-p=nfD;q_Q2MnGeZLx9kN~@B{M(EG_qTk_=t4+cY5qGc%pi5!X<yTz1s5-)F
z%NhOjD3^$U;@Gx;iV^xbXW#4=!!Z>&ebd<1gi5dZSxVo7FW2UtD-g|15$y1>iGcdw
z+fWykWK>V~WV($YOXL8u5vXp0_#_WEWp%Y&Rhvd6f{G$Lh?2`SdWev2pEqHbctdON
zLR&w>?C2Q|&K5<lMuPmVL~cZUiNs`?Vy(lee&yU`IXhmCTvf@p8Z?eNqvo4Pk(`bp
z=vJwo;bVr}-as^#s#8EEzLq{W>|cM}R58A9<8x?z*5yJs(vTcVAXKF|@0?LPn#?dA
zU<l%2NBhN2_;BhsO#l=AmD|u<hJC3QdNGh9ClRtvSY8My+%!?fk9NZqT=*4_+c-Ay
z+=(h!+tk6W@so?DIH}auzs{=#jyQFAX6i-q8>IqMEXU|Wpyt_;g#ku;(7*_KlAMAG
zezF%AL;A7=h0ZQw_G|i2aPx(b_!4-<0^CXd7tw=j?MAp4hJ?e@I<5nvVVj@ZOdYn!
z+LPwc)B(gP-7Rbz`*wl_%mT&)gBaI<#l0o8&;YfZ0fyebzrEo(IEG&OYCHb^oq5}l
zWc*pY(as;*VYFey@39B)FH9|{F#9L<runoJ`?anMxv4B{;;G&8BrJHwAOMrgPnc#i
zibDfitfuyy+el7kGV`|C33?u1*h96;tS>e^jcbY{Q+SM0l}o$4x1Qx|6^Mgj%u*b8
zNASH<<Ce62{1#0{N6PKP9f#X2mm$8NvYqSrV<kEkMC@>X%I(@>1$dTQiI_Y3g7b~5
zgu%46Dp4@Gmx_Iu*qpiqK(3e5{sz@pHGKk{$j*@2?YRxhcmnN2dKCqY8phwzmhm@U
z?SO#8^BWeP13Ww_-Ff2z(s*h8;3Uaxilw7%savi4ico9&e{m*hb^I@8lScXf<BWnD
zB8l6C4?{i%Hr@ZFs-?yeV9N2FV(S2O0U(!JhW0_=a_5U%nTY3YWul;%HftIhV`b>x
zq#v33ps3{e64%3?RJ^(2y=C*oaOGWo*52#<eDr+n>#0O3)TDp5U>;(MHB22mIFMlC
zDp{G?XIgaII&&$xCi`78#!H!)PMCPAL&yQaTwoA>{Y%$~D5_PtzQGoO#SwkY*Jv0B
z9yf`}Uh%+(E2Zygd@~Al%I_8C5VGO2!}tQf)5Q}~byu-jLO+#ji{*02V|q`u>>SVQ
zj<R2{Ky@>UKR9g6`i{<KSKgOiFS)?V;C5ZXjjU%7?A+jeipw^%=G#Ex#jn?d_h@*p
z2KU2Doz^NLU>9PwKwrgj<LwfQw7lhFk1##Ab5MATqMV~m)Ir{1IVuYXTdlSYnh!Vy
z*~$a4Jf~Q7n=o<sn_009E4mm5wcX`-oR&m<vK|FY2kAnecBgl23KpAi?3QOSnun}P
zl#b^p{TJC|yL^#d>9*{dof~XyXRSP4@m{qT?3&6ND~>K*_=lR;6^Z)b_=EfC5OW<#
zG*qZT>c2C3%?{ByAQ~OlzrAb2&dSY^eUBg(wn7;_RMdLKVE2vb^ZmKUdcG}OIuHH}
DH@tEc

diff --git a/mobile/openapi/lib/model/sync_asset_v1.dart b/mobile/openapi/lib/model/sync_asset_v1.dart
index a3aa7365adb9697b4b25a956d3037121967c7bbd..27042325ee31cffb17e89a37c00176d17a11bd67 100644
GIT binary patch
delta 90
zcmdlPH^FGbQD!yA;^NejkjjEo*SykPg%Tjcnu|+80W2JrS)7@anUh&kx%oG<E*~dc
V?c{nP(aAnSa{TDZnuXS~0Ra2sAz1(b

literal 12089
zcmeHNZExE~68`RAu`Y~C#;J00ABw;|*)?jXb*`}wi4)*p2m&pxEH)CUE-4#A>i^zn
zcJ`H|UYcuz%i#h<7I$Z6cjx7qnWc`7_KuFk*}I$TZ+^VEx_EPTb8#+SUjBU16X)0B
z>iR~!zCOQv`R{#@5#{%3qN>5)`_EtO(PMU>7fOyMg&Iw=nLHNDd|AqLBxiCi^Qvc`
zv-zS>RVzm_drVg4XtAtDO8&ac6xj1*j?YD+@VAnxgm6{1vyY3stdhJMWhoZSCYe;4
zy=+}<mgTY>&5HaUWYsjuM=zd@#?wTVdwW=}62(Lm3z;X2tdIZS?d^?cNm+`wt9*P`
zma=;PTzuRU;s|GdBdev#OOc3NK8o9bWGFJdsj=*XHkjxVuMqZ}qMBx9e>|1r59M;+
zYne--$V#SXRof(K{0AkIjRdcYl$5eYM3%M*&dQg`L!q)tw$09paWXr{syErZl>nUg
zS)R;ZVt-e#V4INQF_-GHb@ghxoZn58a@xjMtro5F9<nmK%Vt@%BCe-HSPq)6RF>Zh
zt6)85H-0LdZfoO_T3hD4M#Dw2R6pGn#Y}kp)z~A|h1_+OMRTmGVCWQ%V|2u$-aBug
zpNo7s7o@2A<a?(iP2zQ?3BNBMq*4eYXigskfuNGAP+~CXUf=y9#|V#VD%GJFoCpp#
zctV$)xMyd6`;EUr2chGOufNvbt@)kDL$EVWOyO)pB>o|i64{C9;(-ROx0@vnMk4Ag
zB?^4Tqb@4+tbdBAA`=r~JP^^=txn{Pv6zE>K@*y<(Y*5uqVNwf4Ln0n)8A;uI|R-9
zr-plEc_r>;B`8XNC{l<!(dKm-ff7M3$FeLFwIUz~Hcw@lm71(;BeHJ=9E!j3jJGv*
zkS}L5aVnmPWA6j|O`h29F<&&dhBt77CbOSx;m*?LZhY`J=VD)o7mMav)~Y*3Q@X*_
z=7e{Icu6<jvK-+@Q<C=yKiBXM1G`nhU%DDEIzbw|we}wz*l#^=;lY7(f?gccgM-MN
zJnId_)Bd@K5FQ*L#RY(jXBW7=I5r0dkqH24wLCUBsE>e#qYzX4rRSq=aNzWdQK%CG
z`0NFNH8}7J9d@)LUnh%yu->4O6$+tjd?KpiRaxXvB-alU%C6!U42gkgP=9>-PREka
z6t}8lb=(<(JSsVuFq;Ss;(e!gvCqM07j&W=g_q@q_WM=wt{Qg_@%OSUUVQuPxpe?u
z=Sj#}Da{!G6?T74f)+|aZ|L<g-0mXVuiarp<#!nkfAUTvDcg7JU2)@fJz2b8KmH$W
z*o$f1u`@%K`sJybp-R<Hx~K_=+*r+zqBvT6^oYt!jfOw@;E|Ng=dK5}-%5R^rV|tL
z0X<_tO&bmc)@s60cu{VMg{=!6N4EKhggb$3Jk^fkVaSvDF(y{J-_b!!15Z?8@7f26
zBu@o5fu+c*QamKHr7Xon6>}rzRu7?dnt-4~ZPhKXaM<H2Ko^dWS*bg!pv+h(IYBF@
zyFj%ZqgpLTRL73c6js@Ig#K|_q*QkBKv<NX>g6@E8l>fIS=3uD?p2b?^Q!3Tz4gRb
zK@$54Jq85`;gg=Gk{3I++yc2PfN4$AA17ti0PHSzD<sV5I9R5u7oj-|<Hus2EZ&p;
zt|vDzrIB~irG(HE0p1_(a|=b>4rDdE?SdSSo9>W=&Y@?FFt43CB54)iF=)L6Pty>Q
zrCSdT^a_vbvwVY-dK<4SPZ;q>_|d-Sh@`RQI(9U+!MV|Iq|Oj+$3V??A&fu~ufvF~
z+>SD|KVipl7&hc{)Iatqcy;uU<Dt%AlnJfiAtaLUKI%goay(aO=%tx(d(!b>;>6Yp
z8jDPT|C~{X`HuKR%rNrO?$t&*2g^s@=-#X1F}a(ejS-UsB}(tf1~G@QlI3z%=~^q0
zdpq<1K+-7wX>s&a8YKH!c~w*w^F_6?;(!Tgr@KaK@rZjOP3q?@YA~V<LcM!EVY@~f
z6xkkt8dV!j^XB_WnlelUoUBWNaw3d0Yq+X{PSmvuIu`bumJ+HxtXm`P1FTw=Z_mui
z099Dah7xQ&OXswD#%deYtmy`9hIN>W<Yn$JkA=Hx9O1SPmzs2W$-Qc1GK{K~HCmsZ
zGFjS#kPi7U8;z%B^fgIfiY-QjdTyEVgIrM=uld>kyzQ(FBTIrcNY|7*D7R__6@01l
zm{n5@QJB#EXQ2CUm;wwYW1|xRCEWp&Ah?YQy4OM1LLL(Z;0e*vXsaLe#BM<d8KH+X
zSNRk_+0g}daVL|fg8<*^EjUta)j;)qGKW)G;50oKgFYI2&XZa~8LI>ia3pS~(%IVG
zM8mC0^o9xSx`Z3tNrB3$#Ioe=iFoz)`ikzdjk$HX<*u>+NxZHRJ^83L;k!;QB|1Tc
z!34Fc!4HOo0FNTM8!17$HY2q(%nXfWYKU#gZXSKYvjfO&cBvo@(JZ=Z;9c{5fK7+)
zy}%{EkjQXD4$aZK0ZA9KI?8Yf2E`T+xIImUsd!1RtkA&xR%(C5t+~Yu&{EA!HeBYZ
zRI?S`a5LZ_cB#AP<>qpJCl$$NOyY9G;s%Dp>s~V%-`E(40jZmQg*3<4Ies#7iObh#
zKVHBW+E1c7dcLE*HR5}Jd46%dfltr3@SVLozud&9=Ue!$Z+^OXvtd0wPkct-gf@hY
z2`(fT1yTf63t9(gXL43MLU}nKhVOx_5r>V?F{~6czM`<?C%0Ht2(2sjOMQI)s!zmU
z^(N^n3K4u7g|-M>-{{~XzlEMQa-)*G1endG!i`QU$GGNo1%zL%4#VyYe^J%t<bUq!
z%P#!iScL(XG$>e;q4PyK%5N?;rjL_cz&*)^L$u;>SvX5RmgLf{4oi8SqrRs_Q~Q3)
zPB66Bk|+bJMBF9g4@BK6roSF8Yd)sYbCOU4zuL(q=^fO_o#XTrZ<6Ru@D99yR1WMv
z%wTYk71?bG9IX<4-A%gTBF|ySxsD-yv0<AK4FkhlA|7&S)gqL@1LoyVaS4k7g^I^3
z+>_$A1X)`xk!WBbN-nppqGA8M&{>^rn2K^arnfT_2+?m$$$!9~^KA>Ha)%|;zWAwl
zl(<pBEqY^V-7Rfi+iZKw4tQ<y(swzoiTKw8GQCi$P<+TKnw~sX1tr0nF0juP-b&@^
zN<7kOAo1*9m$*7f@Wvmihn9krtkq8{M013EjMhxaIc|^iYiZI5(c||F3KU8LU^Bq~
zvZRa)!Nm;177L%)X@EkEcG+S_dgH87)S8IQZmVBsQY0lZsOvzfG0=h5Xzof>6yqt+
zhCK-S9f>;}PPNCzkZl|4YZ9sr`JZ9rT)UA`lQbAP*=}UiBn?K+wi_8WiDyjZBtc7l
z?Do!W@V--Hs1Q0`MgAks)culLJMCB9&b$0W4zJ>ZiJbvR##TBO2c&kc9gKoZi`?2~
zMOP8zJ8$78`0)mSxD6U>@CP3^kQ|f>Ek0CZJM|FA)oBxN<GYqWw@8g;e_^F+qQ=wg
zf$n?)JvUCII)<*Lh^+AY7y3cbRuPu4MaDD(^w4X(&6{Ad7JhU;9{^q3_?e9O4IY15
zK^v=Q$FeqNGR3XYDi^X=Km5dJ<?p=jO*L*Teb-7i=Bh>2AE|d^L4Va<V{MhsUHit%
z|4&!I@lkbA_UUzSO;}4c98=W%a9vHjk%`;$EtT;`3G3_Q-PqPv$uaw%S}Vt*<1+F8
z6|-v|zL1JJw&rK9n{B>tD@Wsv^$n>nOHBoB^I2yH8J4yo#H9QkL@;GTfXVqg2w+Mt
V;ES!UWBb(LbX$$Rk-1T6{|<F8RF(h$

diff --git a/open-api/immich-openapi-specs.json b/open-api/immich-openapi-specs.json
index de01d7e06..04cdf4f70 100644
--- a/open-api/immich-openapi-specs.json
+++ b/open-api/immich-openapi-specs.json
@@ -12988,11 +12988,11 @@
             "type": "string"
           },
           "role": {
-            "enum": [
-              "editor",
-              "viewer"
-            ],
-            "type": "string"
+            "allOf": [
+              {
+                "$ref": "#/components/schemas/AlbumUserRole"
+              }
+            ]
           },
           "userId": {
             "type": "string"
@@ -13241,22 +13241,18 @@
             "type": "string"
           },
           "type": {
-            "enum": [
-              "IMAGE",
-              "VIDEO",
-              "AUDIO",
-              "OTHER"
-            ],
-            "type": "string"
+            "allOf": [
+              {
+                "$ref": "#/components/schemas/AssetTypeEnum"
+              }
+            ]
           },
           "visibility": {
-            "enum": [
-              "archive",
-              "timeline",
-              "hidden",
-              "locked"
-            ],
-            "type": "string"
+            "allOf": [
+              {
+                "$ref": "#/components/schemas/AssetVisibility"
+              }
+            ]
           }
         },
         "required": [
diff --git a/server/src/dtos/sync.dto.ts b/server/src/dtos/sync.dto.ts
index 3e50762c8..3088392c6 100644
--- a/server/src/dtos/sync.dto.ts
+++ b/server/src/dtos/sync.dto.ts
@@ -65,9 +65,11 @@ export class SyncAssetV1 {
   fileCreatedAt!: Date | null;
   fileModifiedAt!: Date | null;
   localDateTime!: Date | null;
+  @ApiProperty({ enumName: 'AssetTypeEnum', enum: AssetType })
   type!: AssetType;
   deletedAt!: Date | null;
   isFavorite!: boolean;
+  @ApiProperty({ enumName: 'AssetVisibility', enum: AssetVisibility })
   visibility!: AssetVisibility;
 }
 
@@ -125,6 +127,7 @@ export class SyncAlbumUserDeleteV1 {
 export class SyncAlbumUserV1 {
   albumId!: string;
   userId!: string;
+  @ApiProperty({ enumName: 'AlbumUserRole', enum: AlbumUserRole })
   role!: AlbumUserRole;
 }