From 7d6cfd09e6ef7b5f5132ee53045a08c654ef0f6f Mon Sep 17 00:00:00 2001
From: Mert <101130780+mertalev@users.noreply.github.com>
Date: Thu, 27 Feb 2025 17:17:07 +0300
Subject: [PATCH] fix(server): don't expose source types in face creation api
 (#16381)

* don't expose source types in face creation api

* update open-api

* remove source type reference from web
---
 .../lib/model/asset_face_create_dto.dart      | Bin 4690 -> 4407 bytes
 open-api/immich-openapi-specs.json            |   9 ---------
 open-api/typescript-sdk/src/fetch-client.ts   |   1 -
 server/src/dtos/person.dto.ts                 |   6 +-----
 server/src/services/person.service.ts         |   2 +-
 .../face-editor/face-editor.svelte            |   3 +--
 6 files changed, 3 insertions(+), 18 deletions(-)

diff --git a/mobile/openapi/lib/model/asset_face_create_dto.dart b/mobile/openapi/lib/model/asset_face_create_dto.dart
index d25a5d8b828ad218737ebebee46c86cf41e6dcba..29e8244a9623da9378af98f016d6507d11a5e241 100644
GIT binary patch
delta 43
zcmV+`0M!4|B)1~47y^?)0;RG8K>@R81PcL^js@4VeFj4Tv+V~R1G7mB)drI=5+X_+
B4ov_6

delta 259
zcmdn4bV+4{1e0<}MrN^Iaeir0a%xCrL8^kSLNJ`8mz$VZnwT@$fk|Yt8q;)9gp2}0
z$L1YOZj2HLzJjeSvg`+DNk%S&?Bwq(FU1gCTNMO*^F3BqMmYpuJr?K~H0Ny=Vb@_c
nMyRnuc5PZwey&$>ex61akcci)M<`Q|-E6}3kPX=#yn<Q)=F(sl

diff --git a/open-api/immich-openapi-specs.json b/open-api/immich-openapi-specs.json
index aeafc27ee..5730e4157 100644
--- a/open-api/immich-openapi-specs.json
+++ b/open-api/immich-openapi-specs.json
@@ -8301,14 +8301,6 @@
             "format": "uuid",
             "type": "string"
           },
-          "sourceType": {
-            "allOf": [
-              {
-                "$ref": "#/components/schemas/SourceType"
-              }
-            ],
-            "default": "manual"
-          },
           "width": {
             "type": "integer"
           },
@@ -8325,7 +8317,6 @@
           "imageHeight",
           "imageWidth",
           "personId",
-          "sourceType",
           "width",
           "x",
           "y"
diff --git a/open-api/typescript-sdk/src/fetch-client.ts b/open-api/typescript-sdk/src/fetch-client.ts
index 7237e0aac..b2895f6f1 100644
--- a/open-api/typescript-sdk/src/fetch-client.ts
+++ b/open-api/typescript-sdk/src/fetch-client.ts
@@ -529,7 +529,6 @@ export type AssetFaceCreateDto = {
     imageHeight: number;
     imageWidth: number;
     personId: string;
-    sourceType: SourceType;
     width: number;
     x: number;
     y: number;
diff --git a/server/src/dtos/person.dto.ts b/server/src/dtos/person.dto.ts
index c4d3018be..0778c35b8 100644
--- a/server/src/dtos/person.dto.ts
+++ b/server/src/dtos/person.dto.ts
@@ -1,6 +1,6 @@
 import { ApiProperty, ApiPropertyOptional } from '@nestjs/swagger';
 import { Type } from 'class-transformer';
-import { IsArray, IsEnum, IsInt, IsNotEmpty, IsNumber, IsString, Max, Min, ValidateNested } from 'class-validator';
+import { IsArray, IsInt, IsNotEmpty, IsNumber, IsString, Max, Min, ValidateNested } from 'class-validator';
 import { DateTime } from 'luxon';
 import { PropertyLifecycle } from 'src/decorators';
 import { AuthDto } from 'src/dtos/auth.dto';
@@ -194,10 +194,6 @@ export class AssetFaceCreateDto extends AssetFaceUpdateItem {
   @IsNotEmpty()
   @IsNumber()
   height!: number;
-
-  @ApiProperty({ type: 'string', enum: SourceType, enumName: 'SourceType' })
-  @IsEnum(SourceType)
-  sourceType: SourceType = SourceType.MANUAL;
 }
 
 export class AssetFaceDeleteDto {
diff --git a/server/src/services/person.service.ts b/server/src/services/person.service.ts
index 62bf55a78..e297910a9 100644
--- a/server/src/services/person.service.ts
+++ b/server/src/services/person.service.ts
@@ -736,7 +736,7 @@ export class PersonService extends BaseService {
       boundingBoxX2: dto.x + dto.width,
       boundingBoxY1: dto.y,
       boundingBoxY2: dto.y + dto.height,
-      sourceType: dto.sourceType,
+      sourceType: SourceType.MANUAL,
     });
   }
 
diff --git a/web/src/lib/components/asset-viewer/face-editor/face-editor.svelte b/web/src/lib/components/asset-viewer/face-editor/face-editor.svelte
index bcc9ee687..afe45331e 100644
--- a/web/src/lib/components/asset-viewer/face-editor/face-editor.svelte
+++ b/web/src/lib/components/asset-viewer/face-editor/face-editor.svelte
@@ -4,7 +4,7 @@
   import { notificationController } from '$lib/components/shared-components/notification/notification';
   import { isFaceEditMode } from '$lib/stores/face-edit.svelte';
   import { getPeopleThumbnailUrl } from '$lib/utils';
-  import { getAllPeople, createFace, type PersonResponseDto, SourceType } from '@immich/sdk';
+  import { getAllPeople, createFace, type PersonResponseDto } from '@immich/sdk';
   import { Button } from '@immich/ui';
   import { Canvas, InteractiveFabricObject, Rect } from 'fabric';
   import { onMount } from 'svelte';
@@ -288,7 +288,6 @@
         assetFaceCreateDto: {
           assetId,
           personId: person.id,
-          sourceType: SourceType.Manual,
           ...data,
         },
       });