feat: make memories slideshow duration configurable (#22783)

This commit is contained in:
Mees Frensel 2025-11-08 23:46:43 +01:00 committed by GitHub
parent 4905bba694
commit 9cc88ed2a6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
11 changed files with 37 additions and 2 deletions

View file

@ -2027,6 +2027,7 @@
"third_party_resources": "Third-Party Resources", "third_party_resources": "Third-Party Resources",
"time": "Time", "time": "Time",
"time_based_memories": "Time-based memories", "time_based_memories": "Time-based memories",
"time_based_memories_duration": "Number of seconds to display each image.",
"timeline": "Timeline", "timeline": "Timeline",
"timezone": "Timezone", "timezone": "Timezone",
"to_archive": "Archive", "to_archive": "Archive",

Binary file not shown.

Binary file not shown.

View file

@ -12646,18 +12646,27 @@
}, },
"MemoriesResponse": { "MemoriesResponse": {
"properties": { "properties": {
"duration": {
"default": 5,
"type": "integer"
},
"enabled": { "enabled": {
"default": true, "default": true,
"type": "boolean" "type": "boolean"
} }
}, },
"required": [ "required": [
"duration",
"enabled" "enabled"
], ],
"type": "object" "type": "object"
}, },
"MemoriesUpdate": { "MemoriesUpdate": {
"properties": { "properties": {
"duration": {
"minimum": 1,
"type": "integer"
},
"enabled": { "enabled": {
"type": "boolean" "type": "boolean"
} }

View file

@ -152,6 +152,7 @@ export type FoldersResponse = {
sidebarWeb: boolean; sidebarWeb: boolean;
}; };
export type MemoriesResponse = { export type MemoriesResponse = {
duration: number;
enabled: boolean; enabled: boolean;
}; };
export type PeopleResponse = { export type PeopleResponse = {
@ -209,6 +210,7 @@ export type FoldersUpdate = {
sidebarWeb?: boolean; sidebarWeb?: boolean;
}; };
export type MemoriesUpdate = { export type MemoriesUpdate = {
duration?: number;
enabled?: boolean; enabled?: boolean;
}; };
export type PeopleUpdate = { export type PeopleUpdate = {

View file

@ -13,6 +13,12 @@ class AvatarUpdate {
class MemoriesUpdate { class MemoriesUpdate {
@ValidateBoolean({ optional: true }) @ValidateBoolean({ optional: true })
enabled?: boolean; enabled?: boolean;
@Optional()
@IsInt()
@IsPositive()
@ApiProperty({ type: 'integer' })
duration?: number;
} }
class RatingsUpdate { class RatingsUpdate {
@ -166,6 +172,9 @@ class RatingsResponse {
class MemoriesResponse { class MemoriesResponse {
enabled: boolean = true; enabled: boolean = true;
@ApiProperty({ type: 'integer' })
duration: number = 5;
} }
class FoldersResponse { class FoldersResponse {

View file

@ -497,6 +497,7 @@ export interface UserPreferences {
}; };
memories: { memories: {
enabled: boolean; enabled: boolean;
duration: number;
}; };
people: { people: {
enabled: boolean; enabled: boolean;

View file

@ -16,6 +16,7 @@ const getDefaultPreferences = (): UserPreferences => {
}, },
memories: { memories: {
enabled: true, enabled: true,
duration: 5,
}, },
people: { people: {
enabled: true, enabled: true,

View file

@ -102,7 +102,7 @@
}); });
} else { } else {
progressBarController = new Tween<number>(0, { progressBarController = new Tween<number>(0, {
duration: (from: number, to: number) => (to ? 5000 * (to - from) : 0), duration: (from: number, to: number) => (to ? $preferences.memories.duration * 1000 * (to - from) : 0),
}); });
} }
}; };

View file

@ -1,7 +1,9 @@
<script lang="ts"> <script lang="ts">
import SettingAccordion from '$lib/components/shared-components/settings/setting-accordion.svelte'; import SettingAccordion from '$lib/components/shared-components/settings/setting-accordion.svelte';
import SettingInputField from '$lib/components/shared-components/settings/setting-input-field.svelte';
import SettingSelect from '$lib/components/shared-components/settings/setting-select.svelte'; import SettingSelect from '$lib/components/shared-components/settings/setting-select.svelte';
import SettingSwitch from '$lib/components/shared-components/settings/setting-switch.svelte'; import SettingSwitch from '$lib/components/shared-components/settings/setting-switch.svelte';
import { SettingInputFieldType } from '$lib/constants';
import { preferences } from '$lib/stores/user.store'; import { preferences } from '$lib/stores/user.store';
import { handleError } from '$lib/utils/handle-error'; import { handleError } from '$lib/utils/handle-error';
import { AssetOrder, updateMyPreferences } from '@immich/sdk'; import { AssetOrder, updateMyPreferences } from '@immich/sdk';
@ -18,6 +20,7 @@
// Memories // Memories
let memoriesEnabled = $state($preferences?.memories?.enabled ?? true); let memoriesEnabled = $state($preferences?.memories?.enabled ?? true);
let memoriesDuration = $state($preferences?.memories?.duration ?? 5);
// People // People
let peopleEnabled = $state($preferences?.people?.enabled ?? false); let peopleEnabled = $state($preferences?.people?.enabled ?? false);
@ -43,7 +46,7 @@
userPreferencesUpdateDto: { userPreferencesUpdateDto: {
albums: { defaultAssetOrder }, albums: { defaultAssetOrder },
folders: { enabled: foldersEnabled, sidebarWeb: foldersSidebar }, folders: { enabled: foldersEnabled, sidebarWeb: foldersSidebar },
memories: { enabled: memoriesEnabled }, memories: { enabled: memoriesEnabled, duration: memoriesDuration },
people: { enabled: peopleEnabled, sidebarWeb: peopleSidebar }, people: { enabled: peopleEnabled, sidebarWeb: peopleSidebar },
ratings: { enabled: ratingsEnabled }, ratings: { enabled: ratingsEnabled },
sharedLinks: { enabled: sharedLinksEnabled, sidebarWeb: sharedLinkSidebar }, sharedLinks: { enabled: sharedLinksEnabled, sidebarWeb: sharedLinkSidebar },
@ -103,6 +106,14 @@
<div class="ms-4 mt-6"> <div class="ms-4 mt-6">
<SettingSwitch title={$t('enable')} bind:checked={memoriesEnabled} /> <SettingSwitch title={$t('enable')} bind:checked={memoriesEnabled} />
</div> </div>
<div class="ms-4 mt-6">
<SettingInputField
inputType={SettingInputFieldType.NUMBER}
label={$t('duration')}
description={$t('time_based_memories_duration')}
bind:value={memoriesDuration}
/>
</div>
</SettingAccordion> </SettingAccordion>
<SettingAccordion key="people" title={$t('people')} subtitle={$t('people_feature_description')}> <SettingAccordion key="people" title={$t('people')} subtitle={$t('people_feature_description')}>

View file

@ -23,6 +23,7 @@ export const preferencesFactory = Sync.makeFactory<UserPreferencesResponseDto>({
}, },
memories: { memories: {
enabled: false, enabled: false,
duration: 5,
}, },
people: { people: {
enabled: false, enabled: false,