From 09be7b0b25e529f4e3bf5932b99925cc67d3fb93 Mon Sep 17 00:00:00 2001 From: rohks Date: Mon, 4 Nov 2024 05:40:22 -0800 Subject: [PATCH] Move `MediaExtractorCompatTest` from `test/` to `androidTest/` MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The test has been moved to an instrumentation test as it relies on APIs that vary by SDK version. Robolectric’s emulation lacks sufficient realism in some cases, which impacts test accuracy. By using an instrumentation test, we ensure that the tests run in a real Android environment, providing reliable results for SDK-dependent APIs. PiperOrigin-RevId: 692933259 (cherry picked from commit 261ca326c5aaa41e3acdea0ababc30622301096a) --- .../androidx/media3/exoplayer/MediaExtractorCompatTest.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) rename libraries/exoplayer/src/{test => androidTest}/java/androidx/media3/exoplayer/MediaExtractorCompatTest.java (99%) diff --git a/libraries/exoplayer/src/test/java/androidx/media3/exoplayer/MediaExtractorCompatTest.java b/libraries/exoplayer/src/androidTest/java/androidx/media3/exoplayer/MediaExtractorCompatTest.java similarity index 99% rename from libraries/exoplayer/src/test/java/androidx/media3/exoplayer/MediaExtractorCompatTest.java rename to libraries/exoplayer/src/androidTest/java/androidx/media3/exoplayer/MediaExtractorCompatTest.java index f810b1d26c..4d142b0e51 100644 --- a/libraries/exoplayer/src/test/java/androidx/media3/exoplayer/MediaExtractorCompatTest.java +++ b/libraries/exoplayer/src/androidTest/java/androidx/media3/exoplayer/MediaExtractorCompatTest.java @@ -37,7 +37,6 @@ import androidx.media3.extractor.SeekMap; import androidx.media3.extractor.SeekMap.SeekPoints; import androidx.media3.extractor.SeekPoint; import androidx.media3.extractor.TrackOutput; -import androidx.media3.test.utils.AssetContentProvider; import androidx.media3.test.utils.TestUtil; import androidx.test.core.app.ApplicationProvider; import androidx.test.ext.junit.runners.AndroidJUnit4; @@ -567,8 +566,7 @@ public class MediaExtractorCompatTest { public void setDataSourceUsingMethodExpectingContentUri_useContentUri_setsTrackCountCorrectly() throws IOException { Context context = ApplicationProvider.getApplicationContext(); - Uri contentUri = - AssetContentProvider.buildUri(/* filePath= */ "media/mp4/sample.mp4", /* pipeMode= */ true); + Uri contentUri = Uri.parse("asset:///media/mp4/sample.mp4"); MediaExtractorCompat mediaExtractorCompat = new MediaExtractorCompat(context); mediaExtractorCompat.setDataSource(context, contentUri, /* headers= */ null);