From 0ab9a219f7b78db6bd7f8cd283f6c72ac0cffceb Mon Sep 17 00:00:00 2001 From: tonihei Date: Mon, 15 Feb 2021 11:32:46 +0000 Subject: [PATCH] Clarify/correct restrictions of AdsMediaSource. The source can be used in compositions (in fact, every source is automatically used in an internal composition when constructing the playlist), and there is not really a concept of top-level media source any more since the Player supports playlists. The actual restriction is that the content media source needs to have exactly one period to be able to create a SinglePeriodAdTimeline. #minor-release PiperOrigin-RevId: 357544191 --- .../android/exoplayer2/source/ads/AdsMediaSource.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/library/core/src/main/java/com/google/android/exoplayer2/source/ads/AdsMediaSource.java b/library/core/src/main/java/com/google/android/exoplayer2/source/ads/AdsMediaSource.java index be1ab81cd3..dbe54168e8 100644 --- a/library/core/src/main/java/com/google/android/exoplayer2/source/ads/AdsMediaSource.java +++ b/library/core/src/main/java/com/google/android/exoplayer2/source/ads/AdsMediaSource.java @@ -51,9 +51,9 @@ import org.checkerframework.checker.nullness.compatqual.NullableType; import org.checkerframework.checker.nullness.qual.MonotonicNonNull; /** - * A {@link MediaSource} that inserts ads linearly with a provided content media source. This source - * cannot be used as a child source in a composition. It must be the top-level source used to - * prepare the player. + * A {@link MediaSource} that inserts ads linearly into a provided content media source. + * + *

The wrapped content media source must contain a single {@link Timeline.Period}. */ public final class AdsMediaSource extends CompositeMediaSource {