sjs/media
1
0
Fork 0
mirror of https://github.com/samsonjs/media.git synced 2026-04-27 15:07:40 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Cast void* to JniContext* using static_cast.

Browse source 
static_cast is more appropriate than reinrerpret_cast for casting from
void* to JniContext*. See Section 7.2.1 (page 173) in The C++
Programming Language, 4th Edition and
https://stackoverflow.com/questions/310451/should-i-use-static-cast-or-reinterpret-cast-when-casting-a-void-to-whatever

PiperOrigin-RevId: 293812940
This commit is contained in:
olly 2020-02-07 15:51:27 +00:00 committed by Oliver Woodman
parent 11635191a6
commit 0acc95cfbb
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
extensions/av1/src/main/jni/gav1_jni.cc
View file

@ -403,8 +403,7 @@ int Libgav1GetFrameBuffer(void* callback_private_data, int bitdepth,
return -1; return -1;
} }
JniContext* const context = JniContext* const context = static_cast<JniContext*>(callback_private_data);
reinterpret_cast<JniContext*>(callback_private_data);
JniFrameBuffer* jni_buffer; JniFrameBuffer* jni_buffer;
context->jni_status_code = context->buffer_manager.GetBuffer( context->jni_status_code = context->buffer_manager.GetBuffer(
static_cast<size_t>(y_plane_size), static_cast<size_t>(uv_plane_size), static_cast<size_t>(y_plane_size), static_cast<size_t>(uv_plane_size),
@ -443,8 +442,7 @@ int Libgav1GetFrameBuffer(void* callback_private_data, int bitdepth,
void Libgav1ReleaseFrameBuffer(void* callback_private_data, void Libgav1ReleaseFrameBuffer(void* callback_private_data,
void* buffer_private_data) { void* buffer_private_data) {
JniContext* const context = JniContext* const context = static_cast<JniContext*>(callback_private_data);
reinterpret_cast<JniContext*>(callback_private_data);
const int buffer_id = reinterpret_cast<int>(buffer_private_data); const int buffer_id = reinterpret_cast<int>(buffer_private_data);
context->jni_status_code = context->buffer_manager.ReleaseBuffer(buffer_id); context->jni_status_code = context->buffer_manager.ReleaseBuffer(buffer_id);
if (context->jni_status_code != kJniStatusOk) { if (context->jni_status_code != kJniStatusOk) {