sjs/media
1
0
Fork 0
mirror of https://github.com/samsonjs/media.git synced 2026-03-31 10:25:48 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Call future listener on the same handler that created the controller

Browse source 
The direct executor is not the proper way to determine on what thread to run the
`Future.Listener` and the `MediaControllerCreationListener` because the listener
may call the controller passed as argument which must happen on the same thread
that built the controller. This change makes sure this is the case.

PiperOrigin-RevId: 490478587
(cherry picked from commit 68908be18d)
This commit is contained in:
bachinger 2022-11-23 13:39:26 +00:00 committed by christosts
parent a98efd8b97
commit 0ba58cc634
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
libraries/test_session_current/src/androidTest/java/androidx/media3/session/MediaControllerTestRule.java
View file

@ -29,7 +29,6 @@ import androidx.media3.common.util.Log;
import androidx.media3.test.session.common.HandlerThreadTestRule;
import androidx.test.core.app.ApplicationProvider;
import com.google.common.util.concurrent.ListenableFuture;
import com.google.common.util.concurrent.MoreExecutors;
import java.util.Map;
import java.util.concurrent.ExecutionException;
import org.junit.rules.ExternalResource;
@ -206,7 +205,7 @@ public final class MediaControllerTestRule extends ExternalResource {
controllerCreationListener.onCreated(mediaController);
}
},
MoreExecutors.directExecutor());
handlerThreadTestRule.getHandler()::post);
}
return future.get(timeoutMs, MILLISECONDS);
}