sjs/media
1
0
Fork 0
mirror of https://github.com/samsonjs/media.git synced 2026-04-27 15:07:40 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Effect: Release FinalShaderProgramWrapper when releasing DVFP.

Browse source 
Otherwise, there's a memory leak of ~30MB, as this is never released.

This likely used to be considered released as part of what now became
`intermediateGlShaderPrograms`, but its release was missed after we split
`finalShaderProgramWrapper` out from the larger glShaderProgram list.

PiperOrigin-RevId: 590954785
This commit is contained in:
huangdarwin 2023-12-14 08:56:50 -08:00 committed by Copybara-Service
parent 7399b7c5ce
commit 0baf777c96
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
libraries/effect/src/main/java/androidx/media3/effect/DefaultVideoFrameProcessor.java
View file

@ -887,6 +887,7 @@ public final class DefaultVideoFrameProcessor implements VideoFrameProcessor {
for (int i = 0; i < intermediateGlShaderPrograms.size(); i++) { for (int i = 0; i < intermediateGlShaderPrograms.size(); i++) {
intermediateGlShaderPrograms.get(i).release(); intermediateGlShaderPrograms.get(i).release();
} }
finalShaderProgramWrapper.release();
} catch (Exception e) { } catch (Exception e) {
Log.e(TAG, "Error releasing shader program", e); Log.e(TAG, "Error releasing shader program", e);
} }