From 147cab89c31ad8153e50b5acc4b8ae763bdbdebb Mon Sep 17 00:00:00 2001 From: ibaker Date: Wed, 30 Aug 2023 12:36:19 -0700 Subject: [PATCH] Remove subtitle TODO from `CapturingRenderersFactory` We're moving towards parsing subtitles before the `SampleQueue`, and we already have subtitle playback assertions using `Player.Listener.onCues` which is the most 'complete' place to assert subtitle output from. We don't need to hook anything inside `TextRenderer`, so we can remove this TODO. PiperOrigin-RevId: 561418660 --- .../androidx/media3/test/utils/CapturingRenderersFactory.java | 2 -- 1 file changed, 2 deletions(-) diff --git a/libraries/test_utils/src/main/java/androidx/media3/test/utils/CapturingRenderersFactory.java b/libraries/test_utils/src/main/java/androidx/media3/test/utils/CapturingRenderersFactory.java index 20a556aed4..5a22c0b59c 100644 --- a/libraries/test_utils/src/main/java/androidx/media3/test/utils/CapturingRenderersFactory.java +++ b/libraries/test_utils/src/main/java/androidx/media3/test/utils/CapturingRenderersFactory.java @@ -62,8 +62,6 @@ import java.util.concurrent.atomic.AtomicBoolean; *

The captured interactions can be used in a test assertion via the {@link Dumper.Dumpable} * interface. */ -// TODO(internal b/174661563): Add support for capturing subtitles on the output of the -// SubtitleDecoder. And possibly Metadata too (for consistency). @UnstableApi public class CapturingRenderersFactory implements RenderersFactory, Dumper.Dumpable {