From 1ca80741e5504670cdf3e42de54ae2f5cdfa2bef Mon Sep 17 00:00:00 2001 From: claincly Date: Thu, 7 Apr 2022 17:53:34 +0100 Subject: [PATCH] Change SSIM transcode MIME type to H264. The MIME type was set to H265 to force transcoding. Now that we have an encoder factory that forces encoding, switching back to H264 ensures the quality test is conducted on more devices (those don't support H265 can be tested now). However, H265 should be part of the quality test after we have proper mechanism to skip test based on device capability. PiperOrigin-RevId: 440132471 --- .../media3/transformer/mh/TranscodeQualityTest.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libraries/transformer/src/androidTest/java/androidx/media3/transformer/mh/TranscodeQualityTest.java b/libraries/transformer/src/androidTest/java/androidx/media3/transformer/mh/TranscodeQualityTest.java index 0f269a59f3..9605dc8d55 100644 --- a/libraries/transformer/src/androidTest/java/androidx/media3/transformer/mh/TranscodeQualityTest.java +++ b/libraries/transformer/src/androidTest/java/androidx/media3/transformer/mh/TranscodeQualityTest.java @@ -33,13 +33,15 @@ import org.junit.runner.RunWith; /** Checks transcoding quality. */ @RunWith(AndroidJUnit4.class) public final class TranscodeQualityTest { + // TODO(b/228455984) Add test that calculates SSIM for transcoding to H265. @Test - public void singleTranscode_ssimIsGreaterThan90Percent() throws Exception { + public void transformWithDecodeEncode_ssimIsGreaterThan90Percent() throws Exception { Context context = ApplicationProvider.getApplicationContext(); Transformer transformer = new Transformer.Builder(context) .setTransformationRequest( - new TransformationRequest.Builder().setVideoMimeType(MimeTypes.VIDEO_H265).build()) + new TransformationRequest.Builder().setVideoMimeType(MimeTypes.VIDEO_H264).build()) + .setEncoderFactory(AndroidTestUtil.FORCE_ENCODE_ENCODER_FACTORY) .setRemoveAudio(true) .build();