From 2cc51db54aced04097058564365c562de8ae0286 Mon Sep 17 00:00:00 2001 From: kimvde Date: Fri, 16 Apr 2021 12:02:18 +0100 Subject: [PATCH] Refactor SEP prepare to clarify that it is equivalent to EPI prepare. Before this change: - SimpleExoPlayer.prepare(mediaSource) ended up calling ExoPlayerImpl.setMediaSourcesInternal() with startWindowIndex=0 and resetToDefaultPosition=false. - ExoPlayerImpl.prepare(mediaSource) ended up calling ExoPlayerImpl.setMediaSourcesInternal() with startWindowIndex=C.INDEX_UNSET and resetToDefaultPosition=true. This was functionaly equivalent but a bit confusing. #minor-release PiperOrigin-RevId: 368818143 --- .../java/com/google/android/exoplayer2/SimpleExoPlayer.java | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/library/core/src/main/java/com/google/android/exoplayer2/SimpleExoPlayer.java b/library/core/src/main/java/com/google/android/exoplayer2/SimpleExoPlayer.java index 435852b1ab..990de0f9e1 100644 --- a/library/core/src/main/java/com/google/android/exoplayer2/SimpleExoPlayer.java +++ b/library/core/src/main/java/com/google/android/exoplayer2/SimpleExoPlayer.java @@ -1354,10 +1354,7 @@ public class SimpleExoPlayer extends BasePlayer @Override public void prepare(MediaSource mediaSource, boolean resetPosition, boolean resetState) { verifyApplicationThread(); - setMediaSources( - Collections.singletonList(mediaSource), - /* startWindowIndex= */ resetPosition ? 0 : C.INDEX_UNSET, - /* startPositionMs= */ C.TIME_UNSET); + setMediaSources(Collections.singletonList(mediaSource), resetPosition); prepare(); }