From 3110587fbeb526d307724ce21730f3b4bdf9ab7b Mon Sep 17 00:00:00 2001 From: olly Date: Mon, 7 Sep 2020 21:17:29 +0100 Subject: [PATCH] Fix extension renderer test names + add FfmpegVideo case PiperOrigin-RevId: 330409635 --- .../ext/ffmpeg/DefaultRenderersFactoryTest.java | 13 +++++++++++-- .../ext/flac/DefaultRenderersFactoryTest.java | 2 +- .../ext/opus/DefaultRenderersFactoryTest.java | 2 +- 3 files changed, 13 insertions(+), 4 deletions(-) diff --git a/extensions/ffmpeg/src/test/java/com/google/android/exoplayer2/ext/ffmpeg/DefaultRenderersFactoryTest.java b/extensions/ffmpeg/src/test/java/com/google/android/exoplayer2/ext/ffmpeg/DefaultRenderersFactoryTest.java index a52d1b1d7a..cc8ca5487e 100644 --- a/extensions/ffmpeg/src/test/java/com/google/android/exoplayer2/ext/ffmpeg/DefaultRenderersFactoryTest.java +++ b/extensions/ffmpeg/src/test/java/com/google/android/exoplayer2/ext/ffmpeg/DefaultRenderersFactoryTest.java @@ -21,13 +21,22 @@ import com.google.android.exoplayer2.testutil.DefaultRenderersFactoryAsserts; import org.junit.Test; import org.junit.runner.RunWith; -/** Unit test for {@link DefaultRenderersFactoryTest} with {@link FfmpegAudioRenderer}. */ +/** + * Unit test for {@link DefaultRenderersFactoryTest} with {@link FfmpegAudioRenderer} and {@link + * FfmpegVideoRenderer}. + */ @RunWith(AndroidJUnit4.class) public final class DefaultRenderersFactoryTest { @Test - public void createRenderers_instantiatesVpxRenderer() { + public void createRenderers_instantiatesFfmpegAudioRenderer() { DefaultRenderersFactoryAsserts.assertExtensionRendererCreated( FfmpegAudioRenderer.class, C.TRACK_TYPE_AUDIO); } + + @Test + public void createRenderers_instantiatesFfmpegVideoRenderer() { + DefaultRenderersFactoryAsserts.assertExtensionRendererCreated( + FfmpegVideoRenderer.class, C.TRACK_TYPE_VIDEO); + } } diff --git a/extensions/flac/src/test/java/com/google/android/exoplayer2/ext/flac/DefaultRenderersFactoryTest.java b/extensions/flac/src/test/java/com/google/android/exoplayer2/ext/flac/DefaultRenderersFactoryTest.java index fb20ff1114..3fb8f2cece 100644 --- a/extensions/flac/src/test/java/com/google/android/exoplayer2/ext/flac/DefaultRenderersFactoryTest.java +++ b/extensions/flac/src/test/java/com/google/android/exoplayer2/ext/flac/DefaultRenderersFactoryTest.java @@ -26,7 +26,7 @@ import org.junit.runner.RunWith; public final class DefaultRenderersFactoryTest { @Test - public void createRenderers_instantiatesVpxRenderer() { + public void createRenderers_instantiatesFlacRenderer() { DefaultRenderersFactoryAsserts.assertExtensionRendererCreated( LibflacAudioRenderer.class, C.TRACK_TYPE_AUDIO); } diff --git a/extensions/opus/src/test/java/com/google/android/exoplayer2/ext/opus/DefaultRenderersFactoryTest.java b/extensions/opus/src/test/java/com/google/android/exoplayer2/ext/opus/DefaultRenderersFactoryTest.java index e57ad84a41..9931f2d05f 100644 --- a/extensions/opus/src/test/java/com/google/android/exoplayer2/ext/opus/DefaultRenderersFactoryTest.java +++ b/extensions/opus/src/test/java/com/google/android/exoplayer2/ext/opus/DefaultRenderersFactoryTest.java @@ -26,7 +26,7 @@ import org.junit.runner.RunWith; public final class DefaultRenderersFactoryTest { @Test - public void createRenderers_instantiatesVpxRenderer() { + public void createRenderers_instantiatesOpusRenderer() { DefaultRenderersFactoryAsserts.assertExtensionRendererCreated( LibopusAudioRenderer.class, C.TRACK_TYPE_AUDIO); }