sjs/media
1
0
Fork 0
mirror of https://github.com/samsonjs/media.git synced 2026-04-27 15:07:40 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove deprecated constructor in DefaultVideoFrameProcessor.Factory

Browse source 
Remove deprecated factory constructor and replace all call instances of it.

PiperOrigin-RevId: 525476062
This commit is contained in:
tofunmi 2023-04-19 17:54:23 +01:00 committed by Rohit Singh
parent aa0d7d7339
commit 316a2ce0ee
5 changed files with 5 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
libraries/effect/src/androidTest/java/androidx/media3/effect/DefaultVideoFrameProcessorImageFrameOutputTest.java
View file

@ -123,7 +123,7 @@ public class DefaultVideoFrameProcessorImageFrameOutputTest {
String testId) { String testId) {
return new VideoFrameProcessorTestRunner.Builder() return new VideoFrameProcessorTestRunner.Builder()
.setTestId(testId) .setTestId(testId)
.setVideoFrameProcessorFactory(new DefaultVideoFrameProcessor.Factory()) .setVideoFrameProcessorFactory(new DefaultVideoFrameProcessor.Factory.Builder().build())
.setIsInputTextureExternal(false) .setIsInputTextureExternal(false)
.setOnOutputFrameAvailableListener( .setOnOutputFrameAvailableListener(
unused -> checkNotNull(framesProduced).incrementAndGet()); unused -> checkNotNull(framesProduced).incrementAndGet());

2
libraries/effect/src/androidTest/java/androidx/media3/effect/DefaultVideoFrameProcessorPixelTest.java
View file

@ -506,7 +506,7 @@ public final class DefaultVideoFrameProcessorPixelTest {
String testId) { String testId) {
return new VideoFrameProcessorTestRunner.Builder() return new VideoFrameProcessorTestRunner.Builder()
.setTestId(testId) .setTestId(testId)
.setVideoFrameProcessorFactory(new DefaultVideoFrameProcessor.Factory()) .setVideoFrameProcessorFactory(new DefaultVideoFrameProcessor.Factory.Builder().build())
.setVideoAssetPath(INPUT_SDR_MP4_ASSET_STRING); .setVideoAssetPath(INPUT_SDR_MP4_ASSET_STRING);
} }

3
libraries/effect/src/androidTest/java/androidx/media3/effect/DefaultVideoFrameProcessorVideoFrameReleaseTest.java
View file

@ -292,7 +292,8 @@ public final class DefaultVideoFrameProcessorVideoFrameReleaseTest {
CountDownLatch videoFrameProcessingEndedCountDownLatch = new CountDownLatch(1); CountDownLatch videoFrameProcessingEndedCountDownLatch = new CountDownLatch(1);
defaultVideoFrameProcessor = defaultVideoFrameProcessor =
checkNotNull( checkNotNull(
new DefaultVideoFrameProcessor.Factory() new DefaultVideoFrameProcessor.Factory.Builder()
.build()
.create( .create(
getApplicationContext(), getApplicationContext(),
ImmutableList.of((GlEffect) (context, useHdr) -> blankFrameProducer), ImmutableList.of((GlEffect) (context, useHdr) -> blankFrameProducer),

12
libraries/effect/src/main/java/androidx/media3/effect/DefaultVideoFrameProcessor.java
View file

@ -143,18 +143,6 @@ public final class DefaultVideoFrameProcessor implements VideoFrameProcessor {
this.textureOutputListener = textureOutputListener; this.textureOutputListener = textureOutputListener;
} }
// TODO(276913828): Remove and change all calls to a builder.
/**
* @deprecated Use {@link DefaultVideoFrameProcessor.Factory.Builder} instead.
*/
@Deprecated
public Factory() {
this(
/* enableColorTransfers= */ true,
GlObjectsProvider.DEFAULT,
/* textureOutputListener= */ null);
}
/** /**
* {@inheritDoc} * {@inheritDoc}
* *

2
libraries/transformer/src/androidTest/java/androidx/media3/transformer/mh/ToneMapHdrToSdrUsingOpenGlPixelTest.java
View file

@ -213,6 +213,6 @@ public final class ToneMapHdrToSdrUsingOpenGlPixelTest {
String testId) { String testId) {
return new VideoFrameProcessorTestRunner.Builder() return new VideoFrameProcessorTestRunner.Builder()
.setTestId(testId) .setTestId(testId)
.setVideoFrameProcessorFactory(new DefaultVideoFrameProcessor.Factory()); .setVideoFrameProcessorFactory(new DefaultVideoFrameProcessor.Factory.Builder().build());
} }
} }