sjs/media
1
0
Fork 0
mirror of https://github.com/samsonjs/media.git synced 2026-04-27 15:07:40 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix 4 ErrorProneStyle findings:

Browse source 
* Non-standard parameter comment; prefer `/* paramName= */ arg`
  (see http://go/bugpattern/ParameterComment) (2 times)
* This catch block catches an exception and re-throws another, but swallows the caught exception rather than setting it as a cause. This can make debugging harder.
  (see http://go/bugpattern/UnusedException)
* This comment contains Javadoc or HTML tags, but isn't started with a double asterisk (/**); is it meant to be Javadoc?
  (see http://go/bugpattern/AlmostJavadoc)

This CL looks good? Just LGTM and Approve it!
This CL doesn’t look good? This is what you can do:
* Revert this CL, by replying "REVERT: <provide reason>"
* File a bug under go/error-prone-bug for category ErrorProneStyle if there's an issue with the CL content.
* File a bug under go/rosie-bug if there's an issue with how the CL was managed.
* Revert this CL and not get a CL that cleans up these paths in the future by
replying "BLOCKLIST: <provide reason>". This is not reversible! We recommend to
opt out the respective paths in your CL Robot configuration instead:
go/clrobot-opt-out.

This CL was generated by CL Robot - a tool that cleans up code findings
(go/clrobot). The affected code paths have been enabled for CL Robot in //depot/google3/java/com/google/android/libraries/media/METADATA which is reachable following include_presubmits from //depot/google3/third_party/java_src/android_libs/media/METADATA.
Anything wrong with the signup? File a bug at go/clrobot-bug.

#codehealth

Tested:
    Local presubmit tests passed.
PiperOrigin-RevId: 472255768
This commit is contained in:
Googler 2022-09-05 12:19:14 +00:00 committed by Marc Baechinger
parent 573ad66f2f
commit 3a2e0d3717
4 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
libraries/session/src/main/java/androidx/media3/session/MediaControllerImplBase.java
View file

@ -1261,7 +1261,7 @@ import org.checkerframework.checker.nullness.qual.NonNull;
/* ignored */ PLAY_WHEN_READY_CHANGE_REASON_USER_REQUEST, /* ignored */ PLAY_WHEN_READY_CHANGE_REASON_USER_REQUEST,
/* positionDiscontinuity= */ currentItemRemoved, /* positionDiscontinuity= */ currentItemRemoved,
DISCONTINUITY_REASON_REMOVE, DISCONTINUITY_REASON_REMOVE,
/* mediaItemTransition*/ playerInfo.sessionPositionInfo.positionInfo.mediaItemIndex /* mediaItemTransition= */ playerInfo.sessionPositionInfo.positionInfo.mediaItemIndex
>= fromIndex >= fromIndex
&& playerInfo.sessionPositionInfo.positionInfo.mediaItemIndex < clippedToIndex, && playerInfo.sessionPositionInfo.positionInfo.mediaItemIndex < clippedToIndex,
MEDIA_ITEM_TRANSITION_REASON_PLAYLIST_CHANGED); MEDIA_ITEM_TRANSITION_REASON_PLAYLIST_CHANGED);

2
libraries/session/src/main/java/androidx/media3/session/MediaControllerStub.java
View file

@ -183,7 +183,7 @@ import org.checkerframework.checker.nullness.qual.NonNull;
controller -> controller ->
controller.onPlayerInfoChanged( controller.onPlayerInfoChanged(
playerInfo, playerInfo,
/* timelineChangedReason */ Player.TIMELINE_CHANGE_REASON_SOURCE_UPDATE, /* timelineChangedReason= */ Player.TIMELINE_CHANGE_REASON_SOURCE_UPDATE,
isTimelineExcluded)); isTimelineExcluded));
} }

2
libraries/session/src/main/java/androidx/media3/session/MediaUtils.java
View file

@ -320,7 +320,7 @@ import org.checkerframework.checker.nullness.compatqual.NullableType;
return result; return result;
} }
/* Converts a {@link MediaItem} to a {@link MediaDescriptionCompat}. */ /** Converts a {@link MediaItem} to a {@link MediaDescriptionCompat}. */
public static MediaDescriptionCompat convertToMediaDescriptionCompat(MediaItem item) { public static MediaDescriptionCompat convertToMediaDescriptionCompat(MediaItem item) {
MediaDescriptionCompat.Builder builder = MediaDescriptionCompat.Builder builder =
new MediaDescriptionCompat.Builder() new MediaDescriptionCompat.Builder()

2
libraries/session/src/main/java/androidx/media3/session/SessionToken.java
View file

@ -399,7 +399,7 @@ public final class SessionToken implements Bundleable {
try { try {
return manager.getApplicationInfo(packageName, 0).uid; return manager.getApplicationInfo(packageName, 0).uid;
} catch (PackageManager.NameNotFoundException e) { } catch (PackageManager.NameNotFoundException e) {
throw new IllegalArgumentException("Cannot find package " + packageName); throw new IllegalArgumentException("Cannot find package " + packageName, e);
} }
} }