sjs/media
1
0
Fork 0
mirror of https://github.com/samsonjs/media.git synced 2026-04-27 15:07:40 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix Error Prone warning in SubtitleExtractorTest

Browse source 
Also make some casting that is needed a bit safer.

Error Prone was complaining about casting `long` to `int` before passing
it to `Extractor.seek(long, long)`:
> Converting a `long` or `Long` to an `int` to pass as a `long`
> parameter is usually not necessary. If this conversion is intentional,
> consider `Longs.constrainToRange()` instead.

PiperOrigin-RevId: 545226063
This commit is contained in:
ibaker 2023-07-03 15:18:10 +00:00 committed by microkatz
parent 412e9398f9
commit 4ae36cc175
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
libraries/extractor/src/test/java/androidx/media3/extractor/text/SubtitleExtractorTest.java
View file

@ -28,6 +28,7 @@ import androidx.media3.test.utils.FakeExtractorInput;
import androidx.media3.test.utils.FakeExtractorOutput; import androidx.media3.test.utils.FakeExtractorOutput;
import androidx.media3.test.utils.FakeTrackOutput; import androidx.media3.test.utils.FakeTrackOutput;
import androidx.test.ext.junit.runners.AndroidJUnit4; import androidx.test.ext.junit.runners.AndroidJUnit4;
import com.google.common.primitives.Ints;
import java.util.List; import java.util.List;
import org.junit.Test; import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
@ -112,8 +113,8 @@ public class SubtitleExtractorTest {
FakeTrackOutput trackOutput = output.trackOutputs.get(0); FakeTrackOutput trackOutput = output.trackOutputs.get(0);
while (extractor.read(input, null) != Extractor.RESULT_END_OF_INPUT) {} while (extractor.read(input, null) != Extractor.RESULT_END_OF_INPUT) {}
extractor.seek((int) output.seekMap.getSeekPoints(2_445_000L).first.position, 2_445_000L); extractor.seek(output.seekMap.getSeekPoints(2_445_000L).first.position, 2_445_000L);
input.setPosition((int) output.seekMap.getSeekPoints(2_445_000L).first.position); input.setPosition(Ints.checkedCast(output.seekMap.getSeekPoints(2_445_000L).first.position));
trackOutput.clear(); trackOutput.clear();
while (extractor.read(input, null) != Extractor.RESULT_END_OF_INPUT) {} while (extractor.read(input, null) != Extractor.RESULT_END_OF_INPUT) {}
@ -157,8 +158,8 @@ public class SubtitleExtractorTest {
FakeTrackOutput trackOutput = output.trackOutputs.get(0); FakeTrackOutput trackOutput = output.trackOutputs.get(0);
assertThat(extractor.read(input, null)).isNotEqualTo(Extractor.RESULT_END_OF_INPUT); assertThat(extractor.read(input, null)).isNotEqualTo(Extractor.RESULT_END_OF_INPUT);
extractor.seek((int) output.seekMap.getSeekPoints(2_345_000L).first.position, 2_345_000L); extractor.seek(output.seekMap.getSeekPoints(2_345_000L).first.position, 2_345_000L);
input.setPosition((int) output.seekMap.getSeekPoints(2_345_000L).first.position); input.setPosition(Ints.checkedCast(output.seekMap.getSeekPoints(2_345_000L).first.position));
trackOutput.clear(); trackOutput.clear();
while (extractor.read(input, null) != Extractor.RESULT_END_OF_INPUT) {} while (extractor.read(input, null) != Extractor.RESULT_END_OF_INPUT) {}