From 4dc6c85de459c57fc3f04367b2f92fa203050cb7 Mon Sep 17 00:00:00 2001 From: tonihei Date: Tue, 12 Jun 2018 08:15:20 -0700 Subject: [PATCH] Use proper buffered duration in AnalyticsCollector. This replaces the workaround calculation which was needed before the referenced bug was fixed. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=200217241 --- .../android/exoplayer2/analytics/AnalyticsCollector.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/library/core/src/main/java/com/google/android/exoplayer2/analytics/AnalyticsCollector.java b/library/core/src/main/java/com/google/android/exoplayer2/analytics/AnalyticsCollector.java index 795e58ce1d..eab630ff00 100644 --- a/library/core/src/main/java/com/google/android/exoplayer2/analytics/AnalyticsCollector.java +++ b/library/core/src/main/java/com/google/android/exoplayer2/analytics/AnalyticsCollector.java @@ -574,8 +574,6 @@ public class AnalyticsCollector // This event is for content in a future window. Assume default start position. eventPositionMs = timeline.getWindow(windowIndex, window).getDefaultPositionMs(); } - // TODO(b/30792113): implement this properly (player.getTotalBufferedDuration()). - long bufferedDurationMs = player.getBufferedPosition() - player.getContentPosition(); return new EventTime( realtimeMs, timeline, @@ -583,7 +581,7 @@ public class AnalyticsCollector mediaPeriodId, eventPositionMs, player.getCurrentPosition(), - bufferedDurationMs); + player.getTotalBufferedDuration()); } private EventTime generateEventTime(@Nullable WindowAndMediaPeriodId mediaPeriod) {