From 4fcc019bbf1981703cb302cc796b3a9a6845ea89 Mon Sep 17 00:00:00 2001 From: ibaker Date: Thu, 10 Nov 2022 12:21:14 +0000 Subject: [PATCH] Fix parameter name mismatch in MappingTrackSelector.selectTracks It's not clear to me why presubmit didn't catch this, I briefly investigated but couldn't work it out - so I'm just going to fix it and move on. #minor-release PiperOrigin-RevId: 487497827 --- .../media3/exoplayer/trackselection/DefaultTrackSelector.java | 4 ++-- .../media3/exoplayer/trackselection/MappingTrackSelector.java | 2 +- .../exoplayer/trackselection/MappingTrackSelectorTest.java | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/trackselection/DefaultTrackSelector.java b/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/trackselection/DefaultTrackSelector.java index 3a76039b92..54bac6c44c 100644 --- a/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/trackselection/DefaultTrackSelector.java +++ b/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/trackselection/DefaultTrackSelector.java @@ -2392,7 +2392,7 @@ public class DefaultTrackSelector extends MappingTrackSelector { selectTracks( MappedTrackInfo mappedTrackInfo, @Capabilities int[][][] rendererFormatSupports, - @AdaptiveSupport int[] rendererMixedMimeTypeAdaptationSupports, + @AdaptiveSupport int[] rendererMixedMimeTypeAdaptationSupport, MediaPeriodId mediaPeriodId, Timeline timeline) throws ExoPlaybackException { @@ -2412,7 +2412,7 @@ public class DefaultTrackSelector extends MappingTrackSelector { selectAllTracks( mappedTrackInfo, rendererFormatSupports, - rendererMixedMimeTypeAdaptationSupports, + rendererMixedMimeTypeAdaptationSupport, parameters); applyTrackSelectionOverrides(mappedTrackInfo, parameters, definitions); diff --git a/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/trackselection/MappingTrackSelector.java b/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/trackselection/MappingTrackSelector.java index da68e3b673..8f111e73ab 100644 --- a/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/trackselection/MappingTrackSelector.java +++ b/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/trackselection/MappingTrackSelector.java @@ -436,7 +436,7 @@ public abstract class MappingTrackSelector extends TrackSelector { * Given mapped track information, returns a track selection and configuration for each renderer. * * @param mappedTrackInfo Mapped track information. - * @param rendererFormatSupports The {@link Capabilities} for ach mapped track, indexed by + * @param rendererFormatSupports The {@link Capabilities} for each mapped track, indexed by * renderer, track group and track (in that order). * @param rendererMixedMimeTypeAdaptationSupport The {@link AdaptiveSupport} for mixed MIME type * adaptation for the renderer. diff --git a/libraries/exoplayer/src/test/java/androidx/media3/exoplayer/trackselection/MappingTrackSelectorTest.java b/libraries/exoplayer/src/test/java/androidx/media3/exoplayer/trackselection/MappingTrackSelectorTest.java index 2adf524191..6b395cc01f 100644 --- a/libraries/exoplayer/src/test/java/androidx/media3/exoplayer/trackselection/MappingTrackSelectorTest.java +++ b/libraries/exoplayer/src/test/java/androidx/media3/exoplayer/trackselection/MappingTrackSelectorTest.java @@ -147,7 +147,7 @@ public final class MappingTrackSelectorTest { protected Pair selectTracks( MappedTrackInfo mappedTrackInfo, @Capabilities int[][][] rendererFormatSupports, - @AdaptiveSupport int[] rendererMixedMimeTypeAdaptationSupports, + @AdaptiveSupport int[] rendererMixedMimeTypeAdaptationSupport, MediaPeriodId mediaPeriodId, Timeline timeline) { int rendererCount = mappedTrackInfo.getRendererCount();