sjs/media
1
0
Fork 0
mirror of https://github.com/samsonjs/media.git synced 2026-04-10 12:05:47 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Effect: glFlush instead of glFinish on tex output

Browse source 
This is much faster (~2-3x) than glFlush. While there's a risk that GL commands
queued to the GL server may not be complete by the time non-GL commands access
the texture, this should be unlikely as we only access the texture from GL.

PiperOrigin-RevId: 527641520
This commit is contained in:
huangdarwin 2023-04-27 19:48:18 +01:00 committed by Marc Baechinger
parent 655c727043
commit 5c02210305
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
libraries/effect/src/main/java/androidx/media3/effect/FinalShaderProgramWrapper.java
View file

@ -360,7 +360,13 @@ import org.checkerframework.checker.nullness.qual.MonotonicNonNull;
outputTexture.fboId, outputTexture.width, outputTexture.height);
GlUtil.clearOutputFrame();
checkNotNull(defaultShaderProgram).drawFrame(inputTexture.texId, presentationTimeUs);
GLES20.glFinish();
// glFlush is used here instead of glFinish due to the performance regression that blocking this
// thread would do when calling glFinish. As glFlush is non-blocking, it's possible that non-GL
// access to the output texture may read stale data (ex. from the prior frame). If we see issues
// (ex. flakiness) from glFlush, consider requiring apps reading the texture to call glFinish,
// or reconsider using glFinish here.
GLES20.glFlush();
checkNotNull(textureOutputListener).onTextureRendered(outputTexture, presentationTimeUs);
}