From 5e2197d82e5076183732368d9385ab6f71d73e29 Mon Sep 17 00:00:00 2001 From: krocard Date: Tue, 22 Jun 2021 14:30:11 +0100 Subject: [PATCH] Remove extra test checks intended to debug flaky test. Those test are no longer flaky since the test clock was made deterministic. The removed assertions were introduced in https://github.com/google/ExoPlayer/commit/a4ad351fb15b60080ff53b345563e3f922464251. PiperOrigin-RevId: 380793961 --- .../exoplayer2/robolectric/TestPlayerRunHelper.java | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/robolectricutils/src/main/java/com/google/android/exoplayer2/robolectric/TestPlayerRunHelper.java b/robolectricutils/src/main/java/com/google/android/exoplayer2/robolectric/TestPlayerRunHelper.java index 2f477ee7db..50ad8b475c 100644 --- a/robolectricutils/src/main/java/com/google/android/exoplayer2/robolectric/TestPlayerRunHelper.java +++ b/robolectricutils/src/main/java/com/google/android/exoplayer2/robolectric/TestPlayerRunHelper.java @@ -17,7 +17,6 @@ package com.google.android.exoplayer2.robolectric; import static com.google.android.exoplayer2.robolectric.RobolectricUtil.runMainLooperUntil; -import static com.google.common.truth.Truth.assertThat; import android.os.Looper; import com.google.android.exoplayer2.ExoPlaybackException; @@ -263,13 +262,7 @@ public class TestPlayerRunHelper { } }; player.addAudioOffloadListener(listener); - runMainLooperUntil( - () -> { // Make sure progress is being made, see [internal: b/170387438#comment2] - assertThat(player.getPlayerError()).isNull(); - assertThat(player.getPlayWhenReady()).isTrue(); - assertThat(player.getPlaybackState()).isAnyOf(Player.STATE_BUFFERING, Player.STATE_READY); - return receiverCallback.get(); - }); + runMainLooperUntil(receiverCallback::get); } /**