From 61374d16986dc4e3620708accf98b5e3f4dea189 Mon Sep 17 00:00:00 2001 From: Googler Date: Thu, 1 Sep 2022 17:37:30 +0000 Subject: [PATCH] Skip transcoding if HDR video does not need encoding. https://github.com/google/ExoPlayer/commit/3b0d2c15867b3698f130476736785d427b28b7bd made `shouldPassthrough` always return false for `enableHdrVideoEditing`: >We force using `FrameEditor` (no passthrough) to avoid the need to select another edit operation, and use the new shaders. The `EGLContext` and `EGLSurface` also need to be set up differently for this path. However, this was introduced before the `videoNeedsEncoding` setting was introduced in https://github.com/google/ExoPlayer/commit/3f615040c033a37f81b1d73605cd1f7d420b47b5. That setting should apply to HDR videos as much as SDR videos. PiperOrigin-RevId: 471569853 (cherry picked from commit 94713a8ffb6ba4e83a05bb50921b4cf2ab2eab75) --- .../exoplayer2/transformer/TransformerVideoRenderer.java | 3 --- 1 file changed, 3 deletions(-) diff --git a/library/transformer/src/main/java/com/google/android/exoplayer2/transformer/TransformerVideoRenderer.java b/library/transformer/src/main/java/com/google/android/exoplayer2/transformer/TransformerVideoRenderer.java index 1831cf84d4..b1988e1097 100644 --- a/library/transformer/src/main/java/com/google/android/exoplayer2/transformer/TransformerVideoRenderer.java +++ b/library/transformer/src/main/java/com/google/android/exoplayer2/transformer/TransformerVideoRenderer.java @@ -143,9 +143,6 @@ import org.checkerframework.checker.nullness.qual.RequiresNonNull; if (transformationRequest.enableRequestSdrToneMapping) { return false; } - if (transformationRequest.enableHdrEditing) { - return false; - } if (transformationRequest.videoMimeType != null && !transformationRequest.videoMimeType.equals(inputFormat.sampleMimeType)) { return false;