sjs/media
1
0
Fork 0
mirror of https://github.com/samsonjs/media.git synced 2026-04-27 15:07:40 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Test: Suppress SSIM timeouts on galaxy fold/flip.

Browse source 
This is a failure only in SSIM, so it seems unlikely we'll prioritize this over
other work or bugs soon. Suppress test failures to reduce triage burden.

PiperOrigin-RevId: 532200729
This commit is contained in:
huangdarwin 2023-05-15 21:04:56 +01:00 committed by Ian Baker
parent b120ef65ed
commit 62afbe87bb
2 changed files with 18 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
libraries/transformer/src/androidTest/java/androidx/media3/transformer/mh/ExportTest.java
View file

@ -73,8 +73,11 @@ public class ExportTest {
.build(); .build();
MediaItem mediaItem = MediaItem mediaItem =
MediaItem.fromUri(Uri.parse(MP4_ASSET_WITH_INCREASING_TIMESTAMPS_URI_STRING)); MediaItem.fromUri(Uri.parse(MP4_ASSET_WITH_INCREASING_TIMESTAMPS_URI_STRING));
// TODO: b/239983127 - Make requestCalculateSsim always true.
boolean requestCalculateSsim =
!Util.MODEL.equals("SM-F711U1") && !Util.MODEL.equals("SM-F926U1");
new TransformerAndroidTestRunner.Builder(context, transformer) new TransformerAndroidTestRunner.Builder(context, transformer)
.setRequestCalculateSsim(true) .setRequestCalculateSsim(requestCalculateSsim)
.build() .build()
.run(testId, mediaItem); .run(testId, mediaItem);
} }
@ -114,8 +117,11 @@ public class ExportTest {
MediaItem.fromUri(Uri.parse(MP4_ASSET_WITH_INCREASING_TIMESTAMPS_URI_STRING)); MediaItem.fromUri(Uri.parse(MP4_ASSET_WITH_INCREASING_TIMESTAMPS_URI_STRING));
EditedMediaItem editedMediaItem = EditedMediaItem editedMediaItem =
new EditedMediaItem.Builder(mediaItem).setRemoveAudio(true).build(); new EditedMediaItem.Builder(mediaItem).setRemoveAudio(true).build();
// TODO: b/239983127 - Make requestCalculateSsim always true.
boolean requestCalculateSsim =
!Util.MODEL.equals("SM-F711U1") && !Util.MODEL.equals("SM-F926U1");
new TransformerAndroidTestRunner.Builder(context, transformer) new TransformerAndroidTestRunner.Builder(context, transformer)
.setRequestCalculateSsim(true) .setRequestCalculateSsim(requestCalculateSsim)
.build() .build()
.run(testId, editedMediaItem); .run(testId, editedMediaItem);
} }
@ -187,8 +193,11 @@ public class ExportTest {
MediaItem.fromUri(Uri.parse(MP4_ASSET_WITH_INCREASING_TIMESTAMPS_URI_STRING)); MediaItem.fromUri(Uri.parse(MP4_ASSET_WITH_INCREASING_TIMESTAMPS_URI_STRING));
EditedMediaItem editedMediaItem = EditedMediaItem editedMediaItem =
new EditedMediaItem.Builder(mediaItem).setRemoveAudio(true).build(); new EditedMediaItem.Builder(mediaItem).setRemoveAudio(true).build();
// TODO: b/239983127 - Make requestCalculateSsim always true.
boolean requestCalculateSsim =
!Util.MODEL.equals("SM-F711U1") && !Util.MODEL.equals("SM-F926U1");
new TransformerAndroidTestRunner.Builder(context, transformer) new TransformerAndroidTestRunner.Builder(context, transformer)
.setRequestCalculateSsim(true) .setRequestCalculateSsim(requestCalculateSsim)
.build() .build()
.run(testId, editedMediaItem); .run(testId, editedMediaItem);
} }

6
libraries/transformer/src/androidTest/java/androidx/media3/transformer/mh/TranscodeQualityTest.java
View file

@ -17,11 +17,13 @@
package androidx.media3.transformer.mh; package androidx.media3.transformer.mh;
import static com.google.common.truth.Truth.assertThat; import static com.google.common.truth.Truth.assertThat;
import static org.junit.Assume.assumeTrue;
import android.content.Context; import android.content.Context;
import android.net.Uri; import android.net.Uri;
import androidx.media3.common.MediaItem; import androidx.media3.common.MediaItem;
import androidx.media3.common.MimeTypes; import androidx.media3.common.MimeTypes;
import androidx.media3.common.util.Util;
import androidx.media3.transformer.AndroidTestUtil; import androidx.media3.transformer.AndroidTestUtil;
import androidx.media3.transformer.DefaultEncoderFactory; import androidx.media3.transformer.DefaultEncoderFactory;
import androidx.media3.transformer.EditedMediaItem; import androidx.media3.transformer.EditedMediaItem;
@ -51,6 +53,8 @@ public final class TranscodeQualityTest {
/* outputFormat= */ AndroidTestUtil.MP4_ASSET_WITH_INCREASING_TIMESTAMPS_FORMAT)) { /* outputFormat= */ AndroidTestUtil.MP4_ASSET_WITH_INCREASING_TIMESTAMPS_FORMAT)) {
return; return;
} }
// TODO: b/239983127 - Remove this test skip on these devices.
assumeTrue(!Util.MODEL.equals("SM-F711U1") && !Util.MODEL.equals("SM-F926U1"));
Transformer transformer = Transformer transformer =
new Transformer.Builder(context) new Transformer.Builder(context)
@ -96,6 +100,8 @@ public final class TranscodeQualityTest {
.build())) { .build())) {
return; return;
} }
// TODO: b/239983127 - Remove this test skip on these devices.
assumeTrue(!Util.MODEL.equals("SM-F711U1") && !Util.MODEL.equals("SM-F926U1"));
Transformer transformer = Transformer transformer =
new Transformer.Builder(context) new Transformer.Builder(context)