sjs/media
1
0
Fork 0
mirror of https://github.com/samsonjs/media.git synced 2026-03-25 09:25:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix test flakiness

Browse source 
The test currently resets the time too far in the past and then has
to run through ~30000 additional iterations of doSomeWork to reach
the end, sometimes triggering the test timeout.

Fix it by resetting the time to the intended start position when
transitioning items.

PiperOrigin-RevId: 633918706
This commit is contained in:
tonihei 2024-05-15 05:43:16 -07:00 committed by Copybara-Service
parent e4f0ff8177
commit 67554395cb
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
libraries/exoplayer/src/test/java/androidx/media3/exoplayer/ExoPlayerTest.java
View file

@ -11141,7 +11141,7 @@ public class ExoPlayerTest {
@Override
protected void onStreamChanged(
Format[] formats, long startPositionUs, long offsetUs, MediaPeriodId mediaPeriodId) {
this.positionUs = offsetUs;
this.positionUs = startPositionUs;
}
@Override
@ -14688,22 +14688,22 @@ public class ExoPlayerTest {
AdPlaybackState.NONE));
FakeMediaClockRenderer audioRenderer =
new FakeMediaClockRenderer(C.TRACK_TYPE_AUDIO) {
private long offsetUs;
private long startPositionUs;
private long positionUs;
private boolean hasPendingReportedSkippedSilence;
@Override
protected void onStreamChanged(
Format[] formats, long startPositionUs, long offsetUs, MediaPeriodId mediaPeriodId) {
this.offsetUs = offsetUs;
this.positionUs = offsetUs;
this.startPositionUs = startPositionUs;
this.positionUs = startPositionUs;
}
@Override
public long getPositionUs() {
// Continuously increase position to let playback progress, and simulate the silence
// skip until it reaches some points of time.
if (positionUs - offsetUs == 10_000) {
if (positionUs - startPositionUs == 10_000) {
hasPendingReportedSkippedSilence = true;
positionUs += 30_000;
} else {
@ -14758,7 +14758,7 @@ public class ExoPlayerTest {
@Override
protected void onStreamChanged(
Format[] formats, long startPositionUs, long offsetUs, MediaPeriodId mediaPeriodId) {
positionUs = offsetUs;
positionUs = startPositionUs;
}
@Override
@ -14770,7 +14770,7 @@ public class ExoPlayerTest {
@Override
public boolean hasSkippedSilenceSinceLastCall() {
// Contuniuosly report skipped silences to ensure they will overlap with other
// Continuously report skipped silences to ensure they will overlap with other
// discontinuities like AUTO_TRANSITION.
return true;
}