From 67f8fbf3bd100edf94002f8f39bf589a2fe79382 Mon Sep 17 00:00:00 2001 From: Googler Date: Thu, 23 Mar 2023 16:47:25 +0000 Subject: [PATCH] [Media3][Shader] Reset the composite RGB matrix upon update Since the composite matrix is ultimately rewritten to, we need to ensure it's cleared (to identity) before update. Test plan: use an effect as a time based approach and see that the effect no longer clips PiperOrigin-RevId: 518886623 --- .../main/java/androidx/media3/effect/DefaultShaderProgram.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libraries/effect/src/main/java/androidx/media3/effect/DefaultShaderProgram.java b/libraries/effect/src/main/java/androidx/media3/effect/DefaultShaderProgram.java index 53b0c4235a..56200e80a2 100644 --- a/libraries/effect/src/main/java/androidx/media3/effect/DefaultShaderProgram.java +++ b/libraries/effect/src/main/java/androidx/media3/effect/DefaultShaderProgram.java @@ -537,6 +537,8 @@ import java.util.List; return; } + GlUtil.setToIdentity(compositeRgbMatrixArray); + for (int i = 0; i < rgbMatrices.size(); i++) { Matrix.multiplyMM( /* result= */ tempResultMatrix,