mirror of
https://github.com/samsonjs/media.git
synced 2026-04-12 12:25:47 +00:00
Remove @NonNull where it's implied by @NonNullApi
Also remove it from all tests, these aren't covered by the null-checker Covered by the following package-info.java files: - j/c/g/a/exoplayer2/ext/mediasession/package-info.java - j/c/g/a/exoplayer2/package-info.java - j/c/g/a/exoplayer2/offline/package-info.java - j/c/g/a/exoplayer2/video/package-info.java - j/c/g/a/exoplayer2/ui/package-info.java PiperOrigin-RevId: 277038916
This commit is contained in:
parent
b68a698806
commit
7277df3547
9 changed files with 28 additions and 38 deletions
|
|
@ -31,7 +31,6 @@ import android.support.v4.media.session.MediaSessionCompat;
|
|||
import android.support.v4.media.session.PlaybackStateCompat;
|
||||
import android.util.Pair;
|
||||
import androidx.annotation.LongDef;
|
||||
import androidx.annotation.NonNull;
|
||||
import androidx.annotation.Nullable;
|
||||
import com.google.android.exoplayer2.C;
|
||||
import com.google.android.exoplayer2.ControlDispatcher;
|
||||
|
|
@ -1225,7 +1224,7 @@ public final class MediaSessionConnector {
|
|||
}
|
||||
|
||||
@Override
|
||||
public void onCustomAction(@NonNull String action, @Nullable Bundle extras) {
|
||||
public void onCustomAction(String action, @Nullable Bundle extras) {
|
||||
if (player != null && customActionMap.containsKey(action)) {
|
||||
customActionMap.get(action).onCustomAction(player, controlDispatcher, action, extras);
|
||||
invalidateMediaSessionPlaybackState();
|
||||
|
|
|
|||
|
|
@ -20,7 +20,6 @@ import android.os.ResultReceiver;
|
|||
import android.support.v4.media.MediaDescriptionCompat;
|
||||
import android.support.v4.media.session.MediaControllerCompat;
|
||||
import android.support.v4.media.session.MediaSessionCompat;
|
||||
import androidx.annotation.NonNull;
|
||||
import androidx.annotation.Nullable;
|
||||
import com.google.android.exoplayer2.C;
|
||||
import com.google.android.exoplayer2.ControlDispatcher;
|
||||
|
|
@ -129,10 +128,10 @@ public final class TimelineQueueEditor
|
|||
* @param sourceFactory The {@link MediaSourceFactory} to build media sources.
|
||||
*/
|
||||
public TimelineQueueEditor(
|
||||
@NonNull MediaControllerCompat mediaController,
|
||||
@NonNull ConcatenatingMediaSource queueMediaSource,
|
||||
@NonNull QueueDataAdapter queueDataAdapter,
|
||||
@NonNull MediaSourceFactory sourceFactory) {
|
||||
MediaControllerCompat mediaController,
|
||||
ConcatenatingMediaSource queueMediaSource,
|
||||
QueueDataAdapter queueDataAdapter,
|
||||
MediaSourceFactory sourceFactory) {
|
||||
this(mediaController, queueMediaSource, queueDataAdapter, sourceFactory,
|
||||
new MediaIdEqualityChecker());
|
||||
}
|
||||
|
|
@ -147,11 +146,11 @@ public final class TimelineQueueEditor
|
|||
* @param equalityChecker The {@link MediaDescriptionEqualityChecker} to match queue items.
|
||||
*/
|
||||
public TimelineQueueEditor(
|
||||
@NonNull MediaControllerCompat mediaController,
|
||||
@NonNull ConcatenatingMediaSource queueMediaSource,
|
||||
@NonNull QueueDataAdapter queueDataAdapter,
|
||||
@NonNull MediaSourceFactory sourceFactory,
|
||||
@NonNull MediaDescriptionEqualityChecker equalityChecker) {
|
||||
MediaControllerCompat mediaController,
|
||||
ConcatenatingMediaSource queueMediaSource,
|
||||
QueueDataAdapter queueDataAdapter,
|
||||
MediaSourceFactory sourceFactory,
|
||||
MediaDescriptionEqualityChecker equalityChecker) {
|
||||
this.mediaController = mediaController;
|
||||
this.queueMediaSource = queueMediaSource;
|
||||
this.queueDataAdapter = queueDataAdapter;
|
||||
|
|
|
|||
|
|
@ -26,7 +26,6 @@ import android.database.Cursor;
|
|||
import android.net.Uri;
|
||||
import android.os.Bundle;
|
||||
import android.os.ParcelFileDescriptor;
|
||||
import androidx.annotation.NonNull;
|
||||
import androidx.annotation.Nullable;
|
||||
import androidx.test.InstrumentationRegistry;
|
||||
import androidx.test.ext.junit.runners.AndroidJUnit4;
|
||||
|
|
@ -134,14 +133,13 @@ public final class ContentDataSourceTest {
|
|||
}
|
||||
|
||||
@Override
|
||||
public Cursor query(@NonNull Uri uri, String[] projection, String selection,
|
||||
String[] selectionArgs, String sortOrder) {
|
||||
public Cursor query(
|
||||
Uri uri, String[] projection, String selection, String[] selectionArgs, String sortOrder) {
|
||||
throw new UnsupportedOperationException();
|
||||
}
|
||||
|
||||
@Override
|
||||
public AssetFileDescriptor openAssetFile(@NonNull Uri uri, @NonNull String mode)
|
||||
throws FileNotFoundException {
|
||||
public AssetFileDescriptor openAssetFile(Uri uri, String mode) throws FileNotFoundException {
|
||||
if (uri.getPath() == null) {
|
||||
return null;
|
||||
}
|
||||
|
|
@ -162,29 +160,32 @@ public final class ContentDataSourceTest {
|
|||
}
|
||||
|
||||
@Override
|
||||
public String getType(@NonNull Uri uri) {
|
||||
public String getType(Uri uri) {
|
||||
throw new UnsupportedOperationException();
|
||||
}
|
||||
|
||||
@Override
|
||||
public Uri insert(@NonNull Uri uri, ContentValues values) {
|
||||
public Uri insert(Uri uri, ContentValues values) {
|
||||
throw new UnsupportedOperationException();
|
||||
}
|
||||
|
||||
@Override
|
||||
public int delete(@NonNull Uri uri, String selection, String[] selectionArgs) {
|
||||
public int delete(Uri uri, String selection, String[] selectionArgs) {
|
||||
throw new UnsupportedOperationException();
|
||||
}
|
||||
|
||||
@Override
|
||||
public int update(@NonNull Uri uri, ContentValues values, String selection,
|
||||
String[] selectionArgs) {
|
||||
public int update(Uri uri, ContentValues values, String selection, String[] selectionArgs) {
|
||||
throw new UnsupportedOperationException();
|
||||
}
|
||||
|
||||
@Override
|
||||
public void writeDataToPipe(@NonNull ParcelFileDescriptor output, @NonNull Uri uri,
|
||||
@NonNull String mimeType, @Nullable Bundle opts, @Nullable Object args) {
|
||||
public void writeDataToPipe(
|
||||
ParcelFileDescriptor output,
|
||||
Uri uri,
|
||||
String mimeType,
|
||||
@Nullable Bundle opts,
|
||||
@Nullable Object args) {
|
||||
try {
|
||||
byte[] data = TestUtil.getByteArray(getContext(), getFileName(uri));
|
||||
FileOutputStream outputStream = new FileOutputStream(output.getFileDescriptor());
|
||||
|
|
|
|||
|
|
@ -22,7 +22,6 @@ import android.os.Message;
|
|||
import android.os.Process;
|
||||
import android.os.SystemClock;
|
||||
import android.util.Pair;
|
||||
import androidx.annotation.NonNull;
|
||||
import androidx.annotation.Nullable;
|
||||
import com.google.android.exoplayer2.DefaultMediaClock.PlaybackParameterListener;
|
||||
import com.google.android.exoplayer2.Player.DiscontinuityReason;
|
||||
|
|
@ -1964,7 +1963,7 @@ import java.util.concurrent.atomic.AtomicBoolean;
|
|||
}
|
||||
|
||||
@Override
|
||||
public int compareTo(@NonNull PendingMessageInfo other) {
|
||||
public int compareTo(PendingMessageInfo other) {
|
||||
if ((resolvedPeriodUid == null) != (other.resolvedPeriodUid == null)) {
|
||||
// PendingMessageInfos with a resolved period position are always smaller.
|
||||
return resolvedPeriodUid != null ? -1 : 1;
|
||||
|
|
|
|||
|
|
@ -17,7 +17,6 @@ package com.google.android.exoplayer2.offline;
|
|||
|
||||
import android.net.Uri;
|
||||
import android.util.Pair;
|
||||
import androidx.annotation.NonNull;
|
||||
import androidx.annotation.Nullable;
|
||||
import com.google.android.exoplayer2.C;
|
||||
import com.google.android.exoplayer2.upstream.DataSource;
|
||||
|
|
@ -57,7 +56,7 @@ public abstract class SegmentDownloader<M extends FilterableManifest<M>> impleme
|
|||
}
|
||||
|
||||
@Override
|
||||
public int compareTo(@NonNull Segment other) {
|
||||
public int compareTo(Segment other) {
|
||||
return Util.compareLong(startTimeUs, other.startTimeUs);
|
||||
}
|
||||
}
|
||||
|
|
|
|||
|
|
@ -17,7 +17,6 @@ package com.google.android.exoplayer2.offline;
|
|||
|
||||
import android.os.Parcel;
|
||||
import android.os.Parcelable;
|
||||
import androidx.annotation.NonNull;
|
||||
import androidx.annotation.Nullable;
|
||||
|
||||
/**
|
||||
|
|
@ -92,7 +91,7 @@ public final class StreamKey implements Comparable<StreamKey>, Parcelable {
|
|||
// Comparable implementation.
|
||||
|
||||
@Override
|
||||
public int compareTo(@NonNull StreamKey o) {
|
||||
public int compareTo(StreamKey o) {
|
||||
int result = periodIndex - o.periodIndex;
|
||||
if (result == 0) {
|
||||
result = groupIndex - o.groupIndex;
|
||||
|
|
|
|||
|
|
@ -30,7 +30,6 @@ import android.os.SystemClock;
|
|||
import android.util.Pair;
|
||||
import android.view.Surface;
|
||||
import androidx.annotation.CallSuper;
|
||||
import androidx.annotation.NonNull;
|
||||
import androidx.annotation.Nullable;
|
||||
import com.google.android.exoplayer2.C;
|
||||
import com.google.android.exoplayer2.ExoPlaybackException;
|
||||
|
|
@ -1746,7 +1745,7 @@ public class MediaCodecVideoRenderer extends MediaCodecRenderer {
|
|||
}
|
||||
|
||||
@Override
|
||||
public void onFrameRendered(@NonNull MediaCodec codec, long presentationTimeUs, long nanoTime) {
|
||||
public void onFrameRendered(MediaCodec codec, long presentationTimeUs, long nanoTime) {
|
||||
if (this != tunnelingOnFrameRenderedListener) {
|
||||
// Stale event.
|
||||
return;
|
||||
|
|
|
|||
|
|
@ -22,7 +22,6 @@ import static com.google.android.exoplayer2.extractor.amr.AmrExtractor.frameSize
|
|||
import static com.google.common.truth.Truth.assertThat;
|
||||
import static junit.framework.Assert.fail;
|
||||
|
||||
import androidx.annotation.NonNull;
|
||||
import androidx.test.ext.junit.runners.AndroidJUnit4;
|
||||
import com.google.android.exoplayer2.ParserException;
|
||||
import com.google.android.exoplayer2.extractor.Extractor;
|
||||
|
|
@ -235,7 +234,6 @@ public final class AmrExtractorTest {
|
|||
return result;
|
||||
}
|
||||
|
||||
@NonNull
|
||||
private static AmrExtractor setupAmrExtractorWithOutput() {
|
||||
AmrExtractor amrExtractor = new AmrExtractor();
|
||||
FakeExtractorOutput output = new FakeExtractorOutput();
|
||||
|
|
@ -243,12 +241,10 @@ public final class AmrExtractorTest {
|
|||
return amrExtractor;
|
||||
}
|
||||
|
||||
@NonNull
|
||||
private static FakeExtractorInput fakeExtractorInputWithData(byte[] data) {
|
||||
return new FakeExtractorInput.Builder().setData(data).build();
|
||||
}
|
||||
|
||||
@NonNull
|
||||
private static ExtractorAsserts.ExtractorFactory createAmrExtractorFactory(boolean withSeeking) {
|
||||
return () -> {
|
||||
if (!withSeeking) {
|
||||
|
|
|
|||
|
|
@ -17,7 +17,6 @@ package com.google.android.exoplayer2.ui;
|
|||
|
||||
import android.content.Context;
|
||||
import android.util.AttributeSet;
|
||||
import androidx.annotation.NonNull;
|
||||
import androidx.annotation.Nullable;
|
||||
import com.google.android.exoplayer2.Player;
|
||||
import com.google.android.exoplayer2.SimpleExoPlayer;
|
||||
|
|
@ -49,7 +48,7 @@ public final class SimpleExoPlayerView extends PlayerView {
|
|||
@Deprecated
|
||||
@SuppressWarnings("deprecation")
|
||||
public static void switchTargetView(
|
||||
@NonNull SimpleExoPlayer player,
|
||||
SimpleExoPlayer player,
|
||||
@Nullable SimpleExoPlayerView oldPlayerView,
|
||||
@Nullable SimpleExoPlayerView newPlayerView) {
|
||||
PlayerView.switchTargetView(player, oldPlayerView, newPlayerView);
|
||||
|
|
|
|||
Loading…
Reference in a new issue