sjs/media
1
0
Fork 0
mirror of https://github.com/samsonjs/media.git synced 2026-04-27 15:07:40 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Split MediaItemTest#setSubtitles into two tests

Browse source 
Each test exercises one of the setters. Together they assert that both
setters set both fields.

PiperOrigin-RevId: 408309207
This commit is contained in:
ibaker 2021-11-08 12:41:43 +00:00 committed by Ian Baker
parent fc7b66706f
commit 77c5bc8e31
1 changed files with 23 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
libraries/common/src/test/java/androidx/media3/common/MediaItemTest.java
View file

@ -266,8 +266,8 @@ public class MediaItemTest {
} }
@Test @Test
@SuppressWarnings("deprecation") // Using deprecated Subtitle type @SuppressWarnings("deprecation") // Reading deprecated subtitles field
public void builderSetSubtitles_setsSubtitles() { public void builderSetSubtitleConfigurations() {
List<MediaItem.SubtitleConfiguration> subtitleConfigurations = List<MediaItem.SubtitleConfiguration> subtitleConfigurations =
ImmutableList.of( ImmutableList.of(
new MediaItem.SubtitleConfiguration.Builder(Uri.parse(URI_STRING + "/es")) new MediaItem.SubtitleConfiguration.Builder(Uri.parse(URI_STRING + "/es"))
@ -276,7 +276,24 @@ public class MediaItemTest {
.setSelectionFlags(C.SELECTION_FLAG_FORCED) .setSelectionFlags(C.SELECTION_FLAG_FORCED)
.setRoleFlags(C.ROLE_FLAG_ALTERNATE) .setRoleFlags(C.ROLE_FLAG_ALTERNATE)
.setLabel("label") .setLabel("label")
.build(), .build());
MediaItem mediaItem =
new MediaItem.Builder()
.setUri(URI_STRING)
.setSubtitleConfigurations(subtitleConfigurations)
.build();
assertThat(mediaItem.localConfiguration.subtitleConfigurations)
.isEqualTo(subtitleConfigurations);
assertThat(mediaItem.localConfiguration.subtitles).isEqualTo(subtitleConfigurations);
}
@Test
@SuppressWarnings("deprecation") // Using deprecated Subtitle type
public void builderSetSubtitles() {
List<MediaItem.Subtitle> subtitles =
ImmutableList.of(
new MediaItem.Subtitle( new MediaItem.Subtitle(
Uri.parse(URI_STRING + "/en"), MimeTypes.APPLICATION_TTML, /* language= */ "en"), Uri.parse(URI_STRING + "/en"), MimeTypes.APPLICATION_TTML, /* language= */ "en"),
new MediaItem.Subtitle( new MediaItem.Subtitle(
@ -293,14 +310,10 @@ public class MediaItemTest {
"label")); "label"));
MediaItem mediaItem = MediaItem mediaItem =
new MediaItem.Builder() new MediaItem.Builder().setUri(URI_STRING).setSubtitles(subtitles).build();
.setUri(URI_STRING)
.setSubtitleConfigurations(subtitleConfigurations)
.build();
assertThat(mediaItem.localConfiguration.subtitleConfigurations) assertThat(mediaItem.localConfiguration.subtitleConfigurations).isEqualTo(subtitles);
.isEqualTo(subtitleConfigurations); assertThat(mediaItem.localConfiguration.subtitles).isEqualTo(subtitles);
assertThat(mediaItem.localConfiguration.subtitles).isEqualTo(subtitleConfigurations);
} }
@Test @Test