From 7a2eaa96a23d883ff6894d892fff2b8752652e2d Mon Sep 17 00:00:00 2001 From: ibaker Date: Tue, 20 Apr 2021 18:26:59 +0100 Subject: [PATCH] Mark AdaptiveTrackSelection.AdaptationCheckpoint as public The protected visibility causes problems in Kotlin (Issue: #8830) and also prevents a subclass of AdaptiveTrackSelection.Factory that isn't nested inside a subclass of AdaptiveTrackSelection (in both Java and Kotlin). #minor-release PiperOrigin-RevId: 369468841 --- RELEASENOTES.md | 4 ++++ .../exoplayer2/trackselection/AdaptiveTrackSelection.java | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/RELEASENOTES.md b/RELEASENOTES.md index 8aa6aabcca..541132726f 100644 --- a/RELEASENOTES.md +++ b/RELEASENOTES.md @@ -42,6 +42,10 @@ get notified after MediaCodec is initialized, or they can inject a custom `MediaCodecAdapter.Factory` if they want to control how the `MediaCodec` is configured. + * Promote `AdaptiveTrackSelection.AdaptationCheckpoint` to `public` + visibility in order to allow Kotlin subclasses of + `AdaptiveTrackSelection.Factory` + ([#8830](https://github.com/google/ExoPlayer/issues/8830)). * UI: * Add builder for `PlayerNotificationManager`. * Add group setting to `PlayerNotificationManager`. diff --git a/library/core/src/main/java/com/google/android/exoplayer2/trackselection/AdaptiveTrackSelection.java b/library/core/src/main/java/com/google/android/exoplayer2/trackselection/AdaptiveTrackSelection.java index cef8f7fa64..6dc3b2f636 100644 --- a/library/core/src/main/java/com/google/android/exoplayer2/trackselection/AdaptiveTrackSelection.java +++ b/library/core/src/main/java/com/google/android/exoplayer2/trackselection/AdaptiveTrackSelection.java @@ -697,7 +697,7 @@ public class AdaptiveTrackSelection extends BaseTrackSelection { } /** Checkpoint to determine allocated bandwidth. */ - protected static final class AdaptationCheckpoint { + public static final class AdaptationCheckpoint { /** Total bandwidth in bits per second at which this checkpoint applies. */ public final long totalBandwidth;