sjs/media
1
0
Fork 0
mirror of https://github.com/samsonjs/media.git synced 2026-03-28 09:55:48 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Split a few assertThat(a && b).isTrue() calls into separate assertions for more precise diagnostics.

Browse source
This commit is contained in:
Adam Richter 2019-05-15 13:44:26 -07:00
parent 59b2dd2701
commit 7f79db0724
3 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
library/core/src/test/java/com/google/android/exoplayer2/source/ShuffleOrderTest.java
View file

@ -123,7 +123,8 @@ public final class ShuffleOrderTest {
assertThat(shuffleOrder.getLastIndex()).isEqualTo(indices[length - 1]);
assertThat(shuffleOrder.getNextIndex(indices[length - 1])).isEqualTo(INDEX_UNSET);
for (int i = 0; i < length; i++) {
assertThat(indices[i] >= 0 && indices[i] < length).isTrue();
assertThat(indices[i] >= 0).isTrue();
assertThat(indices[i] < length).isTrue();
}
}
}

3
library/core/src/test/java/com/google/android/exoplayer2/upstream/DataSourceInputStreamTest.java
View file

@ -40,7 +40,8 @@ public final class DataSourceInputStreamTest {
// Read bytes.
for (int i = 0; i < TEST_DATA.length; i++) {
int readByte = inputStream.read();
assertThat(0 <= readByte && readByte < 256).isTrue();
assertThat(0 <= readByte).isTrue();
assertThat(readByte < 256).isTrue();
assertThat(readByte).isEqualTo(TEST_DATA[i] & 0xFF);
assertThat(inputStream.bytesRead()).isEqualTo(i + 1);
}

3
testutils/src/main/java/com/google/android/exoplayer2/testutil/FakeExtractorInput.java
View file

@ -86,7 +86,8 @@ public final class FakeExtractorInput implements ExtractorInput {
* @param position The position to set.
*/
public void setPosition(int position) {
assertThat(0 <= position && position <= data.length).isTrue();
assertThat(0 <= position).isTrue();
assertThat(position <= data.length).isTrue();
readPosition = position;
peekPosition = position;
}