sjs/media
1
0
Fork 0
mirror of https://github.com/samsonjs/media.git synced 2026-04-27 15:07:40 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix catch type in ImaAdsLoader defensive checks

Browse source 
PiperOrigin-RevId: 316079131
This commit is contained in:
andrewlewis 2020-06-12 11:37:50 +01:00 committed by Oliver Woodman
parent e261b8d0ef
commit 8ab3fab4c1
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
extensions/ima/src/main/java/com/google/android/exoplayer2/ext/ima/ImaAdsLoader.java
View file

@ -715,7 +715,7 @@ public final class ImaAdsLoader
} }
try { try {
handleAdPrepareError(adGroupIndex, adIndexInAdGroup, exception); handleAdPrepareError(adGroupIndex, adIndexInAdGroup, exception);
} catch (Exception e) { } catch (RuntimeException e) {
maybeNotifyInternalError("handlePrepareError", e); maybeNotifyInternalError("handlePrepareError", e);
} }
} }
@ -742,7 +742,7 @@ public final class ImaAdsLoader
adPlaybackState = new AdPlaybackState(getAdGroupTimesUs(adsManager.getAdCuePoints())); adPlaybackState = new AdPlaybackState(getAdGroupTimesUs(adsManager.getAdCuePoints()));
hasAdPlaybackState = true; hasAdPlaybackState = true;
updateAdPlaybackState(); updateAdPlaybackState();
} catch (Exception e) { } catch (RuntimeException e) {
maybeNotifyInternalError("onAdsManagerLoaded", e); maybeNotifyInternalError("onAdsManagerLoaded", e);
} }
} }
@ -762,7 +762,7 @@ public final class ImaAdsLoader
} }
try { try {
handleAdEvent(adEvent); handleAdEvent(adEvent);
} catch (Exception e) { } catch (RuntimeException e) {
maybeNotifyInternalError("onAdEvent", e); maybeNotifyInternalError("onAdEvent", e);
} }
} }
@ -784,7 +784,7 @@ public final class ImaAdsLoader
} else if (isAdGroupLoadError(error)) { } else if (isAdGroupLoadError(error)) {
try { try {
handleAdGroupLoadError(error); handleAdGroupLoadError(error);
} catch (Exception e) { } catch (RuntimeException e) {
maybeNotifyInternalError("onAdError", e); maybeNotifyInternalError("onAdError", e);
} }
} }
@ -885,7 +885,7 @@ public final class ImaAdsLoader
adPlaybackState = adPlaybackState =
adPlaybackState.withAdUri(adInfo.adGroupIndex, adInfo.adIndexInAdGroup, adUri); adPlaybackState.withAdUri(adInfo.adGroupIndex, adInfo.adIndexInAdGroup, adUri);
updateAdPlaybackState(); updateAdPlaybackState();
} catch (Exception e) { } catch (RuntimeException e) {
maybeNotifyInternalError("loadAd", e); maybeNotifyInternalError("loadAd", e);
} }
} }
@ -959,7 +959,7 @@ public final class ImaAdsLoader
Assertions.checkState(imaAdState != IMA_AD_STATE_NONE); Assertions.checkState(imaAdState != IMA_AD_STATE_NONE);
try { try {
stopAdInternal(); stopAdInternal();
} catch (Exception e) { } catch (RuntimeException e) {
maybeNotifyInternalError("stopAd", e); maybeNotifyInternalError("stopAd", e);
} }
} }