sjs/media
1
0
Fork 0
mirror of https://github.com/samsonjs/media.git synced 2026-04-27 15:07:40 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Update AudioListener to reflect new audio session ID logic

Browse source 
PiperOrigin-RevId: 351597144
This commit is contained in:
olly 2021-01-13 17:00:42 +00:00 committed by Ian Baker
parent 73114e3987
commit 9198dd6f5a
4 changed files with 10 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
RELEASENOTES.md
View file

@ -136,6 +136,11 @@
which can be immediately queried by calling which can be immediately queried by calling
`SimpleExoPlayer.getAudioSessionId`. The audio session ID will only `SimpleExoPlayer.getAudioSessionId`. The audio session ID will only
change if application code calls `SimpleExoPlayer.setAudioSessionId`. change if application code calls `SimpleExoPlayer.setAudioSessionId`.
* `AudioListener.onAudioSessionId` is replaced with
`AudioListener.onAudioSessionIdChanged`. Note that
`onAudioSessionIdChanged` is called in fewer cases than
`onAudioSessionId` was called, due to the improved handling of audio
session IDs as described above.
* Text: * Text:
* Gracefully handle null-terminated subtitle content in Matroska * Gracefully handle null-terminated subtitle content in Matroska
containers. containers.

6
library/common/src/main/java/com/google/android/exoplayer2/audio/AudioListener.java
View file

@ -19,11 +19,11 @@ package com.google.android.exoplayer2.audio;
public interface AudioListener { public interface AudioListener {
/** /**
* Called when the audio session is set. * Called when the audio session ID changes.
* *
* @param audioSessionId The audio session id. * @param audioSessionId The audio session ID.
*/ */
default void onAudioSessionId(int audioSessionId) {} default void onAudioSessionIdChanged(int audioSessionId) {}
/** /**
* Called when the audio attributes change. * Called when the audio attributes change.

2
library/core/src/main/java/com/google/android/exoplayer2/SimpleExoPlayer.java
View file

@ -983,7 +983,7 @@ public class SimpleExoPlayer extends BasePlayer
sendRendererMessage(C.TRACK_TYPE_AUDIO, Renderer.MSG_SET_AUDIO_SESSION_ID, audioSessionId); sendRendererMessage(C.TRACK_TYPE_AUDIO, Renderer.MSG_SET_AUDIO_SESSION_ID, audioSessionId);
sendRendererMessage(C.TRACK_TYPE_VIDEO, Renderer.MSG_SET_AUDIO_SESSION_ID, audioSessionId); sendRendererMessage(C.TRACK_TYPE_VIDEO, Renderer.MSG_SET_AUDIO_SESSION_ID, audioSessionId);
for (AudioListener audioListener : audioListeners) { for (AudioListener audioListener : audioListeners) {
audioListener.onAudioSessionId(audioSessionId); audioListener.onAudioSessionIdChanged(audioSessionId);
} }
} }

2
library/core/src/main/java/com/google/android/exoplayer2/analytics/AnalyticsCollector.java
View file

@ -300,7 +300,7 @@ public class AnalyticsCollector
// AudioListener implementation. // AudioListener implementation.
@Override @Override
public final void onAudioSessionId(int audioSessionId) { public final void onAudioSessionIdChanged(int audioSessionId) {
EventTime eventTime = generateReadingMediaPeriodEventTime(); EventTime eventTime = generateReadingMediaPeriodEventTime();
sendEvent( sendEvent(
eventTime, eventTime,