sjs/media
1
0
Fork 0
mirror of https://github.com/samsonjs/media.git synced 2026-04-24 14:37:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove unncessary TODOs

Browse source 
PiperOrigin-RevId: 323286632
This commit is contained in:
jaewan 2020-07-27 03:34:09 +01:00 committed by Oliver Woodman
parent 5fa7b879a2
commit 9743e47f1f
3 changed files with 0 additions and 36 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
extensions/media2/src/androidTest/java/com/google/android/exoplayer2/ext/media2/SessionCallbackBuilderTest.java
View file

@ -23,7 +23,6 @@ import static com.google.common.truth.Truth.assertWithMessage;
import android.content.Context;
import android.net.Uri;
import android.os.Bundle;
import android.os.Looper;
import android.text.TextUtils;
import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
@ -79,11 +78,6 @@ public class SessionCallbackBuilderTest {
@Before
public void setUp() {
// Workaround to instantiate MediaSession with public androidx.media dependency.
// TODO(jaewan): Remove this workaround when androidx.media 1.2.0 is released.
if (Looper.myLooper() == null) {
Looper.prepare();
}
context = ApplicationProvider.getApplicationContext();
executor = playerTestRule.getExecutor();
sessionPlayerConnector = playerTestRule.getSessionPlayerConnector();

29
extensions/media2/src/androidTest/java/com/google/android/exoplayer2/ext/media2/SessionPlayerConnectorTest.java
View file

@ -64,7 +64,6 @@ import java.util.concurrent.Executor;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicLong;
import org.junit.Before;
import org.junit.Ignore;
import org.junit.Rule;
import org.junit.Test;
import org.junit.runner.RunWith;
@ -959,34 +958,6 @@ public class SessionPlayerConnectorTest {
assertThat(onPlaylistChangedLatch.getCount()).isEqualTo(1);
}
@Test
@LargeTest
@Ignore("setMediaItem() is currently implemented with setPlaylist(), so list isn't empty.")
@SdkSuppress(minSdkVersion = Build.VERSION_CODES.KITKAT)
public void setMediaItem_afterSettingPlaylist_notifiesOnPlaylistChangedWithNullList()
throws Exception {
List<MediaItem> playlist = TestUtils.createPlaylist(context, /* size= */ 10);
CountDownLatch onPlaylistBecomesNullLatch = new CountDownLatch(1);
sessionPlayerConnector.registerPlayerCallback(
executor,
new SessionPlayer.PlayerCallback() {
@Override
public void onPlaylistChanged(
@NonNull SessionPlayer player,
@Nullable List<MediaItem> list,
@Nullable MediaMetadata metadata) {
if (list == null) {
onPlaylistBecomesNullLatch.countDown();
}
}
});
sessionPlayerConnector.setPlaylist(playlist, /* metadata= */ null);
sessionPlayerConnector.setMediaItem(playlist.get(0));
assertThat(
onPlaylistBecomesNullLatch.await(PLAYLIST_CHANGE_WAIT_TIME_MS, TimeUnit.MILLISECONDS))
.isTrue();
}
@Test
@LargeTest
@SdkSuppress(minSdkVersion = Build.VERSION_CODES.KITKAT)

1
extensions/media2/src/main/java/com/google/android/exoplayer2/ext/media2/TimelinePlaylistManager.java
View file

@ -218,7 +218,6 @@ public class TimelinePlaylistManager implements PlaylistManager {
@Override
public boolean setMediaItem(Player player, MediaItem mediaItem) {
// TODO(jaewan): Distinguish setMediaItem(item) and setPlaylist({item})
List<MediaItem> playlist = new ArrayList<>();
playlist.add(mediaItem);
return setPlaylist(player, playlist, /* metadata */ null);