From aaa6561aa9f9af474f9db411309fac9cf418ed10 Mon Sep 17 00:00:00 2001 From: Googler Date: Thu, 25 Jul 2024 05:06:58 -0700 Subject: [PATCH] Rename tests in Boxestest Replace the box name with Codec name in the test. PiperOrigin-RevId: 655915063 --- .../test/java/androidx/media3/muxer/BoxesTest.java | 12 ++++++------ ...box_mp4a.dump => audio_sample_entry_box_aac.dump} | 0 ...x_samr.dump => audio_sample_entry_box_amrnb.dump} | 0 ...x_sawb.dump => audio_sample_entry_box_amrwb.dump} | 0 4 files changed, 6 insertions(+), 6 deletions(-) rename libraries/test_data/src/test/assets/muxerdumps/{audio_sample_entry_box_mp4a.dump => audio_sample_entry_box_aac.dump} (100%) rename libraries/test_data/src/test/assets/muxerdumps/{audio_sample_entry_box_samr.dump => audio_sample_entry_box_amrnb.dump} (100%) rename libraries/test_data/src/test/assets/muxerdumps/{audio_sample_entry_box_sawb.dump => audio_sample_entry_box_amrwb.dump} (100%) diff --git a/libraries/muxer/src/test/java/androidx/media3/muxer/BoxesTest.java b/libraries/muxer/src/test/java/androidx/media3/muxer/BoxesTest.java index 5bf00b235a..7ee7e1134d 100644 --- a/libraries/muxer/src/test/java/androidx/media3/muxer/BoxesTest.java +++ b/libraries/muxer/src/test/java/androidx/media3/muxer/BoxesTest.java @@ -232,7 +232,7 @@ public class BoxesTest { } @Test - public void createAudioSampleEntryBox_forMp4a_matchesExpected() throws Exception { + public void createAudioSampleEntryBox_forAac_matchesExpected() throws Exception { Format format = FAKE_AUDIO_FORMAT .buildUpon() @@ -244,29 +244,29 @@ public class BoxesTest { DumpableMp4Box dumpableBox = new DumpableMp4Box(audioSampleEntryBox); DumpFileAsserts.assertOutput( - context, dumpableBox, getExpectedDumpFilePath("audio_sample_entry_box_mp4a")); + context, dumpableBox, getExpectedDumpFilePath("audio_sample_entry_box_aac")); } @Test - public void createAudioSampleEntryBox_forSamr_matchesExpected() throws Exception { + public void createAudioSampleEntryBox_forAmrNb_matchesExpected() throws Exception { Format format = FAKE_AUDIO_FORMAT.buildUpon().setSampleMimeType(MimeTypes.AUDIO_AMR_NB).build(); ByteBuffer audioSampleEntryBox = Boxes.audioSampleEntry(format); DumpableMp4Box dumpableBox = new DumpableMp4Box(audioSampleEntryBox); DumpFileAsserts.assertOutput( - context, dumpableBox, getExpectedDumpFilePath("audio_sample_entry_box_samr")); + context, dumpableBox, getExpectedDumpFilePath("audio_sample_entry_box_amrnb")); } @Test - public void createAudioSampleEntryBox_forSawb_matchesExpected() throws Exception { + public void createAudioSampleEntryBox_forAmrWb_matchesExpected() throws Exception { Format format = FAKE_AUDIO_FORMAT.buildUpon().setSampleMimeType(MimeTypes.AUDIO_AMR_WB).build(); ByteBuffer audioSampleEntryBox = Boxes.audioSampleEntry(format); DumpableMp4Box dumpableBox = new DumpableMp4Box(audioSampleEntryBox); DumpFileAsserts.assertOutput( - context, dumpableBox, getExpectedDumpFilePath("audio_sample_entry_box_sawb")); + context, dumpableBox, getExpectedDumpFilePath("audio_sample_entry_box_amrwb")); } @Test diff --git a/libraries/test_data/src/test/assets/muxerdumps/audio_sample_entry_box_mp4a.dump b/libraries/test_data/src/test/assets/muxerdumps/audio_sample_entry_box_aac.dump similarity index 100% rename from libraries/test_data/src/test/assets/muxerdumps/audio_sample_entry_box_mp4a.dump rename to libraries/test_data/src/test/assets/muxerdumps/audio_sample_entry_box_aac.dump diff --git a/libraries/test_data/src/test/assets/muxerdumps/audio_sample_entry_box_samr.dump b/libraries/test_data/src/test/assets/muxerdumps/audio_sample_entry_box_amrnb.dump similarity index 100% rename from libraries/test_data/src/test/assets/muxerdumps/audio_sample_entry_box_samr.dump rename to libraries/test_data/src/test/assets/muxerdumps/audio_sample_entry_box_amrnb.dump diff --git a/libraries/test_data/src/test/assets/muxerdumps/audio_sample_entry_box_sawb.dump b/libraries/test_data/src/test/assets/muxerdumps/audio_sample_entry_box_amrwb.dump similarity index 100% rename from libraries/test_data/src/test/assets/muxerdumps/audio_sample_entry_box_sawb.dump rename to libraries/test_data/src/test/assets/muxerdumps/audio_sample_entry_box_amrwb.dump