From adffd43194a2fc693edee418aa1bd8b522eca747 Mon Sep 17 00:00:00 2001 From: tonihei Date: Thu, 18 Mar 2021 16:19:45 +0000 Subject: [PATCH] Remove AnalyticsCollector.resetForNewPlaylist. The methods has been a no-op for while now and can be removed. PiperOrigin-RevId: 363673199 --- .../com/google/android/exoplayer2/SimpleExoPlayer.java | 8 -------- .../android/exoplayer2/analytics/AnalyticsCollector.java | 5 ----- 2 files changed, 13 deletions(-) diff --git a/library/core/src/main/java/com/google/android/exoplayer2/SimpleExoPlayer.java b/library/core/src/main/java/com/google/android/exoplayer2/SimpleExoPlayer.java index 0f3613ad05..8aa879ea9a 100644 --- a/library/core/src/main/java/com/google/android/exoplayer2/SimpleExoPlayer.java +++ b/library/core/src/main/java/com/google/android/exoplayer2/SimpleExoPlayer.java @@ -1307,7 +1307,6 @@ public class SimpleExoPlayer extends BasePlayer @Override public void setMediaItems(List mediaItems, boolean resetPosition) { verifyApplicationThread(); - analyticsCollector.resetForNewPlaylist(); player.setMediaItems(mediaItems, resetPosition); } @@ -1315,21 +1314,18 @@ public class SimpleExoPlayer extends BasePlayer public void setMediaItems( List mediaItems, int startWindowIndex, long startPositionMs) { verifyApplicationThread(); - analyticsCollector.resetForNewPlaylist(); player.setMediaItems(mediaItems, startWindowIndex, startPositionMs); } @Override public void setMediaSources(List mediaSources) { verifyApplicationThread(); - analyticsCollector.resetForNewPlaylist(); player.setMediaSources(mediaSources); } @Override public void setMediaSources(List mediaSources, boolean resetPosition) { verifyApplicationThread(); - analyticsCollector.resetForNewPlaylist(); player.setMediaSources(mediaSources, resetPosition); } @@ -1337,28 +1333,24 @@ public class SimpleExoPlayer extends BasePlayer public void setMediaSources( List mediaSources, int startWindowIndex, long startPositionMs) { verifyApplicationThread(); - analyticsCollector.resetForNewPlaylist(); player.setMediaSources(mediaSources, startWindowIndex, startPositionMs); } @Override public void setMediaSource(MediaSource mediaSource) { verifyApplicationThread(); - analyticsCollector.resetForNewPlaylist(); player.setMediaSource(mediaSource); } @Override public void setMediaSource(MediaSource mediaSource, boolean resetPosition) { verifyApplicationThread(); - analyticsCollector.resetForNewPlaylist(); player.setMediaSource(mediaSource, resetPosition); } @Override public void setMediaSource(MediaSource mediaSource, long startPositionMs) { verifyApplicationThread(); - analyticsCollector.resetForNewPlaylist(); player.setMediaSource(mediaSource, startPositionMs); } diff --git a/library/core/src/main/java/com/google/android/exoplayer2/analytics/AnalyticsCollector.java b/library/core/src/main/java/com/google/android/exoplayer2/analytics/AnalyticsCollector.java index 55c37f754a..1f6a0ec50e 100644 --- a/library/core/src/main/java/com/google/android/exoplayer2/analytics/AnalyticsCollector.java +++ b/library/core/src/main/java/com/google/android/exoplayer2/analytics/AnalyticsCollector.java @@ -179,11 +179,6 @@ public class AnalyticsCollector } } - /** Resets the analytics collector for a new playlist. */ - public final void resetForNewPlaylist() { - // TODO: remove method. - } - // MetadataOutput events. /**