From b1cf04f22c89cb9141bfe619f483d570b62dcb59 Mon Sep 17 00:00:00 2001 From: ibaker Date: Fri, 8 Jan 2021 13:50:03 +0000 Subject: [PATCH] Tweak comment in PgsDecoder to match the structure of the data The Palette Definition Segment is documented here, you can is it goes: luminance (y), red (cr), blue (cb), alpha http://blog.thescorpius.com/index.php/2017/07/15/presentation-graphic-stream-sup-files-bluray-subtitle-format/ (I think it's important to be really precise here, because YCbCr is a very common format, so this ordering is slightly unusual: https://en.wikipedia.org/wiki/YCbCr) PiperOrigin-RevId: 350747808 --- .../java/com/google/android/exoplayer2/text/pgs/PgsDecoder.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/library/core/src/main/java/com/google/android/exoplayer2/text/pgs/PgsDecoder.java b/library/core/src/main/java/com/google/android/exoplayer2/text/pgs/PgsDecoder.java index 9229d27a41..ee0899af82 100644 --- a/library/core/src/main/java/com/google/android/exoplayer2/text/pgs/PgsDecoder.java +++ b/library/core/src/main/java/com/google/android/exoplayer2/text/pgs/PgsDecoder.java @@ -134,7 +134,7 @@ public final class PgsDecoder extends SimpleSubtitleDecoder { private void parsePaletteSection(ParsableByteArray buffer, int sectionLength) { if ((sectionLength % 5) != 2) { - // Section must be two bytes followed by a whole number of (index, y, cb, cr, a) entries. + // Section must be two bytes then a whole number of (index, Y, Cr, Cb, alpha) entries. return; } buffer.skipBytes(2);