chore(MediaSource): move getTag after removeEventListener

This commit is contained in:
GiuseppePiscopo 2018-12-03 18:21:37 +01:00
parent 8a359bb1fb
commit b278b02816
13 changed files with 79 additions and 79 deletions

View file

@ -76,6 +76,12 @@ public final class ImaAdsMediaSource extends BaseMediaSource implements SourceIn
adUiViewGroup, eventHandler, eventListener); adUiViewGroup, eventHandler, eventListener);
} }
@Override
@Nullable
public Object getTag() {
return adsMediaSource.getTag();
}
@Override @Override
public void prepareSourceInternal( public void prepareSourceInternal(
final ExoPlayer player, final ExoPlayer player,
@ -100,12 +106,6 @@ public final class ImaAdsMediaSource extends BaseMediaSource implements SourceIn
adsMediaSource.releasePeriod(mediaPeriod); adsMediaSource.releasePeriod(mediaPeriod);
} }
@Override
@Nullable
public Object getTag() {
return adsMediaSource.getTag();
}
@Override @Override
public void releaseSourceInternal() { public void releaseSourceInternal() {
adsMediaSource.releaseSource(/* listener= */ this); adsMediaSource.releaseSource(/* listener= */ this);

View file

@ -186,6 +186,12 @@ public final class ClippingMediaSource extends CompositeMediaSource<Void> {
window = new Timeline.Window(); window = new Timeline.Window();
} }
@Override
@Nullable
public Object getTag() {
return mediaSource.getTag();
}
@Override @Override
public void prepareSourceInternal( public void prepareSourceInternal(
ExoPlayer player, ExoPlayer player,
@ -224,12 +230,6 @@ public final class ClippingMediaSource extends CompositeMediaSource<Void> {
} }
} }
@Override
@Nullable
public Object getTag() {
return mediaSource.getTag();
}
@Override @Override
public void releaseSourceInternal() { public void releaseSourceInternal() {
super.releaseSourceInternal(); super.releaseSourceInternal();

View file

@ -453,6 +453,12 @@ public class ConcatenatingMediaSource extends CompositeMediaSource<MediaSourceHo
} }
} }
@Override
@Nullable
public Object getTag() {
return null;
}
@Override @Override
public final synchronized void prepareSourceInternal( public final synchronized void prepareSourceInternal(
ExoPlayer player, ExoPlayer player,
@ -508,12 +514,6 @@ public class ConcatenatingMediaSource extends CompositeMediaSource<MediaSourceHo
maybeReleaseChildSource(holder); maybeReleaseChildSource(holder);
} }
@Override
@Nullable
public Object getTag() {
return null;
}
@Override @Override
public final void releaseSourceInternal() { public final void releaseSourceInternal() {
super.releaseSourceInternal(); super.releaseSourceInternal();

View file

@ -358,6 +358,12 @@ public final class ExtractorMediaSource extends BaseMediaSource
this.tag = tag; this.tag = tag;
} }
@Override
@Nullable
public Object getTag() {
return tag;
}
@Override @Override
public void prepareSourceInternal( public void prepareSourceInternal(
ExoPlayer player, ExoPlayer player,
@ -395,12 +401,6 @@ public final class ExtractorMediaSource extends BaseMediaSource
((ExtractorMediaPeriod) mediaPeriod).release(); ((ExtractorMediaPeriod) mediaPeriod).release();
} }
@Override
@Nullable
public Object getTag() {
return tag;
}
@Override @Override
public void releaseSourceInternal() { public void releaseSourceInternal() {
// Do nothing. // Do nothing.

View file

@ -64,6 +64,12 @@ public final class LoopingMediaSource extends CompositeMediaSource<Void> {
mediaPeriodToChildMediaPeriodId = new HashMap<>(); mediaPeriodToChildMediaPeriodId = new HashMap<>();
} }
@Override
@Nullable
public Object getTag() {
return childSource.getTag();
}
@Override @Override
public void prepareSourceInternal( public void prepareSourceInternal(
ExoPlayer player, ExoPlayer player,
@ -95,12 +101,6 @@ public final class LoopingMediaSource extends CompositeMediaSource<Void> {
} }
} }
@Override
@Nullable
public Object getTag() {
return childSource.getTag();
}
@Override @Override
protected void onChildSourceInfoRefreshed( protected void onChildSourceInfoRefreshed(
Void id, MediaSource mediaSource, Timeline timeline, @Nullable Object manifest) { Void id, MediaSource mediaSource, Timeline timeline, @Nullable Object manifest) {

View file

@ -219,6 +219,11 @@ public interface MediaSource {
*/ */
void removeEventListener(MediaSourceEventListener eventListener); void removeEventListener(MediaSourceEventListener eventListener);
/**
* Returns the tag set on the media source, or null when none was set.
*/
@Nullable Object getTag();
/** /**
* Starts source preparation if not yet started, and adds a listener for timeline and/or manifest * Starts source preparation if not yet started, and adds a listener for timeline and/or manifest
* updates. * updates.
@ -275,11 +280,6 @@ public interface MediaSource {
*/ */
void releasePeriod(MediaPeriod mediaPeriod); void releasePeriod(MediaPeriod mediaPeriod);
/**
* Returns the tag set on media source, or null when none was set.
*/
Object getTag();
/** /**
* Removes a listener for timeline and/or manifest updates and releases the source if no longer * Removes a listener for timeline and/or manifest updates and releases the source if no longer
* required. * required.

View file

@ -98,6 +98,12 @@ public final class MergingMediaSource extends CompositeMediaSource<Integer> {
timelines = new Timeline[mediaSources.length]; timelines = new Timeline[mediaSources.length];
} }
@Override
@Nullable
public Object getTag() {
return mediaSources.length > 0 ? mediaSources[0].getTag() : null;
}
@Override @Override
public void prepareSourceInternal( public void prepareSourceInternal(
ExoPlayer player, ExoPlayer player,
@ -137,12 +143,6 @@ public final class MergingMediaSource extends CompositeMediaSource<Integer> {
} }
} }
@Override
@Nullable
public Object getTag() {
return mediaSources.length > 0 ? mediaSources[0].getTag() : null;
}
@Override @Override
public void releaseSourceInternal() { public void releaseSourceInternal() {
super.releaseSourceInternal(); super.releaseSourceInternal();

View file

@ -297,6 +297,12 @@ public final class SingleSampleMediaSource extends BaseMediaSource {
// MediaSource implementation. // MediaSource implementation.
@Override
@Nullable
public Object getTag() {
return tag;
}
@Override @Override
public void prepareSourceInternal( public void prepareSourceInternal(
ExoPlayer player, ExoPlayer player,
@ -329,12 +335,6 @@ public final class SingleSampleMediaSource extends BaseMediaSource {
((SingleSampleMediaPeriod) mediaPeriod).release(); ((SingleSampleMediaPeriod) mediaPeriod).release();
} }
@Override
@Nullable
public Object getTag() {
return tag;
}
@Override @Override
public void releaseSourceInternal() { public void releaseSourceInternal() {
// Do nothing. // Do nothing.

View file

@ -319,6 +319,12 @@ public final class AdsMediaSource extends CompositeMediaSource<MediaPeriodId> {
adsLoader.setSupportedContentTypes(adMediaSourceFactory.getSupportedTypes()); adsLoader.setSupportedContentTypes(adMediaSourceFactory.getSupportedTypes());
} }
@Override
@Nullable
public Object getTag() {
return contentMediaSource.getTag();
}
@Override @Override
public void prepareSourceInternal( public void prepareSourceInternal(
final ExoPlayer player, final ExoPlayer player,
@ -387,12 +393,6 @@ public final class AdsMediaSource extends CompositeMediaSource<MediaPeriodId> {
deferredMediaPeriod.releasePeriod(); deferredMediaPeriod.releasePeriod();
} }
@Override
@Nullable
public Object getTag() {
return contentMediaSource.getTag();
}
@Override @Override
public void releaseSourceInternal() { public void releaseSourceInternal() {
super.releaseSourceInternal(); super.releaseSourceInternal();

View file

@ -607,6 +607,12 @@ public final class DashMediaSource extends BaseMediaSource {
// MediaSource implementation. // MediaSource implementation.
@Override
@Nullable
public Object getTag() {
return tag;
}
@Override @Override
public void prepareSourceInternal( public void prepareSourceInternal(
ExoPlayer player, ExoPlayer player,
@ -658,12 +664,6 @@ public final class DashMediaSource extends BaseMediaSource {
periodsById.remove(dashMediaPeriod.id); periodsById.remove(dashMediaPeriod.id);
} }
@Override
@Nullable
public Object getTag() {
return tag;
}
@Override @Override
public void releaseSourceInternal() { public void releaseSourceInternal() {
manifestLoadPending = false; manifestLoadPending = false;

View file

@ -390,6 +390,12 @@ public final class HlsMediaSource extends BaseMediaSource
this.tag = tag; this.tag = tag;
} }
@Override
@Nullable
public Object getTag() {
return tag;
}
@Override @Override
public void prepareSourceInternal( public void prepareSourceInternal(
ExoPlayer player, ExoPlayer player,
@ -425,12 +431,6 @@ public final class HlsMediaSource extends BaseMediaSource
((HlsMediaPeriod) mediaPeriod).release(); ((HlsMediaPeriod) mediaPeriod).release();
} }
@Override
@Nullable
public Object getTag() {
return tag;
}
@Override @Override
public void releaseSourceInternal() { public void releaseSourceInternal() {
playlistTracker.stop(); playlistTracker.stop();

View file

@ -503,6 +503,12 @@ public final class SsMediaSource extends BaseMediaSource
// MediaSource implementation. // MediaSource implementation.
@Override
@Nullable
public Object getTag() {
return tag;
}
@Override @Override
public void prepareSourceInternal( public void prepareSourceInternal(
ExoPlayer player, ExoPlayer player,
@ -549,12 +555,6 @@ public final class SsMediaSource extends BaseMediaSource
mediaPeriods.remove(period); mediaPeriods.remove(period);
} }
@Override
@Nullable
public Object getTag() {
return tag;
}
@Override @Override
public void releaseSourceInternal() { public void releaseSourceInternal() {
manifest = sideloadedManifest ? manifest : null; manifest = sideloadedManifest ? manifest : null;

View file

@ -88,6 +88,14 @@ public class FakeMediaSource extends BaseMediaSource {
this.trackGroupArray = trackGroupArray; this.trackGroupArray = trackGroupArray;
} }
@Override
@Nullable
public Object getTag() {
boolean hasTimeline = timeline != null && !timeline.isEmpty();
return hasTimeline ? timeline.getWindow(0, new Timeline.Window()).tag : null;
}
@Override @Override
public synchronized void prepareSourceInternal( public synchronized void prepareSourceInternal(
ExoPlayer player, ExoPlayer player,
@ -133,14 +141,6 @@ public class FakeMediaSource extends BaseMediaSource {
fakeMediaPeriod.release(); fakeMediaPeriod.release();
} }
@Override
@Nullable
public Object getTag() {
boolean hasTimeline = timeline != null && !timeline.isEmpty();
return hasTimeline ? timeline.getWindow(0, new Timeline.Window()).tag : null;
}
@Override @Override
public void releaseSourceInternal() { public void releaseSourceInternal() {
assertThat(preparedSource).isTrue(); assertThat(preparedSource).isTrue();