sjs/media
1
0
Fork 0
mirror of https://github.com/samsonjs/media.git synced 2026-04-27 15:07:40 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Update PlayerWrapper methods to return void where possible

Browse source 
Suggested during the review of 437d1b6e9a

This keeps the Runnable -> Callable<Boolean> conversion encapsulated
inside SessionPlayerConnector which makes it clearer why it's needed.

PiperOrigin-RevId: 321553744
This commit is contained in:
ibaker 2020-07-16 14:32:31 +01:00 committed by Oliver Woodman
parent c0204bfdc4
commit b755df1338
2 changed files with 10 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
extensions/media2/src/main/java/com/google/android/exoplayer2/ext/media2/PlayerWrapper.java
View file

@ -305,11 +305,10 @@ import java.util.List;
} }
} }
public boolean setAudioAttributes(AudioAttributesCompat audioAttributes) { public void setAudioAttributes(AudioAttributesCompat audioAttributes) {
Player.AudioComponent audioComponent = Assertions.checkStateNotNull(player.getAudioComponent()); Player.AudioComponent audioComponent = Assertions.checkStateNotNull(player.getAudioComponent());
audioComponent.setAudioAttributes( audioComponent.setAudioAttributes(
Utils.getAudioAttributes(audioAttributes), /* handleAudioFocus= */ true); Utils.getAudioAttributes(audioAttributes), /* handleAudioFocus= */ true);
return true;
} }
public AudioAttributesCompat getAudioAttributes() { public AudioAttributesCompat getAudioAttributes() {
@ -318,9 +317,8 @@ import java.util.List;
audioComponent != null ? audioComponent.getAudioAttributes() : AudioAttributes.DEFAULT); audioComponent != null ? audioComponent.getAudioAttributes() : AudioAttributes.DEFAULT);
} }
public boolean setPlaybackSpeed(float playbackSpeed) { public void setPlaybackSpeed(float playbackSpeed) {
player.setPlaybackSpeed(playbackSpeed); player.setPlaybackSpeed(playbackSpeed);
return true;
} }
public float getPlaybackSpeed() { public float getPlaybackSpeed() {

10
extensions/media2/src/main/java/com/google/android/exoplayer2/ext/media2/SessionPlayerConnector.java
View file

@ -178,14 +178,20 @@ public final class SessionPlayerConnector extends SessionPlayer {
Assertions.checkArgument(playbackSpeed > 0f); Assertions.checkArgument(playbackSpeed > 0f);
return playerCommandQueue.addCommand( return playerCommandQueue.addCommand(
PlayerCommandQueue.COMMAND_CODE_PLAYER_SET_SPEED, PlayerCommandQueue.COMMAND_CODE_PLAYER_SET_SPEED,
/* command= */ () -> player.setPlaybackSpeed(playbackSpeed)); /* command= */ () -> {
player.setPlaybackSpeed(playbackSpeed);
return true;
});
} }
@Override @Override
public ListenableFuture<PlayerResult> setAudioAttributes(AudioAttributesCompat attr) { public ListenableFuture<PlayerResult> setAudioAttributes(AudioAttributesCompat attr) {
return playerCommandQueue.addCommand( return playerCommandQueue.addCommand(
PlayerCommandQueue.COMMAND_CODE_PLAYER_SET_AUDIO_ATTRIBUTES, PlayerCommandQueue.COMMAND_CODE_PLAYER_SET_AUDIO_ATTRIBUTES,
/* command= */ () -> player.setAudioAttributes(Assertions.checkNotNull(attr))); /* command= */ () -> {
player.setAudioAttributes(Assertions.checkNotNull(attr));
return true;
});
} }
@Override @Override