sjs/media
1
0
Fork 0
mirror of https://github.com/samsonjs/media.git synced 2026-04-27 15:07:40 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

MediaControllerWithMediaSessionCompatTest

Browse source 
Fix a race condition making test flaky.

PiperOrigin-RevId: 480104467
This commit is contained in:
christosts 2022-10-10 16:34:13 +00:00 committed by Marc Baechinger
parent b0daae72cf
commit cb3a672508
1 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
libraries/test_session_current/src/androidTest/java/androidx/media3/session/MediaControllerWithMediaSessionCompatTest.java
View file

@ -168,6 +168,7 @@ public class MediaControllerWithMediaSessionCompatTest {
@Test @Test
public void disconnected_byControllerReleaseRightAfterCreated() throws Exception { public void disconnected_byControllerReleaseRightAfterCreated() throws Exception {
CountDownLatch latch = new CountDownLatch(1); CountDownLatch latch = new CountDownLatch(1);
AtomicReference<Exception> exception = new AtomicReference<>();
MediaController controller = MediaController controller =
controllerTestRule.createController( controllerTestRule.createController(
session.getSessionToken(), session.getSessionToken(),
@ -177,8 +178,16 @@ public class MediaControllerWithMediaSessionCompatTest {
latch.countDown(); latch.countDown();
} }
}, },
/* controllerCreationListener= */ MediaController::release); /* controllerCreationListener= */ mediaController -> {
// We must release the controller on the app thread.
try {
threadTestRule.getHandler().postAndSync(() -> mediaController.release());
} catch (Exception e) {
exception.set(e);
}
});
assertThat(latch.await(TIMEOUT_MS, MILLISECONDS)).isTrue(); assertThat(latch.await(TIMEOUT_MS, MILLISECONDS)).isTrue();
assertThat(exception.get()).isNull();
assertThat(controller.isConnected()).isFalse(); assertThat(controller.isConnected()).isFalse();
} }